Re: CFV: New OpenJFX Committer: Ajit Ghaisas

2017-05-26 Thread David Hill
to a project Committer is described in [4]. Thanks. -- Kevin [1] http://openjdk.java.net/census#aghaisas [2] http://openjdk.java.net/census#openjfx [3] http://openjdk.java.net/bylaws#lazy-consensus [4] http://openjdk.java.net/projects#project-committer -- David Hill<david.h...@oracle.com>

Review: Remove Lens code (finally)

2017-04-18 Thread David Hill
this should be safe. https://bugs.openjdk.java.net/browse/JDK-8090969 webrev: http://cr.openjdk.java.net/~ddhill/8090969 -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Re: [10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-05 Thread David Hill
- or similar - is bad for performance. If you want to measure the effect of such change, remote display to your desktop from a machine in a geographically distant site. It is the latency that kills performance, not the bandwidth. -phil. On 4/4/17, 3:43 PM, David Hill wrote: On 4/4/17, 1:27 PM, Semyon

Review: Provide generic add-exports mechanism

2017-04-04 Thread David Hill
Kevin, Jonathan, https://bugs.openjdk.java.net/browse/JDK-8178075 webrev: http://cr.openjdk.java.net/~ddhill/8178075 -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." --

Re: [10] Review request for 8176844: Menus not always selected properly with GTK 3

2017-04-04 Thread David Hill
he X server. This is used in the GtkText and GtkCList widgets in GTK+ to make sure any GraphicsExpose events are handled before the widget is scrolled. so perhaps this should be used in some cases (like setVisible). sigh. Will try to make up my mind tomorrow. Dave. -- David Hill<

Re: review: Generate bss for all css files, remove TODO

2017-03-30 Thread David Hill
other part of the question was if we even should ship the .css files a all and css2bin. To shorten a long conversation, continuing to do so allows widget developers access to them, access we have no other standard way of providing. Dave On 3/30/17 1:50 PM, David Hill wrote: Jonathan, ple

review: Generate bss for all css files, remove TODO

2017-03-30 Thread David Hill
/8174944/ -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

heads up... gradle 3.4 does not play nice

2017-03-07 Thread David Hill
: cannot specify both --source-path and --module-source-path -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review: correct developer script make_runargs.sh

2017-02-17 Thread David Hill
Kevin, a small set of changes to the make_runargs.sh script https://bugs.openjdk.java.net/browse/JDK-8175207 webrev: http://cr.openjdk.java.net/~ddhill/8175207/ <http://cr.openjdk.java.net/%7Eddhill/8175207/> -- David Hill<david.h...@oracle.com> Java Embedded Development &

review: Resources are not copied to the shims directory causing unit test failures

2017-02-14 Thread David Hill
Kevin, jbs: https://bugs.openjdk.java.net/browse/JDK-8174763 webrev: http://cr.openjdk.java.net/~ddhill/8174763.3/ <http://cr.openjdk.java.net/%7Eddhill/8174763.3/> -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his

Re: Is a Desktop Experience on ARM with X11 Possible?

2017-02-09 Thread David Hill
line toggle, or a small edit to the created platform properties file. -Djavafx.platform=gtk -Dprism.verbose=true Note that there is a good chance that this will not be hardware accelerated because of differences in GL setup. Dave Scott -- David Hill<david.h...@oracle.com> Java Em

Result: New OpenJFX Committer: Semyon Sadetsky

2017-02-09 Thread David Hill
Voting for Semyon Sadetsky to OpenJFX Committer [1] is now closed. Yes: 9 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Dave [1] http://mail.openjdk.java.net/pipermail/openjfx-dev/2014-May/013881.html -- David Hill

Re: review: Clean up gradle dependancies and build times

2017-02-08 Thread David Hill
On 2/7/17, 3:10 PM, David Hill wrote: Hello, closing in on a final version of this gradle rework. There is an updated webrev in: https://bugs.openjdk.java.net/browse/JDK-8172237 This fix has a number of cleanups that should help with developer "gradle sdk" times. We added

review: Clean up gradle dependancies and build times

2017-02-07 Thread David Hill
.4/ <http://cr.openjdk.java.net/%7Eddhill/8172237.4/> -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review: fix developer script compareBuilds to properly support windows

2017-02-01 Thread David Hill
https://bugs.openjdk.java.net/browse/JDK-8173779 webrev: http://cr.openjdk.java.net/~ddhill/8173779 -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review: correct build.gradle buildVersionFile

2017-02-01 Thread David Hill
Kevin, Chris, this seems to fix and issue where version.properties may or may not be in ant-javafx.jar https://bugs.openjdk.java.net/browse/JDK-8173767 webrev: http://cr.openjdk.java.net/~ddhill/8173767/ <http://cr.openjdk.java.net/%7Eddhill/8173767/> -- David Hill<david.h...@o

review: add developer script whatsChanged

2017-01-31 Thread David Hill
Kevin, please review this developer script: jbs: https://bugs.openjdk.java.net/browse/JDK-8173696 webrev: http://cr.openjdk.java.net/~ddhill/8173696 -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes sh

CFV: New OpenJFX Committer: Semyon Sadetsky

2017-01-25 Thread David Hill
I hereby nominate Semyon Sadetsky to OpenJFX Committer. Semyon Sadetsky is part of the JavaFX team focusing on glass. A list of Semyon's commits and reviews is available by the following links http://hg.openjdk.java.net/openjfx/9-dev/rt/log?rev=author%28ssadetsky%29 Votes are due by Feb 9th,

Review request: Fx applet fails to get loaded on Ubuntu with jre9-b150

2017-01-11 Thread David Hill
Kevin, Jim, please review: https://bugs.openjdk.java.net/browse/JDK-8171985 webrev: http://cr.openjdk.java.net/~ddhill/8171985.1 <http://cr.openjdk.java.net/%7Eddhill/8171985.1> -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be plant

Review: create a run.java.policy file

2017-01-04 Thread David Hill
Kevin, if you could review: https://bugs.openjdk.java.net/browse/JDK-8172243 webrev: http://cr.openjdk.java.net/~ddhill/8172243 <http://cr.openjdk.java.net/%7Eddhill/8172243> thanks, Dave -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet

Correct warning in linux build

2017-01-04 Thread David Hill
-- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review: Failure to fallback to sw pipeline with remote connections

2016-12-19 Thread David Hill
Now that cr is back online a small fix to error detection, enabling fallback. jbs: https://bugs.openjdk.java.net/browse/JDK-8171403 webrev: http://cr.openjdk.java.net/~ddhill/8171403/ -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be pla

review: update compareBuilds script

2016-12-15 Thread David Hill
Kevin, an update to a utility script that compares build outputs jbs: https://bugs.openjdk.java.net/browse/JDK-8171326 webrev: http://cr.openjdk.java.net/~ddhill/8171326.1 <http://cr.openjdk.java.net/%7Eddhill/8171326.1> -- David Hill<david.h...@oracle.com> Java Embedded

Re: initial webrev for review

2016-11-21 Thread David Hill
On 11/21/16, 2:37 PM, David Hill wrote: updated: http://cr.openjdk.java.net/~ddhill/8163496.1 This fixed the popup issue I was seeing. Kevin, Chien, Semyon, Here is the initial webrev for reworking libglass addressing GTK issues. I am calling it inital because I have not finished the large

initial webrev for review

2016-11-21 Thread David Hill
: GTK3 and popup windows, which seems to be an existing issue which I am chasing. -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review: javac @compile.args does not pick up changes in local build

2016-11-17 Thread David Hill
Kevin: https://bugs.openjdk.java.net/browse/JDK-8169747 http://cr.openjdk.java.net/~ddhill/8169747 -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Wikie Building OpenJFX has been update

2016-11-14 Thread David Hill
I just reworked: https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX to show the current 9-dev reality of a modular build. -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey

review: fix old jar list in build.gradle

2016-11-10 Thread David Hill
Kevin, would you review: https://bugs.openjdk.java.net/browse/JDK-8169552 diff is inside the bug. -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review: correct concatenation of dependencies/*/*.extra files

2016-11-09 Thread David Hill
Kevin, if you would review JBS: https://bugs.openjdk.java.net/browse/JDK-8169511 diff inline. -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Modular build: understanding addExports

2016-11-08 Thread David Hill
ern. The Decora build for example has the --add-exports explicitly in build.gradle. -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

FX Modular build - FIVE Shocking things you need to know about the new build....

2016-11-08 Thread David Hill
<http://bits.netbeans.org/download/trunk/nightly/latest/> Intellij: https://confluence.jetbrains.com/display/IDEADEV/EAP -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

ACTION - JavaFX modular build is here

2016-11-08 Thread David Hill
. At this point, sync in the new changes and build it ! export JDK_HOME=_path_to_jdk_9_ea_142+ $GRADLE3_HOME/bin/gradle clean sdk [1] https://gradle.org/gradle-download/ [2] https://jdk9.java.net/download/ [3] https://ant.apache.org/bindownload.cgi -- David Hill<david.h...@oracle.com> Java Em

Re: Issues porting to Monocle EPD platform

2016-11-07 Thread David Hill
ce class. The third issue, "Get two bytes for the Linux input event type, not four," doesn't seem to cause any problems, but may still be worth fixing. Thank you, John -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted i

Heads up: Modular build is close.....

2016-11-07 Thread David Hill
run: gradle clean or hg purge --all to tidy up your repo (or both :-) [1] https://gradle.org/gradle-download/ [2] https://jdk9.java.net/download/ [3] https://ant.apache.org/bindownload.cgi -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be pla

Re: Review: Switch to Jigsaw-aware boot JDK for compiling FX 9

2016-11-02 Thread David Hill
uried due to lexical sorting by path name. In particular files like build.gradle and so on .. people then get a sense of what it is about rather than first wading through the noise. -phil. On 11/2/2016 9:55 AM, David Hill wrote: JBS: https://bugs.openjdk.java.net/browse/JDK-8161704 Webrev: http:/

Review: Switch to Jigsaw-aware boot JDK for compiling FX 9

2016-11-02 Thread David Hill
dk adding in a modular build creating rt/build/*.args argfiles to ease development. A big notes: we had to change the build target to 1.9 javac.source=1.9 javac.target=1.9 because in many of the places javac would baulk at using the JDK9 commands without it. It is expected that the

Change coming in the JFX development line

2016-10-31 Thread David Hill
[3] JDK-8161704: Switch to Jigsaw-aware boot JDK for compiling FX 9 [1] https://gradle.org/gradle-download/ [2] https://jdk9.java.net/download/ [3] https://bugs.openjdk.java.net/browse/JDK-8161704 -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should

Re: :graphics:compilePrismCompilers fails with latest 9-dev tip on my mac

2016-09-21 Thread David Hill
a supertype @Override ^ 45 errors :graphics:compilePrismCompilers FAILED -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review: @native annotations

2016-09-16 Thread David Hill
esets just allow us to get ready for that future, and reduce the risk of merge conflicts later. -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review: change checkWhiteSpace to match jcheck extension list

2016-09-13 Thread David Hill
Kevin, https://bugs.openjdk.java.net/browse/JDK-8165963 (JDK-8165963) change checkWhiteSpace to match jcheck extension list diff in JBS. -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey

review: Rework build to enable future jigsaw aware JDK9 build

2016-09-11 Thread David Hill
Kevin, would you review this build change please. https://bugs.openjdk.java.net/browse/JDK-8165809 http://cr.openjdk.java.net/~ddhill/8165809.1 -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes sh

HEADS UP and review for new gnu style java command line options

2016-08-22 Thread David Hill
ions <https://bugs.openjdk.java.net/browse/JDK-8163316> Webrev: http://cr.openjdk.java.net/~ddhill/8163316.3 <http://cr.openjdk.java.net/%7Eddhill/8163316.2> -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, bu

review: protect FileChooser return from internal NPE

2016-08-09 Thread David Hill
Kevin, protect FileChooser return from internal NPE https://bugs.openjdk.java.net/browse/JDK-8163526 inline in jbs. Tested with a problem reproducer on windows. -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his

review: Add HelloDirectoryChooser toy.

2016-08-09 Thread David Hill
Kevin or Chien, could you review this toy addition: https://bugs.openjdk.java.net/browse/JDK-8163514 webrev: http://cr.openjdk.java.net/~ddhill/8163514 -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes sh

review: Support Gradle version 2.14+

2016-08-09 Thread David Hill
jbs: https://bugs.openjdk.java.net/browse/JDK-8163502 webrev: http://cr.openjdk.java.net/~ddhill/8163502/ Had to handle a couple of new package renames. -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes sh

Re: In(Sanity) Testing Mondays

2016-08-05 Thread David Hill
will now honor the JFX_XPATCH if JIGSAW_HOME is set. -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Re: Compiling OpenJFX on OpenBSD

2016-08-04 Thread David Hill
to help with this issue, though I have a rather large heap on my plate right now, so response time will vary. dave - Jyri -- Turvamies IT Security Services -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes sh

Re: Compiling OpenJFX on OpenBSD

2016-08-04 Thread David Hill
radle, fix the compile line issues in that configuration and then build with gradle -PCOMPILE_TARGETS=bsd With the change you have done, we would treat the platform as similar to linux, but with a configuration of bsd. Dave - Jyri -- Turvamies IT Security Services -- David Hill<david.h...@ora

review: Build should fail fast with unsupported OS/ARCH

2016-08-04 Thread David Hill
thanks to Jyri's email, I have a simple fix to fail quickly and with a understandable error message. jbs: https://bugs.openjdk.java.net/browse/JDK-8163196 simple diff inside jbs -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in

Re: Compiling OpenJFX on OpenBSD

2016-08-04 Thread David Hill
Pakhnushev wrote: I'd say the culprit is here: 08:38:45.852 [INFO] [org.gradle.api.Project] Applying COMPILE_FLAGS_FILE 'buildSrc/.gradle' I think that COMPILE_TARGETS is "" since it's not a "mac", not a "win" nor a "linux". Vadim -- David Hill<david.h...@o

Re: Compiling OpenJFX on OpenBSD

2016-08-04 Thread David Hill
614) at build_17kvkvc4f9j45htivwn1v303b.run(/tmp/rt-b41445afa464/build.gradle:612) at org.gradle.groovy.scripts.internal.DefaultScriptRunnerFactory$ScriptRunnerImpl.run(DefaultScriptRunnerFactory.java:91) ... 47 more BUILD FAILED Total time: 19.946 secs -- David Hill<d

Result: New OpenJFX Committer:Ankit Srivastava

2016-08-03 Thread David Hill
-- David Hill <david.h...@oracle.com> Java Embedded Development "The most likely way for the world to be destroyed, most experts agree, is by accident. That's where we come in; we're computer professionals. We cause accidents." -- Nathaniel Borenstein (1957 - )

review: Add xpatch argfile creation script

2016-08-01 Thread David Hill
r whatever the build output to another location. The arguments in the file really have to be full paths to enable Java to find them. Script is attached to the JBS. -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but h

Migrating FX patches to/from module paths

2016-08-01 Thread David Hill
tch is correct! Likely the new_patch will fail to apply cleanly if there is an error, but check the resulting diffs to make sure. * your mileage may vary. -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his ey

review: Fix more hardcoded paths in gradle build

2016-07-21 Thread David Hill
Kevin, if you could review: https://bugs.openjdk.java.net/browse/JDK-8162114 webrev: http://cr.openjdk.java.net/~ddhill/8162114 <http://cr.openjdk.java.net/%7Eddhill/8162114> -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be plant

CFV: New OpenJFX Committer: Ankit Srivastava

2016-07-19 Thread David Hill
I hereby nominate Ankit Srivastava to OpenJFX Committer. Ankit Srivastava is part of the JavaFX team focusing on Web. A list of Ankit's commits and reviews is available by the following links http://hg.openjdk.java.net/openjfx/8u-dev/rt/log?rev=a.ankit.srivast...@oracle.com

Review: Clean up module relative paths in build.gradle

2016-07-13 Thread David Hill
Chien, could you review: https://bugs.openjdk.java.net/browse/JDK-8161227 webrev: http://cr.openjdk.java.net/~ddhill/8161227 <http://cr.openjdk.java.net/%7Eddhill/8161227> -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be plant

Re: [9] Review Request: 8149975: [packager] Programmatically Determine JDK or JRE Modules

2016-07-06 Thread David Hill
t;, I wonder if they are in place already. Dave -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Re: Building OpenJFX for the first time

2016-06-28 Thread David Hill
accomplish this? Thanks very much, John -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Re: Openjfx on Wanboard

2016-06-08 Thread David Hill
quot;just work" :-) Also - never tried the Wandboard. I know it is a varient of the i.MX so likely will just work. Some of the ARM boards are not so easy though. Dave -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his count

review: remove old annotations from web

2016-05-20 Thread David Hill
Kevin, another inline diff: https://bugs.openjdk.java.net/browse/JDK-8157477 -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review: missing export to fxml in base module

2016-05-20 Thread David Hill
Kevin, a patch inline: https://bugs.openjdk.java.net/browse/JDK-8157473 -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review: Correct unused import in FXDnD

2016-05-19 Thread David Hill
Kevin, https://bugs.openjdk.java.net/browse/JDK-8157390 webrev: http://cr.openjdk.java.net/~ddhill/8157390 <http://cr.openjdk.java.net/%7Eddhill/8157390> -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, bu

review: remove use of GetPropertyAction

2016-05-18 Thread David Hill
Kevin, https://bugs.openjdk.java.net/browse/JDK-8157280 webrev: http://cr.openjdk.java.net/~ddhill/8157280 <http://cr.openjdk.java.net/%7Eddhill/8157280> -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his e

Re: Support for GTK 2 & 3 now in JFX

2016-05-09 Thread David Hill
8156491>, but that has some portability issues and might not make the final product. I am not aware of any reason why there would be an issue - unless there is something with the GTK event loop. Let me know if you give it a try. Dave regards, Erik On Mon, May 9, 2016 at 3:18 PM, David Hil

Support for GTK 2 & 3 now in JFX

2016-05-09 Thread David Hill
be appreciated, along with a note to me with the OS version. thanks! -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review v4: [JavaFX] Conditional support for GTK 3 on Linux

2016-05-06 Thread David Hill
Minor cleanups version 4: http://cr.openjdk.java.net/~ddhill/8087516.4/ changes from 3: http://cr.openjdk.java.net/~ddhill/8087516.4d/ -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey

JFX - Running with Jigsaw in development

2016-05-05 Thread David Hill
built binaries. Get your Jigsaw enabled JDK9 preview here: https://jdk9.java.net/download/ -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review v3: [JavaFX] Conditional support for GTK 3 on Linux

2016-05-04 Thread David Hill
erge in GlassApplication.cpp -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review:

2016-05-03 Thread David Hill
Kevin, please review this fix to update our handling of -Xpatch with tests and provide a @xpatch.args for general developement. https://bugs.openjdk.java.net/browse/JDK-8155862 http://cr.openjdk.java.net/~ddhill/8155862 <http://cr.openjdk.java.net/%7Eddhill/8155862> -- David Hill&l

review: [JavaFX] Conditional support for GTK 3 on Linux

2016-05-03 Thread David Hill
& 3 for me. http://cr.openjdk.java.net/~ddhill/8087516.2/ -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review for minor changes to build.gradle

2016-05-02 Thread David Hill
Kevin, a couple of proposed changes to build.gradle. Diffs are inline in the bugs. Provide for extra jvm arguments for gradle test task https://bugs.openjdk.java.net/browse/JDK-8155831 Allow disabling :web:test https://bugs.openjdk.java.net/browse/JDK-8155832 -- David Hill<davi

Re: CFV: New OpenJFX Committer: Guru Hb

2016-04-28 Thread David Hill
/0576d7a6f137 http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/d4f8c9496683 http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/620f5c6b4383 http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/aa51df7e1d41 -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be pla

Re: [9] Review request: 8154186: JVM crash while using JavaFW WebView and colgroup/cols html feature

2016-04-27 Thread David Hill
t/~ghb/8154186/webrev.00/ Root Cause and solution updated in JBS. Thanks, Guru -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review for Linux: unit test failures in ImageTest on some systems

2016-04-26 Thread David Hill
Kevin, Linux: unit test failures in ImageTest on some systems https://bugs.openjdk.java.net/browse/JDK-8089960 http://cr.openjdk.java.net/~ddhill/ 8089960 <https://bugs.openjdk.java.net/browse/JDK-8089960> -- David Hill<david.h...@oracle.com> Java Embedded Development "A

review:

2016-04-26 Thread David Hill
Morris, would you please review: JDK-8155114: Set both X and Y position for some window managers <https://bugs.openjdk.java.net/browse/JDK-8155114> webrev: http://cr.openjdk.java.net/~ddhill/8155114/ -- David Hill<david.h...@oracle.com> Java Embedded Development "A

Re: early draft for 8087516: [JavaFX] Conditional support for GTK 3 on Linux

2016-04-24 Thread David Hill
th SWT on Gtk3 or Gtk2 and not having to use -Djdk.gtk.version=3 The problem with requiring one to switch by setting the System-Property is that eg if someone want to use FX in the Eclipse IDE he does not control the Java-Launch Process. Tom On 23.04.16 00:50, David Hill wrote: Kevin, Phil, anyon

early draft for 8087516: [JavaFX] Conditional support for GTK 3 on Linux

2016-04-22 Thread David Hill
later. * shaped windows with GTK3 - need to verify the new region methods * debug code that will be used to check that all of the code paths are tested. * move the disableGrab back into the main code logic. -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet

review: quiet Prism warnings

2016-04-14 Thread David Hill
Kevin, Chien, would you review this quick fix to quiet some warnings ? Tested on OEL, Ubuntu, Mac Windows. https://bugs.openjdk.java.net/browse/JDK-8154256 http://cr.openjdk.java.net/~ddhill/8154256/ -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's

review: Clear potential exception when reporting exceptions from JNI Glass GTK

2016-04-13 Thread David Hill
Kevin, could you review: Clear potential exception when reporting exceptions from JNI Glass GTK A one line diff in: https://bugs.openjdk.java.net/browse/JDK-8154206 -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, b

review request: 8153657 fix DragDrop builds with ARM

2016-04-06 Thread David Hill
Kevin, could you review the diff in: https://bugs.openjdk.java.net/browse/JDK-8153657 thanks! -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review: move DragDrop test app to openjfx

2016-04-05 Thread David Hill
move DragDrop test app to openjfx https://bugs.openjdk.java.net/browse/JDK-8153536 http://cr.openjdk.java.net/~ddhill/8153536/ -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world.

review: convert addExports to new syntax

2016-03-31 Thread David Hill
Kevin, yet another review for you to look at :-) https://bugs.openjdk.java.net/browse/JDK-8153231 http://cr.openjdk.java.net/~ddhill/8153231/ -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey

Re: CFV: New OpenJFX Committer: Murali Billa

2016-03-31 Thread David Hill
/rev/ae75f92d5e53 http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/25db4b2e47a1 http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/51c2129d282c http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/cb8a24f5db2a -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should

Re: review: remove a cygwin dependancy

2016-03-30 Thread David Hill
On 3/30/16, 1:34 PM, David Hill wrote: Kevin, I have been running with this for a couple of weeks now. remove a cygwin dependancy https://bugs.openjdk.java.net/browse/JDK-8151747 http://cr.openjdk.java.net/~ddhill/8151747/ I updated the webrev in place, removing the unneeded

review: Add a command line toggle for worker.debug

2016-03-30 Thread David Hill
Kevin, https://bugs.openjdk.java.net/browse/JDK-8153110 Add a command line toggle for worker.debug There is a diff inline in the bug that works for toggling worker.debug from the gradle command line -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's

review: javafx.swing system test RT30650Test fails in jigsaw mode

2016-03-30 Thread David Hill
" -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Re: review: remove a cygwin dependancy

2016-03-30 Thread David Hill
On 3/30/16, 2:02 PM, Ali Ebrahimi wrote: Hi, line ByteArrayOutputStream out = new ByteArrayOutputStream(); can be removed! Good catch! thanks On Wed, Mar 30, 2016 at 10:04 PM, David Hill <david.h...@oracle.com <mailto:david.h...@oracle.com>> wrote: Kevin, I have

review: Conditionally save policy file in Sandbox tests

2016-03-30 Thread David Hill
Kevin, Conditionally save policy file in Sandbox tests https://bugs.openjdk.java.net/browse/JDK-8153086 http://cr.openjdk.java.net/~ddhill/8153086/ a small change, but very helpful when debugging the Sandbox test apps -- David Hill<david.h...@oracle.com> Java Embedded Development &q

review: remove a cygwin dependancy

2016-03-30 Thread David Hill
Kevin, I have been running with this for a couple of weeks now. remove a cygwin dependancy https://bugs.openjdk.java.net/browse/JDK-8151747 http://cr.openjdk.java.net/~ddhill/8151747/ -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be pla

Re: Move & Copy DnD operation on OS-X and Linux

2016-03-29 Thread David Hill
" + event.getDragboard().getString()); event.consume(); } } -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

jake: enabling systemTests

2016-03-11 Thread David Hill
Kevin, if you could review: Enable systemTests in jake https://bugs.openjdk.java.net/browse/JDK-8147399 http://cr.openjdk.java.net/~ddhill/8147399.2/ -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes sh

review for paper test

2016-03-09 Thread David Hill
Phil, could you review: JobSettingsTest.testPaper fails with small paper sizes Simple fix, make the margins that don't fit 10% of the page dimension https://bugs.openjdk.java.net/browse/JDK-8149756 http://cr.openjdk.java.net/~ddhill/8149756/ -- David Hill<david.h...@oracle.com>

review for enabling systemTest with Jake

2016-03-08 Thread David Hill
Kevin, (finally) https://bugs.openjdk.java.net/browse/JDK-8147399 http://cr.openjdk.java.net/~ddhill/8147399/ -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George

review: enable debugging info in linux shared libs

2016-02-25 Thread David Hill
Hi Kevin, There is a simple diff in the bug. https://bugs.openjdk.java.net/browse/JDK-8150673 -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

please review: refactor test launchers to make common the building of the command

2016-02-16 Thread David Hill
Kevin, could you please review: webrev: http://cr.openjdk.java.net/~ddhill/8147427 bug: https://bugs.openjdk.java.net/browse/JDK-8147427 -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey

Fwd: [JBS] {Commented} (JDK-8149490) Null pointer exception in print logger

2016-02-11 Thread David Hill
in the pulse/repaint/logger code though. below is the conclusion I made after my dig. I would appreciate any comments/thoughts on it added into the bug. Dave David Hill <https://bugs.openjdk.java.net/secure/ViewProfile.jspa?name=ddhill> *commented* on Bug JDK-8149490

review: checkrepo should suggest -a

2016-02-10 Thread David Hill
Kevin, diff is inline in: https://bugs.openjdk.java.net/browse/JDK-8149547 -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review for: 8148489: conditional execution of unstable tests

2016-01-29 Thread David Hill
s expected with -PUNSTABLE_TEST=true -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review: move systemsTest block later in build.gradle

2016-01-15 Thread David Hill
A simple move of a code block... https://bugs.openjdk.java.net/browse/JDK-8147454 http://cr.openjdk.java.net/~ddhill/8147454/ -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world.

  1   2   3   >