Re: [9] Review request for 8134996: GSTREAMER_LITE conditional compilation should be used for all changes in GStreamer

2015-09-07 Thread Kirill Kirichenko
1) Some files have empty diffs: modules/media/src/main/native/gstreamer/3rd_party/glib/glib-2.42.1/build/win32/dirent/dirent.[h|c] modules/media/src/main/native/gstreamer/3rd_party/glib/glib-2.42.1/build/win32/dirent/wdirent.c and some more. 2) what's the purpose of surrounding in

Re: CFV: New OpenJFX Committer: Alexander Matveev

2015-08-28 Thread Kirill Kirichenko
, contributed much of the code that went into the open-source changeset that Kirill Kirichenko pushed for OpenJFX in the JDK 8 release: hg log -r aee256fde55 Counting his contribution to that changeset, Alexander now also has the requisite number of changes in the open-source repo to become

Re: Just pushed the updated GStreamer for JEP 257

2015-08-28 Thread Kirill Kirichenko
Congratulations Alexander, Kevin ant to all involved. This is a great milestone which opens opportunities to use newer gstreamer plugins in Media. On 28.08.2015 4:25, Kevin Rushforth wrote: I just pushed the changeset for JEP 257 [1] [2] on behalf of Alexander Matveev to the openjfx 9-dev

Re: [9] Proposal to deprecate VP6 video and the FLV/FXM file formats

2015-08-27 Thread Kirill Kirichenko
On 27.08.2015 9:29, Dr. Michael Paus wrote: To me this sounds again like a Java/JavaFX specific solution which, to my opinion, is a dead-end road. I think it would be much more important that JavaFX can directly use all system installed codecs. I simply don't understand why it is possible to

[8u60,9] review request: 8088823: Advanced Media Player tab does not respond to Time slider on Windows

2015-06-15 Thread Kirill Kirichenko
Hi Alexander, Kevin. Could you please review the following fix? jbs: https://bugs.openjdk.java.net/browse/JDK-8088823 wevrev: http://cr.openjdk.java.net/~stayer/8088823/webrev.00/ Please review and comment in JBS. This patch partly fixes regression after

[8u60, 9] review request: RT-46186: FX application hangs on exit when media gets stuck

2015-06-10 Thread Kirill Kirichenko
Hi Alexander, Kevin. Could you please review the following fix? jira: https://javafx-jira.kenai.com/browse/RT-46186 wevrev: http://cr.openjdk.java.net/~stayer/RT-46186/webrev.00/ Please review and comment in JIRA if it's still in read-write mode ? K

[8u60] Request for review: RT-39297: FXM player fails to exit

2015-04-17 Thread Kirill Kirichenko
Hi Alexander. Could you please review this fix for flvdemux.c. gst_pad_pull_range in the code above the change may return FLOW_ERROR is the buffer is of some enormous size. We should react to the error. Also some files play well but don't receive EOS or Error because is coming with

Re: [8u60] Request for review: RT-39297: FXM player fails to exit

2015-04-17 Thread Kirill Kirichenko
Correct jira link: https://javafx-jira.kenai.com/browse/RT-38079 On 17.04.2015 15:47, Kirill Kirichenko wrote: Hi Alexander. Could you please review this fix for flvdemux.c. gst_pad_pull_range in the code above the change may return FLOW_ERROR is the buffer is of some enormous size. We should

[8u60] Request for review: RT-37900: MP3 player fails to exit

2015-04-14 Thread Kirill Kirichenko
Hi Alexander. Could you please review this fix for directshowwrapper. When working with fuzzed mp3 files decoder-pSrc-DeliverSample fails but no error is generated and the whole pipeline just silently swithces to prerolling. webrev: cr.openjdk.java.net/~stayer/RT-37900/ jira:

Re: [8u40] RFR: RT-39571: [Mac] AVFoundation player never sends FINISHED state at end of stream

2014-12-04 Thread Kirill Kirichenko
Approved On 04.12.2014 01:44, David DeHaven wrote: Kevin, Kirill, please review the following change for 8u40 JIRA Issue: https://javafx-jira.kenai.com/browse/RT-39571 Webrev: http://cr.openjdk.java.net/~ddehaven/RT-39571/rt.0/ -DrD-

Re: [8u40] RFR: RT-38973: Media produces extraneous debugging when running Ensemble8

2014-11-25 Thread Kirill Kirichenko
Approved On 25.11.14 0:10, David DeHaven wrote: Kevin, Kirill, please review the following fix for 8u40: JIRA: https://javafx-jira.kenai.com/browse/RT-38973 Webrev: http://cr.openjdk.java.net/~ddehaven/RT-38973/rt.0/ I added an additional (annoying) compiler warning fix. -DrD-

hg: openjfx/8u-dev/rt: RT-37914: [Linux] JavaFX Media does not run on Ubuntu 14.04

2014-07-28 Thread kirill . kirichenko
Changeset: df28c1bdf2e1 Author:stayer Date: 2014-07-28 19:25 +0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/df28c1bdf2e1 RT-37914: [Linux] JavaFX Media does not run on Ubuntu 14.04 ! build.gradle !

Re: [8u40] Review request for RT-37914: [Linux] JavaFX Media does not run on Ubuntu 14.04

2014-07-25 Thread Kirill Kirichenko
That's right. My fault. On 24.07.2014 19:38, Kevin Rushforth wrote: Hi Kirill, Did you mean https://javafx-jira.kenai.com/browse/RT-37914 ? -- Kevin Kirill Kirichenko wrote: https://javafx-jira.kenai.com/browse/RT-3791

[8u40] Review request for RT-3791: [Linux] JavaFX Media does not run on Ubuntu 14.04

2014-07-24 Thread Kirill Kirichenko
https://javafx-jira.kenai.com/browse/RT-3791

hg: openjfx/8u-dev/rt: RT-35770: Provide media support for libav version 54 and 55

2014-07-18 Thread kirill . kirichenko
Changeset: 647fd6fc387c Author:stayer Date: 2014-07-18 16:44 +0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/647fd6fc387c RT-35770: Provide media support for libav version 54 and 55 ! modules/media/src/main/native/gstreamer/gstreamer-lite/gstreamer/gst/gstregistry.c !

Re: ComboBox: TestEditor to ListView binding

2014-07-07 Thread Kirill Kirichenko
to return search results for user input. Werner On 04.07.2014 23:48, Kirill Kirichenko wrote: I'm implementing a searchbox. In the textfield of the combobox I'm typing a search string. textProperty of the editor has an onChange listener which forms a list of strings that contain the text

ComboBox: TestEditor to ListView binding

2014-07-04 Thread Kirill Kirichenko
JavaFX ComboBox has binding between TextEdit field and the ListView selection such that edit field gets updated when we change the selected item in the drop down list. Is there a way to break this binding - when we select an item in the list the editor field remains untouched. Where should I

Re: ComboBox: TestEditor to ListView binding

2014-07-04 Thread Kirill Kirichenko
the value is changed from within a changed listener. Steve On 2014-07-04, 3:09 PM, Kirill Kirichenko wrote: JavaFX ComboBox has binding between TextEdit field and the ListView selection such that edit field gets updated when we change the selected item in the drop down list. Is there a way to break

Proportional TableColumn resizing

2014-06-11 Thread Kirill Kirichenko
Hi all. How is it possible to create TableColumns (preferably in fxml) such that they have some proportional width say in percents rather than in pixels with a feature that when we resize the table the columns get resized proportionally ? Default behaviour is that when the window containing a

Re: Adding GStreamer plugins

2014-03-31 Thread Kirill Kirichenko
them there manually it works and builds libffi-lite.lib, but obviously this isn't ideal - if it's not too much hassle could someone point me at the relevant place? Many thanks, Michael On 27 March 2014 08:58, Kirill Kirichenko kirill.kiriche...@oracle.com mailto:kirill.kiriche...@oracle.com wrote

Re: Adding GStreamer plugins

2014-03-26 Thread Kirill Kirichenko
There is another issue with new plugins. We have thoroughly tested with a closed source internal test suite on all platforms every plugin that we already have. If we add something new this may open a way for crashes, security breaches. So if you add something new and want this to be included

Re: Adding GStreamer plugins

2014-03-26 Thread Kirill Kirichenko
Michael, On 26.03.2014 04:11, Michael Berry wrote: Kirill - I think I'll take your suggestion next and start looking at upgrading the existing native components to the latest version of GStreamer before I look at adding any more plugins, that would seem to make sense. Have you any pointers in

Re: Adding GStreamer plugins

2014-03-26 Thread Kirill Kirichenko
I added a wiki link: https://wiki.openjdk.java.net/pages/viewpage.action?pageId=18808963 I welcome free will participants to go over the steps, upgrade GStreamer and eventually create a precise version of the guide. I will provide as much help as I can. K On 26.03.2014 16:43, Kirill

Re: Adding GStreamer plugins

2014-03-25 Thread Kirill Kirichenko
Hi Michael. See my comments inline. On 24.03.2014 04:31, Michael Berry wrote: I'm now a bit further along with this, though struggling to get the matroska plugin to compile (getting a bunch of unresolved external symbol errors for functions it uses in glib - not entirely sure why at the moment,

Re: Adding GStreamer plugins

2014-03-25 Thread Kirill Kirichenko
, Kirill Kirichenko kirill.kiriche...@oracle.com mailto:kirill.kiriche...@oracle.com wrote: Hi Michael. See my comments inline. On 24.03.2014 04:31, Michael Berry wrote: I'm now a bit further along with this, though struggling to get the matroska plugin to compile (getting

Re: [8u] Review request: RT-34950: [Media] JavaFx Player on MAC Crashes Application When Playing Specific Video

2014-03-21 Thread Kirill Kirichenko
Looks good. Approved. On 21.03.2014 17:54, anton nashatyrev wrote: Hello, could you please review the following fix: Webrev: http://cr.openjdk.java.net/~anashaty/RT-34950/webrev.00/ http://cr.openjdk.java.net/%7Eanashaty/RT-34950/webrev.00/ Issue:

Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

2014-03-06 Thread Kirill Kirichenko
I couldn't find media part in Jira. On 06.03.2014 00:44, Stephen F Northover wrote: ... of course I mean the media component, not base. I just change the template to say your component ... Steve On 2014-03-05 3:41 PM, Stephen F Northover wrote: Hi Kirill, Please review the lambdification

Re: Media is now opensource

2013-10-21 Thread Kirill Kirichenko
It will be once we create a 9.0 repo and merge our sandbox with the openjfx repo. Currently we have a working version of Recording/Capture APIs with FXMediaRecorder demo (in apps) implemented on Windows. Linux and Mac implementations are to be done. So expect more to be coming soon. Kirill.

Media is now opensource

2013-10-18 Thread Kirill Kirichenko
Hello OpenJFXers ! We're happy to announce that Media part of JavaFX is now open source. Opensourcing touched all Media component except ON2 FLV demuxer and VP6 decoder. The decoder will remain closed. You're all welcome to contribute. Thanks, K

Re: Media is now opensource

2013-10-18 Thread Kirill Kirichenko
demuxers/decoders e.g. by utilizing stuff from other projects (ffmpeg comes to mind)? On Fri, Oct 18, 2013 at 6:35 PM, Kirill Kirichenko kirill.kiriche...@oracle.com wrote: Hello OpenJFXers ! We're happy to announce that Media part of JavaFX is now open source. Opensourcing touched all Media

JavaFX Media HTTPS support

2013-10-03 Thread Kirill Kirichenko
We've started working on HTTPS support in JavaFX Media component. Due to internal restrictions we won't be able to support HTTPS on MacOs (and possibly on iOS). Do you think it a good idea to add a feature with limited support - just for Linux and Windows ?

Re: JavaFX Media HTTPS support

2013-10-03 Thread Kirill Kirichenko
. On 03.10.2013 12:24, Randahl Isaksen wrote: No. Adding a feature which only works on some desktop OSes ruins the WORA quality of Java. What kinds of restrictions? Resource restrictions or...? Den 03/10/2013 10.19 skrev Kirill Kirichenko kirill.kiriche...@oracle.com mailto:kirill.kiriche...@oracle.com

Re: JavaFX Media HTTPS support

2013-10-03 Thread Kirill Kirichenko
Forgot to add. It's this issue: https://javafx-jira.kenai.com/browse/RT-28420 On 03.10.2013 12:15, Kirill Kirichenko wrote: We've started working on HTTPS support in JavaFX Media component. Due to internal restrictions we won't be able to support HTTPS on MacOs (and possibly on iOS). Do you