Re: CFV: New OpenJFX Committer: Guru Hb

Vote: YES On 4/28/16 11:16 AM, Kevin Rushforth wrote: I hereby nominate Guru Hb [1] to OpenJFX Committer. Guru is a member of JavaFX team at Oracle working on WebKit, who has contributed 10 changesets [5] to OpenJFX, at least 8 of which are significant. Votes are due by May 12, 2016. Only

RFR[9] XS: 8154764: The negative values in the list are not enclosed in parentheses

David and Jonathan, Please review this small change. It seems that the currency semantics for NumberFormat have changed. This explicit format handles accounting style formatting. Thanks, --morris BUG - https://bugs.openjdk.java.net/browse/JDK-8154764 WEBREV - http://cr.openjdk.jav

RFR[9] S: 8154579: Pagination demo:thrown java.lang.IllegalArgumentException on console, when clicking the link of "VIEW SOURCE"

Kevin and Jonathan, Please review these changes to Ensemble8. The View Source feature parses the source for Strings that look like urls, and was getting thrown on using String.format to build a url programmatically. Thanks, --morris BUG - https://bugs.openjdk.java.net/browse/JDK-81

RFR[9] XS: 8067648: We can not see any radio buttons in Node Properties demo

David and Kevin, Please review this comment change to Ensemble8. I could not find any of the PlaygroundProperties for radio buttons in NodePropertiesApp in 8u or 9-dev. Thanks, --morris BUG - https://bugs.openjdk.java.net/browse/JDK-8087648 WEBREV - http://cr.openjdk.java.net/~mor

Re: CFV: New OpenJFX Committer: Murali Billa

Vote: YES On 3/31/16 5:04 PM, Kevin Rushforth wrote: I hereby nominate Murali Billa [1] to OpenJFX Committer. Murali is a member of JavaFX team at Oracle working on WebKit, who has contributed 10 changesets [5] to OpenJFX, at least 8 of which are significant. Votes are due by April 14, 201

[9] Review request: 8152858: Ensemble Timeline regression

Jonathan and Phil, Could you review this one-line change to the Ensemble Timeline app? Thanks, --morris https://bugs.openjdk.java.net/browse/JDK-8152858 http://cr.openjdk.java.net/~morris/JDK-8152858.01/

Re: Learning Prism

As the Quantum author I will echo Johan that looking at the QuantumToolkit.pulse() and QuantumRenderer.submitRenderJob() are good places to start. Ignore the PaintCollector (Pain Collector :-) ) and pay attention to the View Painters. This article has good background. http://fxexperience.com/

[9-dev] RFR(XS): 8088809: MenuItem.setText() is broken (Mac)

Kevin, David and David, Please review this small patch for changing a Mac system menu item, where that item is a top level menu in the [NSApp mainMenu] menu bar. The fix is to look specifically in the main menu for these items, and to use the appropriate mechanism to set the title of that top

[9] RFR-XL: 8091485: Ensemble8: Review each sample

this webrev and will buy lunch for anyone that actually goes through it next time I'm in Santa Clara. Use the follow to test out the changes: ant -Dplatforms.JDK_1.8.home=`/usr/libexec/java_home` ensemble-generate-samples-class run Thanks! --morris meyer WEBREV -

Re: CFV: New OpenJFX Committer: Johan Vos

Vote: YES --morris On 12/21/15 2:45 PM, David Hill wrote: I hereby nominate Johan Vos to OpenJFX Committer. Johan Vos (jvos) has been active in the OpenJFX community, and instrumental in the maturity of Monocle, the owner of the Android and IOS ports and is an OpenJFX Author. A list of Jo

[9] Review request for JDK-8144789: Incorrect assertion fails in the GlassCursor.m

Vadim and Kevin, Please review this fix for the GlassCursor.m assertion failure. Thanks, --morris WEBREV - http://cr.openjdk.java.net/~morris/JDK-8144780.01a BUG - https://bugs.openjdk.java.net/browse/JDK-8144780

Re: Pausing Quantum Renderer

it. The TPE model is more startup, work, then shutdown, and the QuantumToolkit intermediates JavaFX application state with that model. Best regards, --morris meyer On 11/22/15 6:24 AM, Johan Vos wrote: I implemented this in the javafxports clone of the OpenJFX 8u-dev repo, and the

[9] RFR: 8091485: Ensemble8: Review each sample description, playground, appearance, related docs and links

Kevin, Jonathan and Leif, Could you please review my changes for 8091485? The issues that I found are enumerated in the bug description. Thanks much, --morris WEBREV - http://cr.openjdk.java.net/~morris/JDK-8091485.01/ BUG - https://bugs.openjdk.java.net/browse/JDK-8091485

[9-dev] RFR: JDK-8142439: Ensemble8 media player slider issues

Kevin and Vadim, Could you please review my changes for the post-commit cleanup to JDK-8144354? Vadim regarding folding: if (timeSlider.isValueChanging()) { // multiply duration by percentage calculated by slider position if (durati

[9] Review request for 8134366: Modena sample shouldn't access internal JavaFX resources

Kevin and Jonathan, Please review my changes to Modena that allow it to work with the Jake-JavaFX build. Thanks much, --morris meyer BUG - https://bugs.openjdk.java.net/browse/JDK-8134366 WEBREV - http://cr.openjdk.java.net/~morris/JDK-8134366.03

RFR: JDK-8088993: Accepting object is null after a drop

Jonathan and Kevin, Please review this simple fix to DragEvent.java. It uses the existing template for the acceptingObject and has been tested on Mac and Windows. Thanks much, --morris BUG - https://bugs.openjdk.java.net/browse/JDK-8088993 WEBREV - http://cr.openjdk.java.net/~morris

[9] Review request: JDK-8087709: Can set only second menu as system, when trying to set two menus at once

utton("A as system"); barA.useSystemMenuBarProperty().bindBidirectional(aAsSystem.selectedProperty()); ToggleButton bAsSystem = new ToggleButton("B as system"); barB.useSystemMenuBarProperty().bindBidirectional(bAsSystem.selectedProperty()); Thanks for the review.

[8u60] Request for Review: 8094649: [Mac] Intermittent crash after starting Multitouch support

Kevin and David, Please review the following one-line fix to 8094649. This issue was caused by a race condition between start of touch tracking and the closing out the splash screen without removing the touch tracking. It was messaging the invalid ObjC object for the GlassViewDelegate and cr

[9, 8u60] Review request for RT-46170: [Mac] setMaximize stops working

method it could be a possible candidate for inclusion in 8u60. Thanks much, --morris meyer JIRA - https://javafx-jira.kenai.com/browse/RT-46170 WEBREV - http://cr.openjdk.java.net/~morris/RT-46170.01/

[8u60, 9] review request for RT-37411: [Drag and Drop Linux] setDragView still doesn't work on linux

David, Kevin et al, Please review this simple fix for RT-37411. It is pretty low risk vis-a-vis 8u60. Thanks much. --morris meyer JIRA - https://javafx-jira.kenai.com/browse/RT-37411 WEBREV - http://cr.openjdk.java.net/~morris/RT-37411.01/

[9-dev] RT-46093: Different months can get the same info "You were born yesterday"

For those of us who weren't born yesterday, Please review the following issue in Ensemble8. The SimpleDataFormat was using minutes in hours instead of months for the formatted string. Thanks, --morris WEBREV - http://cr.openjdk.java.net/~morris/RT-46093.01/ JIRA - https://javafx-jira.kenai

Re: App hang and pulse logger stops

Hi Pedro, You might want to try setting the flags "quantum.debug", "quantum.pulse" and "quantum.verbose" when launching your application. Prior to that you might want to try to get a stack trace of the hung application using jstack, Visual VM or doing a Ctrl-Break on Windows or Control-\ on

[9-dev] Request for review: RT-40607: Mac resize cursors are wrong

Kevin and David, Please review my changes to GlassCursor.m to fix the lack of proper Mac NW, SW, SE and NE resize cursors. As the look-up for these cursors was a little involved, I opted to use a one-time cache so as not to induce any noticeable visual lag when setting these cursors. Thank

[8u60] request for review: RT-40644: [Mac]: The "Custom colors ..." dialog can not show as expected

Jonathan and Leif, Please review the css changes for Caspian and Modena for the color picker custom color chooser. We need a bit more than 1em for "settings-unit" in CustomColorDialog.java when running on Mac 10.10. Tested on 10.10.4. Thanks much. --morris JIRA - https://javafx-j

[8u-dev] Review request: [Windows] Ensemble 8: Spinner example layout is broken

Jonathan, Kevin and David, Please review these layout changes to the Spinner Ensemble sample to proportionally layout the different Spinners. Thanks much. --morris JIRA - https://javafx-jira.kenai.com/browse/RT-40199 WEBREV - http://cr.openjdk.java.net/~morris/RT-40199.01/

[8u60] Request for review: RT-40385: [Mac] NPE in window close unit tests

David and Kevin, Please review my fix for the recent regression caused by my fix for RT-39813. Both changes crop up in the systemTests and are necessary to adjust for the close sequence timing change introduced in RT-39813. Tested using: gradle -PFULL_TEST=true :systemTests:test Thanks muc

Re: [8u-dev] Review request: RT-38836: JDK crash on Mac 10.10 with very large stage

there is no way to maximize the window on two monitors in multi-monitors configuration? Does this issue affects an applets? Seems that on Windows the clipping on the screen bounds is a default native behavior. 27.03.15 22:39, Morris Meyer wrote: Kevin, David and Chien, Please review this

[8u-dev] Review request: RT-38836: JDK crash on Mac 10.10 with very large stage

Kevin, David and Chien, Please review this patch, which fixes RT-38836 (a critical) and RT-23363 (a medium). It clips the frame to screen size in Glass-Mac in a similar fashion to what happens in Glass-Windows. Thanks much, --morris WEBREV - http://cr.openjdk.java.net/~morris/RT-38

[8u60] Review request: RT-39813: [Mac] JavaFX core dumps on Stage#close

Kevin, Chien and David, Please review my fix for this Mac Stage focus close issue. The Mac OSX internals were forcing a callback event onto a non-focused window, and this preemptively asserts focus before allowing the event through. --morris WEBREV - http://cr.openjdk.java.net/~morri

[8u-dev] Review request: RT-2298: Mac: implement -Xdock:name support in Glass

Kevin, David, Danno and Chien, Please review these changes to add Mac system menu bar naming support to JavaFX based on the JavaRuntimeSupport foundation that the JDK uses for -Xdock:name via JRSAppkitAWT methods. On the Mac the application name needs to be available prior to the runLoop bei

[8u-dev] Review request: RT-39108: [HelloCheckBox] Sample needs additional controls for Accessibility testing

Kevin, David and Jonathan, Could you please review my accessibility additions to HelloCheckBox? Thanks much, --morris WEBREV - http://cr.openjdk.java.net/~morris/RT-39108.01 JIRA - https://javafx-jira.kenai.com/browse/RT-39108

[8u-dev] Review request: RT-39797: Glass sometimes prints warning message on exit

Folks, Could I get a review of these changes? As Glass invokeLater is not thread-safe, and since the JNI native method MacApplication._submitForLaterInvocation() only adds the GlassRunnable when the event thread is still running and Java is still around, I'm dealing with this extraneous Glas

[8u60] Review request: RT-40008: Ensemble8 points to old URL for javadoc

Kevin, Jonathan and David, Could you please review these changes to Ensemble8 to update the FX API docs urls to point to their proper places? Thanks much, --morris WEBREV - http://cr.openjdk.java.net/~morris/RT-40008.01/ JIRA - https://javafx-jira.kenai.com/browse/RT-40008

[8u-dev] Review request: RT-35042: [Ensemble] DatePicker, "Options for locale->Show week numbers" is inconsistent with setting a locale.

Kevin, David and Jonathan, Please review my fix to Ensemble8 -> DatePickerApp that correctly maintains the week numbers setting across locale changes. Thanks much. --morris JIRA - https://javafx-jira.kenai.com/browse/RT-35042 WEBREV - http://cr.openjdk.java.net/~morris/RT-35042.01

[8u-dev] Review request: RT-40032: Nested window open causes repeated shortcut key event after close

David and Kevin, Could you review this change? The change set is per the description in JIRA, and has been tested by Nicholas Myers. Thanks much. --morris JIRA - https://javafx-jira.kenai.com/browse/RT-40032 WEBREV - http://cr.openjdk.java.net/~morris/RT-40032.01

[8u-dev] Review Request: RT-39869: IndexOutOfBoundsException with Native Menus in Mac

Kevin and David, Could you please take a look at this fix to RT-39869? I added some checking to avoid the IOOBE from the native Glass system menus. Thanks, --morris WEBREV - http://cr.openjdk.java.net/~morris/RT-39869.01 JIRA - https://javafx-jira.kenai.com/browse/RT-39869

[8u-dev] Code Review Request: RT-39855: StageStyle.UNIFIED not working on OSX 10.9.5

Kevin, David and Chien, Could you review my fix for this regression? I have tested this on Mac OSX 10.10.3 (pre-release). Thanks much. --morris JIRA - https://javafx-jira.kenai.com/browse/RT-39855 WEBREV - http://cr.openjdk.java.net/~morris/RT-39855

[8u60] Review request for RT-39859: NSInternalInconsistencyException Crash

Kevin and Dave, Please review this fix for RT-39859. The fix was to check to make sure the submenu item is contained within the menu prior to trying to delete it from the menu. Thanks! --morris WEBREV - http://cr.openjdk.java.net/~morris/RT-39859.01a/ JIRA - https://javafx-jira.ken

[8u60] RFR: RT-38694: [Accelerator, Mac] CMD + Z accelerator is not working with French keyboard

Kevin, David and David, Please review the following issue with key translation of foreign keyboards. I have added translation by default, and this code has been tested on US and French keyboards successfully. I also tested with MetaDot to verify that the proper KeyEvents are getting sent up

[8u60] RFR: RT37399: Mac: Command-period generates spurious KeyEvents on Mac OS

Kevin and David, Could you look over my fix for this issue? I thought about putting the special casing in the GlassViewDelegate and changing the return value of sendJavaKeyEvent to return a boolean. I think this way might be a bit cleaner. This issue is caused by the MacOS processing of Co

[8u60] RFR: RT-38860: Mac system menu bar handles some accelerators incorrectly

Kevin and David, Could I get a review for this fix for Mac menu acceleration? The fix is to look for lowercase accelerators before handing them off for special casing. Thanks much, --morris WEBREV - http://cr.openjdk.java.net/~morris/RT-38860.01a JIRA - https://javafx-jira.kenai.co

Re: Building Openjfx on Centos 6.6

What JDK are you using? That looks like an older version of the String class. Gradle 1.8 is recommended. --mm > On Dec 28, 2014, at 7:35 PM, Nick Pratt wrote: > > Does anyone have any tips on getting Openjfx (latest source as of > 2014-12-28 19:00 EST) to build on a Centos 6.6 box? > >

[8u60] Review request for RT-37476

Kevin and Jim, Could you please review the following changes to the Ensemble8 GestureEventApp and MultiTouchImageView. I have tested them on my Mac Pro running 10.10.1 with the Apple Magic Trackpad. Thanks much, --morris WEBREV - http://cr.openjdk.java.net/~morris/RT-37476.01/ JIRA - h

[8u60] Review request for RT-39688: Glass-Mac window close deallocation produces a spurious warning

David and Kevin, Please review this very small change to prevent a spurious warning when de-allocation occurs for a NSWindow instance after the Java VM has shutdown. Thanks much, --morris JIRA - https://javafx-jira.kenai.com/browse/RT-39688 WEBREV - http://cr.openjdk.java.net/~morris

[8u60] Review request for RT-39645: Mac OSX Yosemite StageStyle.UTILITY comes up with wrong window decoration

Kevin and David, Could you please review my changes to Glass-Mac for StageStyle.UTILITY? These have been tested on 10.10. Thanks much, --morris JIRA - https://javafx-jira.kenai.com/browse/RT-39645 WEBREV - http://cr.openjdk.java.net/~morris/RT-39645.01

[8u60] Review request for RT-34840: [3DViewer] FileNotFoundException: Jfx3dViewerApp_session.properties (Read-only file system)

Kevin and Chien, Please review this simple fix for the 3DViewer SessionManager class to take care of read-only file system errors when trying to save the session file. Thanks much, --morris JIRA - https://javafx-jira.kenai.com/browse/RT-34840 WEBREV - http://cr.openjdk.java.net/~mor

[8u60] Review request for RT-34958: [Ensemble] content in some pages are not centered

Folks, Could I get a quick review for this fix-up of the alignment in two Ensemble apps? Thanks much. --morris JIRA - https://javafx-jira.kenai.com/browse/RT-34958 WEBREV - http://cr.openjdk.java.net/~morris/RT-34958.01

Re: Window decoration bug on Yosemite?

Chris, I can verify that this is indeed a bug on Yosemite. --morris On 12/10/14, 5:05 PM, Chris Newland wrote: Hi, I think there might be a bug with the window decoration on OSX Yosemite whenever the StageStyle is set to UTILITY: initStyle(StageStyle.UTILITY); The red close icon app

Re: [8u40] Review request: RT-39344 - [Ensemble8] Need various improvements in Dialog sample

On 12/4/14, 3:18 PM, Elina Kleyman wrote: Hi Morris and Kevin, Please review my change to Ensemble (Dialogs): JIRA: https://javafx-jira.kenai.com/browse/RT-39344 WEBREV: http://cr.openjdk.java.net/~ekleyman/RT-39344/webrev/ Thanks,

[8u40]: Review request for RT-39489: Latest 10.10.2 beta update causes NSTouch exceptions continually

Kevin and David, Please review this patch for the issue added with the 10.10.2 software patch that deals with part of the NSTouch interface changing. --morris JIRA - https://javafx-jira.kenai.com/browse/RT-39489 WEBREV - http://cr.openjdk.java.net/~morris/RT-39489.01/

[8u40] Review request: RT-34668 Mac: Assertion failures when exiting VideoCube test

David, Kevin and Chien, Please review my fix for RT-34668 to remove the spurious extra runnable that sometimes pops up after applications are quit on the Mac. Thanks, --morris BUG - https://javafx-jira.kenai.com/browse/RT-34668 WEBREV - http://cr.openjdk.java.net/~morris/RT-34668.01

[8u40] Review request: RT-38641- Unknown error 0x80DE0001 when trying to drag TreeView node

David and Kevin, Could you please review the following change to remove the extraneous Windows COM debug output from Glass drag-and-drop? Thanks much, --morris JIRA - https://javafx-jira.kenai.com/browse/RT-38641 WEBREV - http://cr.openjdk.java.net/~morris/RT-38641.01/

8u40 Review Request: [EnsembleApp] Add dialogs sample to Ensemble

Folks, Could you please review the new Dialog app for Ensemble8? Thanks much! --mm WEBREV - http://cr.openjdk.java.net/~morris/RT-39121.01 BUG - https://javafx-jira.kenai.com/browse/RT-39121

8u40 Review Request: [EnsembleApp] Icon for Spinner is the same as progress bar

Folks, Please review the new icon. Thanks, --morris WEBREV - http://cr.openjdk.java.net/~morris/RT-39101.01 BUG - https://javafx-jira.kenai.com/browse/RT-39101

[8u40] Review request for RT-23363: Mac: runtimeException when drawing to a huge window

Folks, I've uploaded the initial webrev for this issue for review. Thanks much! --morris meyer JIRA - https://javafx-jira.kenai.com/browse/RT-23363 WEBREV - http://cr.openjdk.java.net/~morris/RT-23363.01

[8u40] Review request for RT-37693: QuadCurve example uses labels that refer to "cubic curve"

Folks, I've uploaded the initial webrev for this issue for review. Thanks much! --morris meyer JIRA - https://javafx-jira.kenai.com/browse/RT-37693 WEBREV - http://cr.openjdk.java.net/~morris/RT-37693.01

[8u40] Review request for RT-37924: Spinner sample app for Ensemble8

Folks, I've uploaded the initial webrev for the Ensemble8 Spinner sample app for review. Thanks much! --morris meyer JIRA - https://javafx-jira.kenai.com/browse/RT-37924 WEBREV - http://cr.openjdk.java.net/~morris/RT-37924.01/

Re: [8u40] Review request for RT-38058: Pagination leak

Here is my latest webrev based on Jonathan's comments in JIRA for RT-38058. --morris WEBREV - http://cr.openjdk.java.net/~morris/RT-38058.02 On 10/6/14, 3:53 PM, Morris Meyer wrote: Here is an open webrev: WEBREV - http://cr.openjdk.java.net/~morris/RT-38058.01 On 10/6/14, 2:

Re: [8u40] Review request for RT-38058: Pagination leak

Here is an open webrev: WEBREV - http://cr.openjdk.java.net/~morris/RT-38058.01 On 10/6/14, 2:50 PM, Morris Meyer wrote: Jonathan, I've pulled out the following patch from this JIRA issue and used jvisualvm to verify that this indeed does solve our pagination leak using the HelloPagin

[8u40] Review request for RT-38058: Pagination leak

Jonathan, I've pulled out the following patch from this JIRA issue and used jvisualvm to verify that this indeed does solve our pagination leak using the HelloPagination app. Could you please give this a review? Thanks. --morris BUG - https://javafx-jira.kenai/browse/RT-38058 WEBRE