RE: RFR: 8214119: Update to 607.1 version of WebKit

2018-12-19 Thread Murali Billa
Looks fine.
+1
 
One minor observation: 

WCFontImpl.java -> Regarding   log.fine(String.format("str='%s' length=%d", 
str, str.length()));, I see earlier code which followed below format for 
‘length’
 
log.fine(String.format("str='%s' (length=%d)", str, str.length()));
 
Thanks,
Murali

-Original Message-
From: Kevin Rushforth 
Sent: Wednesday, December 19, 2018 7:01 PM
To: Arunprasad Rajkumar ; Murali Billa 
; Johan Vos ; Joeri Sykora 

Cc: Praveen Srivastava ; Victor D'yakov 
; openjfx-dev@openjdk.java.net List 

Subject: Re: RFR: 8214119: Update to 607.1 version of WebKit

Looks good to me.

+1

-- Kevin

On 12/18/2018 10:16 AM, Arunprasad Rajkumar wrote:
> Hi Kevin, Murali, Johan, Joeri,
>
> Please review the following patch which merges GTK WebKit 2.22(607.1) into 
> jfx-dev:
>
> http://cr.openjdk.java.net/~arajkumar/8214119/webrev
>
> Above link has a webrev and a changeset file,
>
> 1. rt-non-native-webkit — Contains changes other than 
> "modules/javafx.web/src/main/native", it will be useful _only_ for review, 
> don’t apply the patch from it.
>
> 2. rt.changeset.gz — Actual changeset file in compressed format which 
> contains all the changes from “rt” directory(including WebKit native 
> changes), uncompress before using it(gunzip rt.changeset.gz) and do the 
> following steps.,
>
> $ hg clone http://hg.openjdk.java.net/openjfx/jfx-dev/rt
> $ cd rt
> $ hg import --no-commit rt.changeset #(from rt.changset.gz)
>
> This changeset requires the following versions of toolchains to build 
> properly,
>
> * MSVC- 2017-15.5.5 or higher on Windows
> * GCC 7.3.0 or higher on Linux
> * Xcode 9.4 or higher on MacOS
>
> Thanks,
> Arun



[12] RFR: JDK-8215231: Remove the redundant file readAsText.html

2018-12-11 Thread Murali Billa


Hi Kevin,

Please review the simple fix.

JBS: https://bugs.openjdk.java.net/browse/JDK-8215231
Webrev: http://cr.openjdk.java.net/~mbilla/8215231/webrev.01/

Thanks,
Murali


RE: issue with WebView in 8u202

2018-11-20 Thread Murali Billa
Hi Arun,

Regarding   
Cc: openjfx-dev@openjdk.java.net
Subject: Re: issue with WebView in 8u202

Hi Anton,

Looks like this is mostly related to Content Security Policy(CSP)[1] which have 
got strengthened after recent WebKit upgrades.

I have reduced the given html further(PSB) & I could reproduce the problem with 
the following html snippet,


https://betanews.com/wp-content/uploads/2016/04/penguingun-900x900.jpg' 
alt=‘from http:’/> 

In the above html snippet, CSP of img tag is set to load from all except file 
scheme. It would load img from http: but not from file. If you also want to 
load from file: scheme, then you must explicitly set that in the CSP header. 
Something like below,


https://betanews.com/wp-content/uploads/2016/04/penguingun-900x900.jpg' 
alt=‘from http:’/> 

[1] https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP

Thanks,
Arun

> On 20-Nov-2018, at 10:04 AM, Anton Tarasov  
> wrote:
> 
> Thanks for the catch, Kevin! Seems very likely. Is it the thing configured at 
> compile-time?
> 
> Regards,
> Anton.
> 
> On 11/20/2018 12:51 AM, Kevin Rushforth wrote:
>> I can reproduce it and it seems related to Cross-Site-Scripting (XSS) 
>> protections, which you have enabled in your HTML header with:
>> 
>> 
>> 
>> If I remove the 'http-equiv="Content-Security-Policy"' from the meta-data 
>> then it displays just fine.
>> 
>> Perhaps Arun or Murali could comment on whether this is a bug or not. It 
>> seems just as likely to me that it is a feature that didn't used to be 
>> enabled and now is.
>> 
>> -- Kevin
>> 
>> 
>> On 11/19/2018 1:44 PM, Anton Tarasov wrote:
>>> Hi Kevin,
>>> 
>>> On 11/20/2018 12:21 AM, Kevin Rushforth wrote:
 Hi Anton,
 
 We'll take a look and see if we can reproduce it. Am I correct in 
 understanding that the problem only happens with loadContent, which works 
 on 8u152 and fails on 8u202-ea? And that load from a file works fine on 
 both 8u152 and 8u202-ea?
 
>>> Yes, that's right. I've also checked that it's broken in the latest jfx12 
>>> as well. I'd appreciate your help in resolving this.
>>> 
>>> Thanks,
>>> Anton.
>>> 
 
 -- Kevin
 
 
 On 11/19/2018 12:17 PM, Anton Tarasov wrote:
> Hello, JFX team!
> 
> We (at JetBrains) faced an issue with WebView after we've moved to an JFX 
> update in JDK8u202. The issue is that WebView stopped loading images 
> referenced by an absolute URL under some circumstances.
> 
> Below is a real html content, produced by IDEA markdown viewer. It has 
> lots of style pre-loads and a sample image that it should eventually 
> display. The html is loaded view WebEngine.loadContent(..) but a 
> placeholder text is only displayed - that's the problem that can be 
> reproduce with JDK8u202. However it worked with JDK8u152.
> 
> The style references will obviously fail for you, but if you put this 
> html into a file and will load it via 
> WebEngine.load(file:///path/to/file), the image will be shown with no 
> problem (in 8u202 as well).
> 
>  content="default-src 'none'; script-src 
> http://localhost:63344/api/markdown-preview/scripts/processLinks.j
> s?_ijt=ujioejund46k8cmdcsuggbpnf3 
> http://localhost:63344/api/markdown-preview/scripts/scrollToElemen
> t.js?_ijt=ujioejund46k8cmdcsuggbpnf3; style-src https: 
> http://localhost:63344/api/markdown-preview/styles/default.css?_ij
> t=ujioejund46k8cmdcsuggbpnf3 
> http://localhost:63344/api/markdown-preview/styles/darcula.css?_ij
> t=ujioejund46k8cmdcsuggbpnf3 
> http://localhost:63344/api/markdown-preview/styles/inline.css?_ijt
> =ujioejund46k8cmdcsuggbpnf3; img-src *; connect-src 'none'; 
> font-src *; object-src 'none'; media-src 'none'; child-src 
> 'none';"/> href="http://localhost:63344/api/markdown-preview/styles/default.c
> ss?_ijt=ujioejund46k8cmdcsuggbpnf3" />
> 
>  src="http://localhost:63344/api/markdown-preview/scripts/processLi
> nks.js?_ijt=ujioejund46k8cmdcsuggbpnf3">
>  src="http://localhost:63344/api/markdown-preview/scripts/scrollToE
> lement.js?_ijt=ujioejund46k8cmdcsuggbpnf3"> md-src-pos="0..89"> src="file:///C:/Users/tav/IdeaProjects/DummyProject/src/kitten.jpg
> " alt="Kitten" title="A cute kitten" md-src-pos="0..88" 
> />
> 
> Then, if you remove all the style loading and leave only the 
> image, the image will be shown in either way: load(url) or 
> loadContent (in 8u202)
> 
>  md-src-pos="0..88"> src="file:///C:/Users/tav/IdeaProjects/DummyProject/src/kitten.jpg
> " alt="Kitten" title="A cute kitten" md-src-pos="0..88" 
> />
> 
> Sorry for not submitting the code, I hope you will easily put it into a 

[8u] RFR: JDK-8212014: JavaScriptBridgeTest::testBridgeExplicitOverloading test fails when run with newer JDK 8u

2018-11-02 Thread Murali Billa
Hi Kevin, Arun, 

Please review the patch for the following bug:

JBS: https://bugs.openjdk.java.net/browse/JDK-8212014
Webrev: http://cr.openjdk.java.net/~mbilla/8212014/webrev.00/

Thanks,
Murali


[12] RFR: JDK-8213139: TooltipFXTest. testTooltipLeak failing intermittently

2018-11-02 Thread Murali Billa
Hi Kevin, Arun, 

Please review the patch for the following bug:

JBS: https://bugs.openjdk.java.net/browse/JDK-8213139
Webrev: http://cr.openjdk.java.net/~mbilla/8213139/webrev.00/


Thanks,
Murali


[RFR] [12] JDK-8207772: File API and FileReader should be supported in WebView

2018-10-30 Thread Murali Billa
 

Hi Kevin, Johan, Arun,


Please review the below enhancement for File Reader support in JavaFX WebView.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8207772

 

Github PR: https://github.com/javafxports/openjdk-jfx/pull/250

 


Thanks,

Murali


RE: [12,8u] RFR: JDK-8212158: FX: Update copyright year in docs, readme files to 2019

2018-10-25 Thread Murali Billa
Hi Kevin,

+1  for 12 and 8u.

Giving +1 in mail since currently not able to login to JBS.

Thanks
Murali

-Original Message-
From: Kevin Rushforth 
Sent: Thursday, October 25, 2018 5:44 PM
To: Murali Billa ; openjfx-dev@openjdk.java.net
Subject: [12,8u] RFR: JDK-8212158: FX: Update copyright year in docs, readme 
files to 2019

Hi Murali,

Please review the following to update the copyright year for the API docs to 
2019:

JBS: https://bugs.openjdk.java.net/browse/JDK-8212158
12 webrev: http://cr.openjdk.java.net/~kcr/8212158/webrev/
8u webrev: http://cr.openjdk.java.net/~kcr/8212158/8u/webrev/

I'm sending the 8u backport for review at the same time to expedite getting 
this into the 8u-dev repo ahead of the RDP2 freeze for 8u202.

-- Kevin



RE: CFV: New OpenJFX Committer: Prem Balakrishnan

2018-07-11 Thread Murali Billa
Vote: YES

> On 11-Jul-2018, at 5:11 AM, Kevin Rushforth  
> wrote:
> 
> I hereby nominate Prem Balakrishnan [1] to OpenJFX Committer.
> 
> Prem is a member of JavaFX team at Oracle, who has contributed 10 changesets 
> [2] to OpenJFX.
> 
> Votes are due by July 24, 2018.
> 
> Only current OpenJFX Committers [4] are eligible to vote on this nomination. 
> Votes must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [5]. Nomination to a project 
> Committer is described in [6].
> 
> Thanks.
> 
> -- Kevin
> 
> [1] http://openjdk.java.net/census#pkbalakr
> 
> [2] 
> http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?revcount=20=author%28pkbalakr%29
> 
> [3] http://openjdk.java.net/census#openjfx
> 
> [4] http://openjdk.java.net/bylaws#lazy-consensus
> 
> [5] http://openjdk.java.net/projects#project-committer
> 



[11] Review request for 8203698: JavaFX WebView crashes when visiting certain web sites

2018-05-25 Thread Murali Billa
 

Hi Kevin, Arun


Please review the below fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8203698

 

webrev:  http://cr.openjdk.java.net/~mbilla/8203698/webrev.00/


Thanks,

Murali


RE: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-02 Thread Murali Billa
Hi Nir,

 

1)  Regarding “verbose” flag usage:  

· Currently verbose flag is used to show log Levels 
(FINER/FINE/INFO/WARNING) in WCMediaPlayer & WCMediaPlayerImpl.  I feel it is 
not desirable to remove this flag as all these logs will start appearing now by 
default.

· We can try 2 options: 

a)   1st Option: We can change all INFO log messages to FINE  under verbose 
flag (by leaving all log messages that use Level other than INFO unchanged) and 
verbose flag can be removed.

b)  If 1st option results in too much noise for WARNING log messages, then 
we can keep the verbose flag and introduce a System Property (for ex: 
javafx.web.verbose) to enable the flag. I won’t suggest reading level value 
from log/config file.

 

2)  Regarding  “com.sun.javafx.webkit.drt.DumpRenderTree”,  I need to check 
few more things (since we use “addHandler” in drt) and will get back to you.

 

Please let me know, if you have any queries for 1.

Thanks,

Murali

From: Nir Lisker <nlis...@gmail.com> 
Sent: Saturday, April 28, 2018 1:06 AM
To: Murali Billa <murali.bi...@oracle.com>
Cc: openjfx-dev@openjdk.java.net Mailing <openjfx-dev@openjdk.java.net>
Subject: JDK-8195974: Replace use of java.util.logging in javafx with System 
logger

 

Hi Murali,

 

Can you have a look at https://bugs.openjdk.java.net/browse/JDK-8195974 please?

 

There are some usages of j.u.l in the web module I'd like your opinion on. I'm 
not familiar with the intent of these pieces of code and would like to know 
what the options are for advancing with this issue on that front.

 

Thanks,

Nir


[11] Review request for 8200418: webPage.executeCommand("removeFormat", null) removes the style of the body element

2018-04-17 Thread Murali Billa
 

Hi Kevin, Arun


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8200418

 

webrev:  http://cr.openjdk.java.net/~mbilla/8200418/webrev.00/


Thanks,

Murali


RE: WebView: in jfx9 the ENTER key from keyboard does not add new lines on textareas (but works correctly on jfx8)

2018-04-15 Thread Murali Billa
Hi Mirco,

 

Yes..Issue is present in JDK 10 (verified  with  JDK 10+46).

 

I tested with JDK 11 and issue is not reproducible.

 

Thanks,

Murali

 

From: Mirco <mirch...@gmail.com> 
Sent: Sunday, April 15, 2018 8:41 PM
To: Murali Billa <murali.bi...@oracle.com>
Cc: openjfx-dev@openjdk.java.net
Subject: Re: WebView: in jfx9 the ENTER key from keyboard does not add new 
lines on textareas (but works correctly on jfx8)

 

Just as additional information, I noticed that  currently in jfx10 the problem 
is still present.

 

Regards,

 

Mirco

 

On Sun, Apr 15, 2018 at 4:58 PM, Mirco mailto:mirch...@gmail.com"mirch...@gmail.com> wrote:

Hi Murali,

thank you for the quick answer. 

Glad to hear the problem does not show up anymore with the latest build. 

I will check out again when in the future the official openjfx 11 binaries will 
be released.

 

Thanks,

Mirco

 

On Sat, Apr 14, 2018 at 7:22 PM, Murali Billa mailto:murali.bi...@oracle.com"murali.bi...@oracle.com> wrote:

Hi Mirco,

I tried the below sample code with JDK9+180 in Ubuntu and able to reproduce 
this issue.

I tried with latest JDK build in Ubuntu (and in windows too) and not able to 
reproduce this issue (i can see new lines are being added upon entering ENTER 
key)

I suggest you can verify  with latest JDK build.

Thanks,
Murali


-Original Message-
From: Mirco mailto:mirch...@gmail.com"mirch...@gmail.com> 
Sent: Saturday, April 14, 2018 10:16 PM
To: HYPERLINK "mailto:openjfx-dev@openjdk.java.net"openjfx-dev@openjdk.java.net
Subject: WebView: in jfx9 the ENTER key from keyboard does not add new lines on 
textareas (but works correctly on jfx8)

Hi,
please forgive me if this is not the appropriate place for such kind of reports.
I've encountered what seems a regression from jfx8, at least on "Ubuntu 16.04".
As stated in the mail object the ENTER key produces no effects inside any 
editable components of a webpage.
Note: the CTRL-M works instead.

What follows is a very simple example to illustrate the issue:

import javafx.application.Application;
import javafx.scene.Node;
import javafx.scene.Scene;
import javafx.scene.web.WebEngine;
import javafx.scene.web.WebView;
import javafx.stage.Stage;
import javafx.scene.layout.VBox;
import javafx.scene.input.KeyEvent;

public class WebViewSample extends Application {
    private Scene scene;

    @Override public void start(Stage stage) {
        stage.setTitle("Web View");
WebView editor = new WebView();
WebEngine engine = editor.getEngine();
        engine.setJavaScriptEnabled(true);
engine.loadContent("Type content 
here..."); editor.setContextMenuEnabled(false);
editor.addEventFilter(KeyEvent.KEY_PRESSED, (KeyEvent evt) -> { 
System.out.println(evt.getCode()); });
        VBox root = new VBox();
root.getChildren().add(editor);
        scene = new Scene(root,750,500);
        stage.setScene(scene);
        stage.show();
    }

    public static void main(String[] args){
        launch(WebViewSample.class, args);
    }
}

As you can see the ENTER event is intercepted and printed out by the filter but 
no newline is added.
This problem should not be confused with an old bug related to the JFXPanel 
(here no swing is involved).
I have not tried with the latest builds of openjfx so just in case you are 
aware of that and/or the problem is already resolved please ignore this email.

Kind regards,

Mirco

 

 


RE: WebView: in jfx9 the ENTER key from keyboard does not add new lines on textareas (but works correctly on jfx8)

2018-04-14 Thread Murali Billa
Hi Mirco,

I tried the below sample code with JDK9+180 in Ubuntu and able to reproduce 
this issue.

I tried with latest JDK build in Ubuntu (and in windows too) and not able to 
reproduce this issue (i can see new lines are being added upon entering ENTER 
key)

I suggest you can verify  with latest JDK build.

Thanks,
Murali

-Original Message-
From: Mirco  
Sent: Saturday, April 14, 2018 10:16 PM
To: openjfx-dev@openjdk.java.net
Subject: WebView: in jfx9 the ENTER key from keyboard does not add new lines on 
textareas (but works correctly on jfx8)

Hi,
please forgive me if this is not the appropriate place for such kind of reports.
I've encountered what seems a regression from jfx8, at least on "Ubuntu 16.04".
As stated in the mail object the ENTER key produces no effects inside any 
editable components of a webpage.
Note: the CTRL-M works instead.

What follows is a very simple example to illustrate the issue:

import javafx.application.Application;
import javafx.scene.Node;
import javafx.scene.Scene;
import javafx.scene.web.WebEngine;
import javafx.scene.web.WebView;
import javafx.stage.Stage;
import javafx.scene.layout.VBox;
import javafx.scene.input.KeyEvent;

public class WebViewSample extends Application {
private Scene scene;

@Override public void start(Stage stage) {
stage.setTitle("Web View");
WebView editor = new WebView();
WebEngine engine = editor.getEngine();
engine.setJavaScriptEnabled(true);
engine.loadContent("Type content 
here..."); editor.setContextMenuEnabled(false);
editor.addEventFilter(KeyEvent.KEY_PRESSED, (KeyEvent evt) -> { 
System.out.println(evt.getCode()); });
VBox root = new VBox();
root.getChildren().add(editor);
scene = new Scene(root,750,500);
stage.setScene(scene);
stage.show();
}

public static void main(String[] args){
launch(WebViewSample.class, args);
}
}

As you can see the ENTER event is intercepted and printed out by the filter but 
no newline is added.
This problem should not be confused with an old bug related to the JFXPanel 
(here no swing is involved).
I have not tried with the latest builds of openjfx so just in case you are 
aware of that and/or the problem is already resolved please ignore this email.

Kind regards,

Mirco


[11] Review request for 8201176: gradle :web:test should print a warning if COMPILE_WEBKIT is false

2018-04-06 Thread Murali Billa
Hi Kevin,


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8201176

 

webrev:  http://cr.openjdk.java.net/~mbilla/8201176/webrev.00/


Thanks,

Murali


RE: gradle :web:test fails

2018-04-05 Thread Murali Billa
Hi Lisker,

+one more point:

I think you are not compiling webkit . The command "gradle :web:test"  picks 
the webkit dll from JDK (which can have older versions like 10 / 9) .

You can compile webkit  with command " gradle -PCOMPILE_WEBKIT=true  :web:test" 
and in this case webkit dll will be picked up from your source code repo (not 
from JDK).

Thanks,
Murali

-Original Message-
From: Murali Billa 
Sent: Thursday, April 05, 2018 10:19 AM
To: Nir Lisker <nlis...@gmail.com>; openjfx-dev@openjdk.java.net Mailing 
<openjfx-dev@openjdk.java.net>
Subject: RE: gradle :web:test fails

Hi Lisker,

Can you print  the value of  useragentString ? Looks like you are using 
fxversion as 11 (you can print this value from  
System.getProperty("javafx.runtime.version");) but the useragentstring does not 
contain 11.

final WebView webView = new WebView();
final WebEngine webEngine = webView.getEngine(); 
System.out.println(webEngine.getUserAgent()); 


Thanks,
Murali
-Original Message-
From: Nir Lisker <nlis...@gmail.com>
Sent: Thursday, April 05, 2018 7:03 AM
To: openjfx-dev@openjdk.java.net Mailing <openjfx-dev@openjdk.java.net>
Subject: gradle :web:test fails

I'm running :web:test in revision 10889 and getting the following failing
test:

test.javafx.scene.web.MiscellaneousTest > testUserAgentString FAILED
java.lang.AssertionError: UserAgentString does not contain JavaFX/11
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.assertTrue(Assert.java:43)
at
test.javafx.scene.web.MiscellaneousTest.lambda$testUserAgentString$12(MiscellaneousTest.java:441)

379 tests completed, 1 failed, 12 skipped :web:test FAILED

Is this known?

- Nir


RE: gradle :web:test fails

2018-04-04 Thread Murali Billa
Hi Lisker,

Can you print  the value of  useragentString ? Looks like you are using 
fxversion as 11 (you can print this value from  
System.getProperty("javafx.runtime.version");) but the useragentstring does not 
contain 11.

final WebView webView = new WebView();
final WebEngine webEngine = webView.getEngine();
System.out.println(webEngine.getUserAgent()); 


Thanks,
Murali
-Original Message-
From: Nir Lisker  
Sent: Thursday, April 05, 2018 7:03 AM
To: openjfx-dev@openjdk.java.net Mailing 
Subject: gradle :web:test fails

I'm running :web:test in revision 10889 and getting the following failing
test:

test.javafx.scene.web.MiscellaneousTest > testUserAgentString FAILED
java.lang.AssertionError: UserAgentString does not contain JavaFX/11
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.assertTrue(Assert.java:43)
at
test.javafx.scene.web.MiscellaneousTest.lambda$testUserAgentString$12(MiscellaneousTest.java:441)

379 tests completed, 1 failed, 12 skipped :web:test FAILED

Is this known?

- Nir


RE: CFV: New OpenJFX Committer: Rajath Kamath

2018-03-29 Thread Murali Billa
VOTE: YES


> On 29-Mar-2018, at 10:12 PM, Kevin Rushforth  
> wrote:
> 
> I hereby nominate Rajath Kamath [1] to OpenJFX Committer.
> 
> Rajath is a member of JavaFX team at Oracle, who has contributed 17 
> changesets [2][3] to OpenJFX.
> 
> Votes are due by April 12, 2018.
> 
> Only current OpenJFX Committers [4] are eligible to vote on this nomination. 
> Votes must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [5]. Nomination to a project 
> Committer is described in [6].
> 
> By way of background, an earlier nomination failed [7]. Since then, Rajath 
> has contributed 2 more test fixes and 1 more product fix.
> 
> Thanks.
> 
> -- Kevin
> 
> [1] http://openjdk.java.net/census#rkamath
> 
> [2] 
> http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?revcount=20=auth
> or%28rkamath%29 [3] 
> http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?revcount=20=raja
> th.kamath
> 
> [4] http://openjdk.java.net/census#openjfx
> 
> [5] http://openjdk.java.net/bylaws#lazy-consensus
> 
> [6] http://openjdk.java.net/projects#project-committer
> 
> [7] 
> http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-February/02149
> 9.html
> 



[11] Review request for 8198609: [TestBug] Some of the system tests need a message about exceptions being expected

2018-03-01 Thread Murali Billa
 

Hi Kevin,


Please review the below simple fix.

JIRA:  https://bugs.openjdk.java.net/browse/JDK-8198609

 

webrev: http://cr.openjdk.java.net/~mbilla/8198609/webrev.00/


Thanks,

Murali


[11] Review request for 8198610: [TestBug] test.javafx.scene.web.UserDataDirectoryTest logs on stderr

2018-02-26 Thread Murali Billa
 

Hi Kevin,


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8198610

 

webrev: http://cr.openjdk.java.net/~mbilla/8198610/webrev.00/


Thanks,

Murali


[11] Review request for 8198587: Increase test timeout values to make test suite more stable

2018-02-26 Thread Murali Billa
 

Hi Kevin,


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8198587

 

webrev: http://cr.openjdk.java.net/~mbilla/8198587/webrev.00/


Thanks,

Murali


[11] Review request for 8193207: [TESTBUG] Unit test case to check user agent string

2018-02-23 Thread Murali Billa
 

Hi Kevin,


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8193207

 

webrev: http://cr.openjdk.java.net/~mbilla/8193207/webrev.00/


Thanks,

Murali


Re: CFV: New OpenJFX Committer: Rajath Kamath

2018-02-12 Thread Murali Billa

Vote: YES


Kevin Rushforth wrote:
> I hereby nominate Rajath Kamath [1] to OpenJFX Committer.
>
> Rajath is a member of JavaFX team at Oracle, who has contributed 11 
> changesets [2][3] to OpenJFX.
>
> Votes are due by February 26, 2018.
>
> Only current OpenJFX Committers [4] are eligible to vote on this 
> nomination. Votes must be cast in the open by replying to this mailing 
> list.
>
> For Lazy Consensus voting instructions, see [5]. Nomination to a 
> project Committer is described in [6].
>
> Thanks.
>
> -- Kevin
>
> [1] http://openjdk.java.net/census#rkamath
>
> [2]
> http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?revcount=20=auth
> or%28rkamath%29
>
> [3]
> http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?revcount=20=raja
> th.kamath
>
>
> [4] http://openjdk.java.net/census#openjfx
>
> [5] http://openjdk.java.net/bylaws#lazy-consensus
>
> [6] http://openjdk.java.net/projects#project-committer
>


[11] Review request for 8196592: Mark unstable tests so they will be skipped until fixed

2018-02-06 Thread Murali Billa
 

Hi Kevin,


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8196592

 

webrev: http://cr.openjdk.java.net/~mbilla/8196592/webrev.00/


Thanks,

Murali


[11] Review request for 8196605: Robot tests fail on Windows platforms if terminal windows are in the way

2018-02-02 Thread Murali Billa
 

Hi Kevin,


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8196605

 

 

webrev: http://cr.openjdk.java.net/~mbilla/8196605/webrev.00/


Thanks,

Murali


[11] Review request for 8195804: Remove unused qualified export of sun.net.www from java.base to javafx.web

2018-01-29 Thread Murali Billa
 

Hi Kevin, Arun


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8195804

 

Webrev: http://cr.openjdk.java.net/~mbilla/8195804/webrev.00/


Thanks,

Murali


[11] Review request for 8193368: [OS X] Remove redundant files

2018-01-10 Thread Murali Billa
 

Hi,


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8193368

 

Webrev: http://cr.openjdk.java.net/~mbilla/8193368/webrev.00/

 


Thanks,

Murali


[11] Review request for 8193590: Memory leak when using WebView with Tooltip

2018-01-09 Thread Murali Billa
 

Hi,


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8193590

 

Webrev: http://cr.openjdk.java.net/~mbilla/8193590/webrev.01/

 


Thanks,

Murali


[11] Review request for 8193131: Need to remove SharedBuffer unit Test cases

2018-01-04 Thread Murali Billa
 

Hi,


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8193131

 

Webrev: http://cr.openjdk.java.net/~mbilla/8193131/webrev.00/

 


Thanks,

Murali


[8u] Review request for 8193450: Port changes to java and native files from JDK-8192806 to FX 8u

2017-12-13 Thread Murali Billa
Hi Kevin,

Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8193450


Webrev: http://cr.openjdk.java.net/~mbilla/8193450/webrev.00/

Thanks,
Murali


[10] Review request for 8193458: Incorrect cmake platform string for 32-bit Linux

2017-12-13 Thread Murali Billa
 

 

Hi Kevin,


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8193458

 

Webrev: http://cr.openjdk.java.net/~mbilla/8193458/webrev.00/


Thanks,

Murali


RE: New OpenJFX Committer: Laurent Bourgès

2017-12-13 Thread Murali Billa

Vote: yes

Thanks,
Murali

On 12/12/17, 1:25 PM, "openjfx-dev on behalf of Kevin Rushforth" 
 
wrote:

I hereby nominate Laurent Bourgès [1] to OpenJFX Committer.

Laurent is the author of the Marlin rasterizer, which is used as the 
default rasterizer for both Java2D and JavaFX. He has contributed 10 
changesets [2] to OpenJFX.

Votes are due by December 25, 2017.
(Given the Christmas holiday in the US, it will be at least one week 
after that before I publish the results).

Only current OpenJFX Committers [3] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing list.

For Lazy Consensus voting instructions, see [4]. Nomination to a project 
Committer is described in [5].

Thanks.

-- Kevin

[1] http://openjdk.java.net/census#lbourges

[2] 
http://hg.openjdk.java.net/openjfx/jfx-dev/rt/log?rev=author%28lbourges%29

[3] http://openjdk.java.net/census#openjfx

[4] http://openjdk.java.net/bylaws#lazy-consensus

[5] http://openjdk.java.net/projects#project-committer






[8u-Backport] Review request: 8187483: Update to 605.1 version of WebKit

2017-12-11 Thread Murali Billa

Hi  All,

Please review the  following patch to merge the GTK WebKit 2.18 into FX 8u :

http://cr.openjdk.java.net/~mbilla/8187483/8u-dev-bp/webrev.01/

Above link has one webrev and one changeset file:

1. rt-non-webkit — Contains changes other than "modules/web/src/main/native", 
it will be useful only for review.

2. rt.changeset.gz — Actual changeset file in compressed format which contains 
all the changes from “rt” directory, uncompress before using it(gunzip 
rt.changeset.gz) and do the following steps.

$ cd rt 
$ hg import --no-commit rt.changeset  #(from rt.changset.gz)

Thanks,
Murali


[10] Review request: 8187483: Update to 605.1 version of WebKit

2017-12-07 Thread Murali Billa

Hi  All,

Following webrev  contains changes to upgrade to newer WebKit which is based on 
GTK WebKit 2.18 [1].

http://cr.openjdk.java.net/~mbilla/8187483/webrev.01/


Above link has one webrev  and one patchset file.

1. rt-non-webkit — Contains changes other than 
"modules/javafx.web/src/main/native", it will be useful only for review.

2. rt.changeset.gz — Actual changeset file in compressed format which contains 
all the changes from “rt” directory, uncompress before using it(gunzip 
rt.changeset.gz) and do the following steps.

$ cd rt 
$ hg import --no-commit rt.changeset#(from rt.changset.gz)

Please review and let me know the feedback.

[1]  https://trac.webkit.org/wiki/WebKitGTK/2.18.x

Thanks,
Murali


[10] Review request for 8191621: Windows build fails if VS150COMNTOOLS is set

2017-11-28 Thread Murali Billa
 

Hi Kevin,


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8191621

 

Webrev: http://cr.openjdk.java.net/~mbilla/8191621/webrev.00/

 


Thanks,

Murali


[10] Review request for 8190349: Tooltip based on graphic contented only show less than 1 out of 10 times

2017-11-05 Thread Murali Billa
 

Hi Kevin, Arun,


Please review the below fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8190349

 

Webrev: http://cr.openjdk.java.net/~mbilla/8190349/webrev.00/

 


Thanks,

Murali


[10] Review request for 8189420: Crash in :web:test in debug build

2017-10-17 Thread Murali Billa
 

Hi Kevin, Arun


Please review the below fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8189420

 

Webrev: http://cr.openjdk.java.net/~mbilla/8189420/webrev.00/

 


Thanks,

Murali


[10] Review request for 8189350: Crash due to ASSERT(url == m_string) fail while loading URL

2017-10-16 Thread Murali Billa
 

Hi Kevin, Arun


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8189350

 

Webrev: http://cr.openjdk.java.net/~mbilla/8189350/webrev.00/

 


Thanks,

Murali


[10] Review request for 8187366: Remove hardcoded MSVC Version in win.gradle

2017-09-28 Thread Murali Billa
 

Hi Kevin, Arun


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8187366 

 

Webrev: http://cr.openjdk.java.net/~mbilla/8187366/webrev.01/

 

 


Thanks,

Murali


[10] Review request for 8185970: Possible crash due to use-after-free

2017-08-08 Thread Murali Billa
 

Hi,


Please review the below fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8185970 

 

Webrev: http://cr.openjdk.java.net/~mbilla/8185970/webrev.00/

 


Thanks,

Murali


[10] Review request for 8182977: NullPointerException with HTMLEditor when changing the scene graph

2017-08-07 Thread Murali Billa
 

Hi,


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8182977

 

Webrev: http://cr.openjdk.java.net/~mbilla/8182977/webrev.00/

 


Thanks,

Murali


[10] Review request for 8183928: [Linux] Remove Warnings [-Wunused-parameter]

2017-08-07 Thread Murali Billa
 

Hi,


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8183928

 

Webrev: http://cr.openjdk.java.net/~mbilla/8183928/webrev.00/

 


Thanks,

Murali


[10] Review request for 8184453: [Win] DRT crashes for imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html

2017-07-30 Thread Murali Billa
 

Hi,


Please review the below fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8184453


Webrev: http://cr.openjdk.java.net/~mbilla/8184453/webrev.00/


Thanks,

Murali


[10] Review request for 8185138: Build hangs and fills up disk on Windows with VS 2013 or 2010

2017-07-25 Thread Murali Billa
 

Hi Kevin, Arun,


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8185138


Webrev: http://cr.openjdk.java.net/~mbilla/8185138/webrev.00/

 


Thanks,

Murali


RE: CFV: New OpenJFX Committer: Ajit Ghaisas

2017-05-26 Thread Murali Billa

Vote: YES

Kevin Rushforth wrote:
> I hereby nominate Ajit Ghaisas [1] to OpenJFX Committer.
>
> Ajit is a member of JavaFX team at Oracle, who has contributed 10 
> changesets to OpenJFX. A list of these changesets is available by the 
> following link:
>
> http://hg.openjdk.java.net/openjfx/10-dev/rt/log?revcount=40=autho
> r%28aghaisas%29
>
>
> Votes are due by June 9, 2017.
>
> Only current OpenJFX Committers [2] are eligible to vote on this 
> nomination. Votes must be cast in the open by replying to this mailing 
> list.
>
> For Lazy Consensus voting instructions, see [3]. Nomination to a 
> project Committer is described in [4].
>
> Thanks.
>
> -- Kevin
>
> [1] http://openjdk.java.net/census#aghaisas
>
> [2] http://openjdk.java.net/census#openjfx
>
> [3] http://openjdk.java.net/bylaws#lazy-consensus
>
> [4] http://openjdk.java.net/projects#project-committer
>
>


[10] Review request for 8176729: com.sun.webkit.dom.NodeImpl#SelfDisposer is not called

2017-04-17 Thread Murali Billa
 

 

Hi Kevin, Arun, Guru


Please review the fix for ­ JDK-8176729.


JIRA: https://bugs.openjdk.java.net/browse/JDK-8176729

 

Webrev: http://cr.openjdk.java.net/~mbilla/8176729/webrev.00/

 


Thanks,

Murali


[9] Review request for 8174866: User Agent String for JavaFX is not correct

2017-02-13 Thread Murali Billa
 

Hi Kevin, Arun, Guru


Please review the simple fix for ­ JDK-8174866


JIRA: https://bugs.openjdk.java.net/browse/JDK-8174866

 

Webrev: http://cr.openjdk.java.net/~mbilla/8174866/webrev.00/

 


Thanks,

Murali


RE: CFV: New OpenJFX Committer: Semyon Sadetsky

2017-01-25 Thread Murali Billa

Vote: YES


David Hill wrote:
>
> I hereby nominate Semyon Sadetsky to OpenJFX Committer.
>
> Semyon Sadetsky is part of the JavaFX team focusing on glass.
>
> A list of Semyon's commits and reviews is available by the following 
> links
>
> http://hg.openjdk.java.net/openjfx/9-dev/rt/log?rev=author%28ssadetsky
> %29
>
> Votes are due by Feb 9th, 2017.
>
> Only current OpenJFX Committers [1] are eligible to vote on this 
> nomination. Votes must be cast in the open by replying to this mailing 
> list.
>
> For Lazy Consensus voting instructions, see [2]. Nomination to a 
> project Committer is described in [3].
>
> [1] http://openjdk.java.net/census#openjfx
>
> [2] http://openjdk.java.net/bylaws#lazy-consensus
>
> [3] http://openjdk.java.net/projects#project-committer
>
> Thanks,
>
> Dave


RE: CFV: New OpenJFX Committer: Ramesh Gangadhar

2017-01-18 Thread Murali Billa
Vote: YES

-Original Message-
From: Kevin Rushforth 
Sent: Thursday, January 19, 2017 3:24 AM
To: Ramesh Gangadhar; openjfx-dev@openjdk.java.net
Subject: CFV: New OpenJFX Committer: Ramesh Gangadhar

I hereby nominate Ramesh Gangadhar [1] to OpenJFX Committer.

Ramesh is a member of JavaFX SQE team at Oracle working on test development for 
the Java packager, who has contributed 20 changesets to OpenJFX, at least 8 of 
which [5] are significant.

Votes are due by February 1, 2017.

Only current OpenJFX Committers [2] are eligible to vote on this nomination. 
Votes must be cast in the open by replying to this mailing list.

For Lazy Consensus voting instructions, see [3]. Nomination to a project 
Committer is described in [4].

Thanks,

-- Kevin


[1] http://openjdk.java.net/census#rgangadhar

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

[5]  List of significant changesets:
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/0b702e5db31c
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/0787febc9b94
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/b80a8efca46c
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/9fe019fe7f5c
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/bf6ae1d345ce
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/be0c0e2d0d31
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/b743144c5e11
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/0181e5e6b9bb
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/a141695f4a7f
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/16542d3f79a9
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/78f45d216138
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/92b56a32ebd1



[9] Review request for 8162922: JavaFx WebView canvas doesn't support dash within strokeRec

2017-01-17 Thread Murali Billa
 

Hi Kevin, Arun, Guru,


Please review the fix for ­ JDK-8162922.


JIRA: https://bugs.openjdk.java.net/browse/JDK-8162922

 

Webrev: http://cr.openjdk.java.net/~mbilla/8162922/webrev.00/

 


Thanks,

Murali


[9] Review request for 8172694: JSCallbackMemoryTest fails intermittently

2017-01-16 Thread Murali Billa
 

Hi Kevin, Arun, Guru


Please review the fix for ­ JDK-8172694


JIRA: https://bugs.openjdk.java.net/browse/JDK-8172694

 

Webrev: http://cr.openjdk.java.net/~mbilla/8172694/webrev.00/

 


Thanks,

Murali


[9] Review request for 8164914: Validation of WebSQL Support in Webkit

2017-01-16 Thread Murali Billa
 

Hi Kevin, Arun, Guru


Please review the fix for JDK-8164914


JIRA: https://bugs.openjdk.java.net/browse/JDK-8164914

 

Webrev: http://cr.openjdk.java.net/~mbilla/8164914/webrev.02/

 


Thanks,

Murali


[9] Review request for 8170610: Validation of JSObject Memory leak

2017-01-05 Thread Murali Billa
 

 

Hi Kevin, Arun, Guru


Please review the fix for JDK-8170610.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8170610

 

 

Webrev: http://cr.openjdk.java.net/~mbilla/8170610/webrev.00/

 


Thanks,

Murali


[9] Review request for 8170938: Memory leak in JavaFX WebView

2016-12-09 Thread Murali Billa
 

Hi Kevin, Arun, Guru


Please review the simple fix for JDK-8170938.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8170938


Webrev: http://cr.openjdk.java.net/~mbilla/8170938/webrev.00/

 


Thanks,

Murali


[9] Review request for 8170930: WebView unit test crashes in 32-bit mode

2016-12-08 Thread Murali Billa
 

Hi Kevin,


Please review the backout fix for JDK-8164792.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8170930


Webrev: http://cr.openjdk.java.net/~mbilla/8170930/webrev.00/

 


Thanks,

Murali


[9] Review request for 8164792: Memory leak in JavaFX WebView

2016-11-25 Thread Murali Billa
 

Hi Kevin, Arun, Guru,


Please review the below leak fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8164792


Webrev: http://cr.openjdk.java.net/~mbilla/8164792/webrev.00/

 


Thanks,

Murali


[9] Review request for 8169204: Need to document JSObject Call and setSlot APIs to use weak references

2016-11-04 Thread Murali Billa
Hi Kevin,


Please review the below simple fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8169204


Webrev: http://cr.openjdk.java.net/~mbilla/8169204/webrev.00/

 


Thanks,

Murali


[9] Review request for 8162979: Website weibo.com cannot be loaded

2016-08-24 Thread Murali Billa
 

Hi Kevin, Arun, Guru,


Please review the following fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8162979


Webrev: http://cr.openjdk.java.net/~mbilla/8162979/webrev.00/

 



Thanks,

Murali


[9] Review request for 8090216: HTMLEditor: font bold doesn't work when an indent is set

2016-08-02 Thread Murali Billa
 

Hi Kevin, Arun, Guru,


Please review the following fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8090216


Webrev: http://cr.openjdk.java.net/~mbilla/8090216/webrev.00/



Thanks,

Murali


RE: CFV: New OpenJFX Committer: Andrey Rusakov

2016-07-23 Thread Murali Billa
Vote: YES

Kevin Rushforth wrote:
> I hereby nominate Andrey Rusakov [1] to OpenJFX Committer.
>
> Andrey is a member of JavaFX SQE team at Oracle working on test 
> development, who has contributed 19 changesets [5] to OpenJFX, at 
> least 8 of which are significant.
>
> Votes are due by August 6, 2016.
>
> Only current OpenJFX Committers [2] are eligible to vote on this 
> nomination. Votes must be cast in the open by replying to this mailing 
> list.
>
> For Lazy Consensus voting instructions, see [3]. Nomination to a 
> project Committer is described in [4].
>
> Thanks,
>
> -- Kevin
>
> [1] http://openjdk.java.net/census#arusakov
>
> [2] http://openjdk.java.net/census#openjfx
>
> [3] http://openjdk.java.net/bylaws#lazy-consensus
>
> [4] http://openjdk.java.net/projects#project-committer
>
> [5] List of changesets:
> http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/a1e73dd4613e
> http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/7cce7ed57d89
> http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/34e657660c5c
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/0e78b9e0f50e
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/d356db6612c7
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/1be0ce8c6667
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/adbed89b4b79
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/30fbc7690076
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/b6bd30234e94
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/9b0f70918dc4
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/38c836fde6ab
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/bee64c78137a
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/1e1aea3def0f
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/c20f5594ed04
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/f34e58cb89ff
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/558c27a5d330
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/8ab04be9195b
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/f741badededf
> http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/2e6d6f449f08
>


[9] Review request for 8161699: [Win] Fix Compilation warnings

2016-07-19 Thread Murali Billa
Hi Kevin, Arun, Ankit


Please review below fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8161699


Webrev:  http://cr.openjdk.java.net/~mbilla/8161699/webrev.00/

 

Thanks,

Murali


RE: CFV: New OpenJFX Committer: Ankit Srivastava

2016-07-19 Thread Murali Billa
Vote: YES


David Hill wrote:
>
> I hereby nominate Ankit Srivastava to OpenJFX Committer.
>
> Ankit Srivastava is part of the JavaFX team focusing on Web.
>
> A list of Ankit's commits and reviews is available by the following 
> links
>
> http://hg.openjdk.java.net/openjfx/8u-dev/rt/log?rev=a.ankit.srivastav
> a...@oracle.com
>
> http://hg.openjdk.java.net/openjfx/8u-dev/rt/log?rev=asrivastava
>
> Votes are due by August 3th, 2016.
>
> Only current OpenJFX Committers [1] are eligible to vote on this 
> nomination. Votes must be cast in the open by replying to this mailing 
> list.
>
> For Lazy Consensus voting instructions, see [2]. Nomination to a 
> project Committer is described in [3].
>
> [1] http://openjdk.java.net/census#openjfx
>
> [2] http://openjdk.java.net/bylaws#lazy-consensus
>
> [3] http://openjdk.java.net/projects#project-committer
>
> Thanks,
>
> Dave


[9] Review request for 8161053: Passing objects between JavaScript (JavaFX / WebKit) and Java causes a memory leak

2016-07-13 Thread Murali Billa
Hi Arun, Guru, Ankit


Please review below fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8161053


Webrev: http://cr.openjdk.java.net/~mbilla/8161053/webrev.00/





Thanks,

Murali


[9] Review request for 8160400: WebView can't alert from a timer

2016-06-28 Thread Murali Billa

Hi Kevin, Arun,

Please  review below fix:


JBS : https://bugs.openjdk.java.net/browse/JDK-8160400
Webrev : http://cr.openjdk.java.net/~mbilla/8160400/webrev.00/


Thanks, 
Murali


[9] Review request for 8154127: Need to document that JavaScript to Java bindings use weak references

2016-06-27 Thread Murali Billa

Hi Kevin, Arun,

Please  review below fix:


JBS : https://bugs.openjdk.java.net/browse/JDK-8154127
Webrev : http://cr.openjdk.java.net/~mbilla/8154127/webrev.00/



Thanks, 
Murali


[9] Review request for 8146211: WebView can't alert from a timer

2016-06-24 Thread Murali Billa

Hi Kevin, Arun,

Please  review below fix:


JBS : https://bugs.openjdk.java.net/browse/JDK-8146211
Webrev : http://cr.openjdk.java.net/~mbilla/8146211/webrev.00/


Thanks, 
Murali


[9] Review request for 8150800: NullPointer exception in WebView

2016-05-09 Thread Murali Billa

Hi Kevin, Alexander

Please review below fix.

JBS : https://bugs.openjdk.java.net/browse/JDK-8150800

Webrev : http://cr.openjdk.java.net/~mbilla/8150800/webrev.00/


Thanks, 
Murali


RE: CFV: New OpenJFX Committer: Guru Hb

2016-05-02 Thread Murali Billa
VOTE: YES


-- Murali

On 4/28/16 8:16 AM, Kevin Rushforth wrote:
> I hereby nominate Guru Hb [1] to OpenJFX Committer.
>
> Guru is a member of JavaFX team at Oracle working on WebKit, who has 
> contributed 10 changesets [5] to OpenJFX, at least 8 of which are 
> significant.
>
> Votes are due by May 12, 2016.
>
> Only current OpenJFX Committers [2] are eligible to vote on this 
> nomination. Votes must be cast in the open by replying to this mailing 
> list.
>
> For Lazy Consensus voting instructions, see [3]. Nomination to a 
> project Committer is described in [4].
>
> Thanks,
>
> -- Kevin
>
> [1] http://openjdk.java.net/census#ghb
>
> [2] http://openjdk.java.net/census#openjfx
>
> [3] http://openjdk.java.net/bylaws#lazy-consensus
>
> [4] http://openjdk.java.net/projects#project-committer
>
> [5] List of changesets:
> http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/1ec63f261e9f
> http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/fb4c37073893
> http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/3ccf14ef836f
> http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/45efd3d83bf1
> http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/08a57f273c76
> http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/bd97f8ca31fc
> http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/0576d7a6f137
> http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/d4f8c9496683
> http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/620f5c6b4383
> http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/aa51df7e1d41
>


[9] Review request for 8152393: SQL Server Reporting Services in WebViews shows 401

2016-04-28 Thread Murali Billa

Hi Kevin, Alexander & Arun,

Please review below fix.

JBS : https://bugs.openjdk.java.net/browse/JDK-8152393

Webrev : http://cr.openjdk.java.net/~mbilla/8152393/webrev.00/

This issue is a regression of 8u40 fix for 
https://bugs.openjdk.java.net/browse/JDK-8093859

Rootcause and Fix updated in JIRA and tested in windows.

Thanks, 
Murali


RE: CFV: New OpenJFX Committer: Arunprasad Rajkumar

2016-04-21 Thread Murali Billa
Vote: YES



-- Murali

-Original Message-
From: Kevin Rushforth 
Sent: Thursday, April 21, 2016 10:18 PM
To: Arunprasad Rajkumar; openjfx-dev@openjdk.java.net
Subject: CFV: New OpenJFX Committer: Arunprasad Rajkumar

I hereby nominate Arunprasad Rajkumar [1] to OpenJFX Committer.

Arunprasad is a member of JavaFX team at Oracle working on WebKit, who has 
contributed 10 changesets [5] to OpenJFX, at least 8 of which are significant.

Votes are due by May 5, 2016.

Only current OpenJFX Committers [2] are eligible to vote on this nomination. 
Votes must be cast in the open by replying to this mailing list.

For Lazy Consensus voting instructions, see [3]. Nomination to a project 
Committer is described in [4].

Thanks,

-- Kevin

[1] http://openjdk.java.net/census#arajkumar

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

[5] List of changesets:
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/66eee7a12e81
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/3f15f2e59063
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/b75591ee263b
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/84e09aadadf1
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/4166cbca577f
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/de87459ed168
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/bccedad1f44b
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/71a5499bcda4
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/251198e174cd
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/67a83054f43b



[9] Review request for 8154161: Webkit: Conversion from string literal loses const qualifier

2016-04-14 Thread Murali Billa

Hi  Kevin, Alexander & Arun, 

Can you please review below fix.

JBS : https://bugs.openjdk.java.net/browse/JDK-8154161

Webrev : http://cr.openjdk.java.net/~mbilla/8154161/webrev.00/


Thanks, 
Murali


RE: Windows 7 WebView Text Rendering

2016-01-18 Thread Murali Billa
Hi Michael,

Can you mention what is the resolution/scale under which you  are loading the 
content in webview?

Thanks,
Murali

-Original Message-
From: Michael Ennen [mailto:mike.en...@gmail.com] 
Sent: Friday, January 15, 2016 10:52 AM
To: openjfx-dev@openjdk.java.net
Subject: Windows 7 WebView Text Rendering

Hello,

I am using Java 8u66 on Windows 7 and the text rendering in a WebView is super 
blurry. For comparison purposes, I created a simple test that shows a WebView 
displaying a paragraph and next to it a standard Label showing the same 
paragraph.

http://imgur.com/36RYvf8

(Sorry I don't have a better place to upload the screenshot).

The page I am displaying is the following:




Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed sed blandit 
magna, ut mattis ligula. Donec vestibulum
ut neque id condimentum. Cras blandit erat ac tincidunt bibendum. Nulla 
dapibus arcu risus, at tincidunt leo
facilisis sit amet. Donec imperdiet lectus diam, nec egestas sapien luctus 
nec. Praesent auctor ligula sed sem
dictum venenatis. Donec non dapibus turpis. Aliquam dictum euismod sapien 
id bibendum. Quisque at accumsan eros.
Quisque eleifend maximus justo at tempor. Curabitur ut mi ut justo auctor 
malesuada non at mi. Integer augue neque,
ultrices sit amet augue a, interdum ultricies nibh. Sed imperdiet diam et 
eros maximus ultrices. Pellentesque
habitant morbi tristique senectus et netus et malesuada fames ac turpis 
egestas.




The Java code I am using to create the WebView is:

WebView webView = new WebView();
webView.setPrefSize(410, 620);
webView.getEngine().load(getClass().getResource("/web/test.html").toExternalForm());

Essentially, a incredibly bare-bones example.

This text rendering happens on every page I have tried to load (e.g. actual 
websites).

System info:

OS Name:   Microsoft Windows 7 Ultimate
OS Version:6.1.7601 Service Pack 1 Build 7601

java version "1.8.0_66"
Java(TM) SE Runtime Environment (build 1.8.0_66-b17) Java HotSpot(TM) 64-Bit 
Server VM (build 25.66-b17, mixed mode)

Although this is not a functionality breaking issue (e.g. not a showstopper), 
it really is a serious issue in my eyes because of just how qualities are of 
the rendered texts.

Thanks very much,
--
Michael Ennen


[9] review request: JDK-8147410 Crash with long selector list

2016-01-14 Thread Murali Billa
 

Hi Alexander, kevin,

 

Please review the fix for below issue :

 

JIRA: https://bugs.openjdk.java.net/browse/JDK-8147410

 

Webrev:  http://cr.openjdk.java.net/~mbilla/8147410/ 

 

 

Issue: 

This crash  is webkit regression in 8u60 and fixed in JDK 9 version. 

 

 

Thanks,

Murali

 

 


[9] review request: JDK-8090061 [WebView] replace "char*" with "const char*" where appropriate

2016-01-12 Thread Murali Billa
 

Hi Arun, Alexander, kevin,

 

Please review the fix for below issue :

 

JIRA: https://bugs.openjdk.java.net/browse/JDK-8090061

 

Webrev:  http://cr.openjdk.java.net/~mbilla/8090061/webrev.00/

 

 

Issue: 

This issue is related to changing JNI functions 
signature(BackForwardListJava.cpp - functions initMethod, initCtor) from char* 
to const char* as webkit jni code expecting const char*.

 

 

Thanks,

Murali

 


[9] review request: JDK-8146512 Table Borders are not drawn properly

2016-01-05 Thread Murali Billa
 

Hi Kevin, Alexander, Guru,

 

Please review the fix for below issue :

 

JIRA: https://bugs.openjdk.java.net/browse/JDK-8146512

 

Webrev:  http://cr.openjdk.java.net/~arajkumar/murali/8146512/webrev.00/

 

 

Root Cause: Table Borders are not drawn properly in web sites like wikipedia. 
There is a regression with r153510 (http://trac.webkit.org/changeset/153510) 
and r154622 (http://trac.webkit.org/changeset/154622) from 8u60, which involves 
drawing dotted line and painting collapsed border. The commits r153510 and 
r154622  caused regressions in websites like wikipedia  where table borders are 
not drawn properly.



Fix: Applying webkit patch http://trac.webkit.org/changeset/169814   and 
Verified the fix for above mentioned website.
 
 
Also below DRT cases ran  and passed.
 

fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl.html
 

fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells.html

fast/table/border-collapsing/dotted-collapsed-border.html

 

Thanks,

Murali

 

 


[9] review request: JDK-8145937 Not able to enter text and pop menu disappearing on Mouseover Menu

2015-12-21 Thread Murali Billa
Hi Kevin, Alexander,

 

Please review the fix for below issue :

 

JIRA: https://bugs.openjdk.java.net/browse/JDK-8145937

 

Webrev:  http://cr.openjdk.java.net/~ghb/murali/8145937/webrev.00/

 

 

Root Cause: There is a regression with r157328 
(http://trac.webkit.org/changeset/157328) from 8u60, which simplified Event 
propagating logic in Event Dispatcher. The commit r157328 caused regressions in 
websites where we are not able to enter input text on Mouse over menu.
 
For Example:
 
1. http://www.emirates.com/in/english/ and mouseover "Manage". Try to enter 
"last name" OR "booking reference" in "find your booking". Now pop up 
disappears and not able to enter the text. 

2. HYPERLINK 
"http://www.britishairways.com/travel/home/public/en_us"www.britishairways.com/travel/home/public/en_us
 and mouse over "Manage My Booking". Not able to enter input in fields for 
"Online check-in" or "Find my booking".
 
 
 
Fix: Applying webkit patches http://trac.webkit.org/changeset/167689, 
http://trac.webkit.org/changeset/167805  and 
http://trac.webkit.org/changeset/167840
Verified the fix for above mentioned websites.

 

Thanks,

Murali

 

 


[9] review request: 8145682 topDocument() returns an incorrect reference for cached Documents

2015-12-18 Thread Murali Billa
 

Hi Kevin, Alexander,

 

Please review the fix for  below :

JIRA: https://bugs.openjdk.java.net/browse/JDK-8145682

 

Webrev:  http://cr.openjdk.java.net/~ghb/murali/8145682/webrev.00/

 

Root Cause: There is a regression with r162947 which changed the way the top 
document is determined, effecting below 2 cases: 
1) when the Document is in page cache
2) Document is in the middle of having its render tree destroyed OR 
notification posting for cached or being-destroyed documents., leading to 
non-deletion of the proper top document's AXObjectCache
 
Fix: Applying pre- r162947 way of determining the top document and r164718 
patch applied. Also tested to make sure that 
fast/history/timed-refresh-in-cached-frame.html is also passed.

 

 

Thanks,

Murali

 

 


RE: [9] review request: 8144472 [Webcore] DRT test fast/dom/HTMLInputElement/input-line-height.html fails

2015-12-04 Thread Murali Billa

Hi,

Root Cause: 

fast/dom/HTMLInputElement/input-line-height.html" file is introduced by the 
webkit changeset "http://trac.webkit.org/changeset/155324.
This changeset is reverted in webkit revision 169780 ( 
"http://trac.webkit.org/changeset/169780; -- Japanese text in Google search is 
rendered too low and clipped) as patch set 155324 is causing regression.

Description of Fix:

Revert the webkit patch set 155324 and the associated layout test cases 
(input-line-height.html, input-line-height-expected.txt and 
placeholder-position-expected.txt).Also reverted the line-height which is 
introduced in html.css.

Thanks,
Murali


-Original Message-
From: Victor D'yakov 
Sent: Thursday, December 03, 2015 11:21 PM
To: Murali Billa; Alexander Zvegintsev; Kevin Rushforth; Guru Hb; Arunprasad 
Rajkumar
Cc: openjfx-dev@openjdk.java.net
Subject: Re: [9] review request: 8144472 [Webcore] DRT test 
fast/dom/HTMLInputElement/input-line-height.html fails


Hi Murali,

Could you please share some details about issue root cause and brief 
description of your fix?

Thanks,
Victor

On 03.12.2015 7:40, Murali Billa wrote:
> Hi Kevin, Alexander,
>
>   
>
> Please review the fix related to DumpRenderTree CSS line-height issue.
>
>   
>
> JIRA: https://bugs.openjdk.java.net/browse/JDK-8144472
>
>   
>
>   
>
> Webrev: http://cr.openjdk.java.net/~ghb/murali/8144472/webrev.00/
>
>   
>
> Thanks,
>
> Murali
>
>   
>
>