Re: Convenience factories for Border and Background

2021-04-22 Thread Robert Lichtenberger
I would like this, I am not a big fan of CSS everywhere and this would make small examples easier to read/write. Am Do., 22. Apr. 2021 um 15:47 Uhr schrieb Nir Lisker : > Hi, > > Many times when I want to create a simple solid Background or Border, it is > quite a hassle because of the

Re: Unable to import OpenJFX Build into Eclipse

2021-04-20 Thread Robert Lichtenberger
I have tried to import OpenJFX to eclipse under Windows today for the first time and having the exakt same problem. Am Mo., 17. Aug. 2020 um 13:52 Uhr schrieb Nir Lisker : > They are not required if you use the command line interface, but I find > that they do make things easier since I can run

Integrated: 8261840: Submenus close to screen borders are no longer repositioned

2021-04-20 Thread Robert Lichtenberger
On Tue, 23 Feb 2021 15:32:17 GMT, Robert Lichtenberger wrote: > Reverting to the old way of showing the context menu but with application > of CSS prior to calling prefHeight(-1) / prefWidth(-1) to ensure correct > size measurement of the menu. This pull request has now been i

Re: RFR: 8261840: Submenus close to screen borders are no longer repositioned

2021-04-20 Thread Robert Lichtenberger
On Tue, 23 Feb 2021 15:32:17 GMT, Robert Lichtenberger wrote: > Reverting to the old way of showing the context menu but with application > of CSS prior to calling prefHeight(-1) / prefWidth(-1) to ensure correct > size measurement of the menu. I've finally managed to build Jav

Re: RFR: 8261840: Submenus close to screen borders are no longer repositioned

2021-04-19 Thread Robert Lichtenberger
On Mon, 15 Mar 2021 09:11:41 GMT, Robert Lichtenberger wrote: >> Reverting to the old way of showing the context menu but with application >> of CSS prior to calling prefHeight(-1) / prefWidth(-1) to ensure correct >> size measurement of the menu. > > Yes I can try to l

Re: RFR: 8261840: Submenus close to screen borders are no longer repositioned

2021-03-15 Thread Robert Lichtenberger
On Fri, 12 Mar 2021 13:59:07 GMT, Kevin Rushforth wrote: >> Marked as reviewed by aghaisas (Reviewer). > > This fixes the bug in question, although I see a slight regression in > behavior on Windows with 125% pixel scaling (it doesn't reproduce with any > other scaling value that I tried).

RFR: 8261840: Submenus close to screen borders are no longer repositioned

2021-02-23 Thread Robert Lichtenberger
Reverting to the old way of showing the context menu but with application of CSS prior to calling prefHeight(-1) / prefWidth(-1) to ensure correct size measurement of the menu. - Commit messages: - 8261840: Submenus close to screen borders are no longer repositioned Changes:

Re: Make javafx.controls open and community-driven

2021-02-03 Thread Robert Lichtenberger
I think I can comment from the perspective of a successful user of JavaFX (we have been running an administration application for our medical software for over 5 years now) as well as a part-time contributor to the JavaFX project (with the help of Kevin Rushforth and Ajit Ghaisas my pull request

Integrated: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

2021-01-27 Thread Robert Lichtenberger
On Thu, 21 Jan 2021 06:42:19 GMT, Robert Lichtenberger wrote: > By using the anchor location facility of PopupWindows we can avoid > miscalculation of the > menu's height entirely. > This fix also cleans up some documentation issues. > This fix introduces tests that ch

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS [v4]

2021-01-27 Thread Robert Lichtenberger
withCSS reproduces the problem that is fixed with this patch. > The other test_position_ cases serve as "proof" that no regressions are > introduces. > They work before and after the fix is introduced. Robert Lichtenberger has updated the pull request incrementally with one addi

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS [v3]

2021-01-27 Thread Robert Lichtenberger
On Wed, 27 Jan 2021 11:21:19 GMT, Ajit Ghaisas wrote: >> Robert Lichtenberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8228363: ContextMenu.show with side=TOP does not work the first time in

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS [v3]

2021-01-27 Thread Robert Lichtenberger
On Wed, 27 Jan 2021 10:41:25 GMT, Ajit Ghaisas wrote: >> Robert Lichtenberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8228363: ContextMenu.show with side=TOP does not work the first time in

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS [v3]

2021-01-25 Thread Robert Lichtenberger
withCSS reproduces the problem that is fixed with this patch. > The other test_position_ cases serve as "proof" that no regressions are > introduces. > They work before and after the fix is introduced. Robert Lichtenberger has updated the pull request incrementally with one addi

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS [v2]

2021-01-25 Thread Robert Lichtenberger
On Fri, 22 Jan 2021 18:54:35 GMT, Kevin Rushforth wrote: >> Robert Lichtenberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8228363: ContextMenu.show with side=TOP does not work the first time in

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS [v2]

2021-01-25 Thread Robert Lichtenberger
On Fri, 22 Jan 2021 19:01:13 GMT, Kevin Rushforth wrote: >> Robert Lichtenberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8228363: ContextMenu.show with side=TOP does not work the first time in

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS [v2]

2021-01-22 Thread Robert Lichtenberger
withCSS reproduces the problem that is fixed with this patch. > The other test_position_ cases serve as "proof" that no regressions are > introduces. > They work before and after the fix is introduced. Robert Lichtenberger has updated the pull request incrementally with one addi

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS [v2]

2021-01-22 Thread Robert Lichtenberger
On Fri, 22 Jan 2021 11:02:29 GMT, Robert Lichtenberger wrote: >> While trying to come up with a good documentation I've detected a real >> change in behaviour in connection with the NodeOrientation of the anchor >> node. >> Although this has nev

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

2021-01-22 Thread Robert Lichtenberger
On Fri, 22 Jan 2021 10:53:00 GMT, Robert Lichtenberger wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/ContextMenu.java >> line 241: >> >>> 239: * the {@code ContextMenu} such that its top-left (0,0) position >>> would be attac

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

2021-01-22 Thread Robert Lichtenberger
On Thu, 21 Jan 2021 23:07:23 GMT, Kevin Rushforth wrote: >> By using the anchor location facility of PopupWindows we can avoid >> miscalculation of the >> menu's height entirely. >> This fix also cleans up some documentation issues. >> This fix introduces tests that check the correct

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

2021-01-22 Thread Robert Lichtenberger
On Thu, 21 Jan 2021 23:15:09 GMT, Kevin Rushforth wrote: >> By using the anchor location facility of PopupWindows we can avoid >> miscalculation of the >> menu's height entirely. >> This fix also cleans up some documentation issues. >> This fix introduces tests that check the correct

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

2021-01-22 Thread Robert Lichtenberger
On Thu, 21 Jan 2021 23:11:44 GMT, Kevin Rushforth wrote: >> By using the anchor location facility of PopupWindows we can avoid >> miscalculation of the >> menu's height entirely. >> This fix also cleans up some documentation issues. >> This fix introduces tests that check the correct

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

2021-01-20 Thread Robert Lichtenberger
On Thu, 21 Jan 2021 06:37:59 GMT, Robert Lichtenberger wrote: >> Regarding the spec change, I was thinking of this section, which you removed: >> >> * To clarify the purpose of the {@code hpos} and {@code vpos} >> parameters, >> * consider that they a

RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

2021-01-20 Thread Robert Lichtenberger
By using the anchor location facility of PopupWindows we can avoid miscalculation of the menu's height entirely. This fix also cleans up some documentation issues. This fix introduces tests that check the correct positioning (test_position_) test_position_withCSS reproduces the problem that is

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

2021-01-20 Thread Robert Lichtenberger
On Wed, 20 Jan 2021 16:49:35 GMT, Kevin Rushforth wrote: > Regarding the spec change, I was thinking of this section, which you removed: > > ``` > * To clarify the purpose of the {@code hpos} and {@code vpos} parameters, > * consider that they are relative to the anchor node. As such,

Integrated: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

2021-01-20 Thread Robert Lichtenberger
On Wed, 20 Jan 2021 11:57:04 GMT, Robert Lichtenberger wrote: > By using the anchor location facility of PopupWindows we can avoid > miscalculation of the > menu's height entirely. > This fix also cleans up some documentation issues. > This fix introduces tests that ch

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS [v2]

2021-01-20 Thread Robert Lichtenberger
withCSS reproduces the problem that is fixed with this patch. > The other test_position_* cases serve as "proof" that no regressions are > introduces. > They work before and after the fix is introduced. Robert Lichtenberger has refreshed the contents of this pull request, an

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

2021-01-20 Thread Robert Lichtenberger
On Wed, 20 Jan 2021 16:37:04 GMT, Kevin Rushforth wrote: > This changes the specification in a way that will require prior discussion,. > It also will need a CSR. My hope is that it really doesn't change the specification in any way. All it should do is fix the bug. What part of the spec do

Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

2021-01-20 Thread Robert Lichtenberger
On Wed, 20 Jan 2021 16:39:45 GMT, Kevin Rushforth wrote: > I recommend that you follow the instructions in the earlier comment about > pushing these changes to a new branch, resetting your master branch, and > creating a new PR from your new branch. Ah yes, will try to do so tomorrow.

RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

2021-01-20 Thread Robert Lichtenberger
By using the anchor location facility of PopupWindows we can avoid miscalculation of the menu's height entirely. This fix also cleans up some documentation issues. This fix introduces tests that check the correct positioning (test_position_*) test_position_withCSS reproduces the problem that is

[jfx15] Integrated: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-07-13 Thread Robert Lichtenberger
On Thu, 5 Mar 2020 16:01:10 GMT, Robert Lichtenberger wrote: > This PR fixes JDK-8176270 by clamping the end index of the selected text to > the length of the text. This pull request has now been integrated. Changeset: e2d1c021 Author:Robert Lichtenberger Committer: Kevin Rushfort

Re: [jfx15] RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-07-10 Thread Robert Lichtenberger
On Thu, 2 Jul 2020 23:39:58 GMT, Kevin Rushforth wrote: >> seeing that you are working at it (and still without too close a look, sry >> ;) - we need more tests about the >> notifications of all properties involved: text, selectedText, indexRange >> (anything else?). The things to test are >>

Re: [jfx15] RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException [v8]

2020-07-10 Thread Robert Lichtenberger
> This PR fixes JDK-8176270 by clamping the end index of the selected text to > the length of the text. Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last revision: 8176270: Adding ChangeListener to TextField.selectedTextProperty

Re: [jfx15] RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException [v7]

2020-07-10 Thread Robert Lichtenberger
On Thu, 9 Jul 2020 20:29:51 GMT, Kevin Rushforth wrote: >> Robert Lichtenberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8176270: Adding ChangeListener to TextField.selectedTextProperty causes >&

Re: RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException [v6]

2020-07-01 Thread Robert Lichtenberger
On Tue, 30 Jun 2020 23:05:40 GMT, Kevin Rushforth wrote: >> Robert Lichtenberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8176270: Adding ChangeListener to TextField.selectedTextProperty causes >&

Re: RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException [v7]

2020-07-01 Thread Robert Lichtenberger
> This PR fixes JDK-8176270 by clamping the end index of the selected text to > the length of the text. Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last revision: 8176270: Adding ChangeListener to TextField.selectedTextProperty

Re: Test style questions

2020-06-16 Thread Robert Lichtenberger
ew tests. If it's just a case where the test > coverage is poor, it might make sense for a follow-on test bug to add > new tests. > > I know that this isn't a definitive answer, but hopefully it will > provide some general guidance. > > -- Kevin > > > On 6/15/20

Re: [Rev 05] RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-06-16 Thread Robert Lichtenberger
> This PR fixes JDK-8176270 by clamping the end index of the selected text to > the length of the text. Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last revision: 8176270: Adding ChangeListener to TextField.selectedTextProperty

Test style questions

2020-06-15 Thread Robert Lichtenberger
While discussing my Pull Request ([1]) for JDK-8176270 ([2]) with Jeanette Winzenburg I came across two questions that I would like to ask the community regarding test cases: 1) How fine-grained to we want tests to be? Is it ok to test two (somewhat similiar) things at once or should a separate

Re: Build Problems on Linux

2020-06-15 Thread Robert Lichtenberger
Please ignore my previous mail. I forgot to update my fork of OpenJFX so I was operating on a Mid-March version. After really updating everything worked fine. Am Mo., 15. Juni 2020 um 10:12 Uhr schrieb Robert Lichtenberger < r.lichtenber...@gmail.com>: > I haven't built in a while bu

Re: [Rev 04] RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-06-15 Thread Robert Lichtenberger
> This PR fixes JDK-8176270 by clamping the end index of the selected text to > the length of the text. Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last revision: 8176270: Adding ChangeListener to TextField.selectedTextProperty

Build Problems on Linux

2020-06-15 Thread Robert Lichtenberger
I haven't built in a while but today I pulled the current master branch and tried to build OpenJFX. Unfortunately, the task :graphics:ccLinuxGlassGlassgtk2 fails like this: :graphics:ccLinuxGlassGlassgtk2 (Thread[Daemon worker Thread 2,5,main]) started. Starting process 'command 'gcc''. Working

Re: RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-06-14 Thread Robert Lichtenberger
On Thu, 11 Jun 2020 14:39:08 GMT, Jeanette Winzenburg wrote: > good direction, I think :) > > Didn't look too closely, just added your changes and run the tests - getting > a StringIndexOutofBounds at > TextInputControlTest.test_jdk_8171229_replaceText(TextInputControlTest.java:1862) > (no

Re: RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-05-28 Thread Robert Lichtenberger
On Wed, 27 May 2020 12:11:48 GMT, Robert Lichtenberger wrote: >> you are hacking around ;) >> >> doSelect _must not_ be called somewhere "in-between" changing the text: the >> api doc clearly states that the >> caret/anchor coordinates are the _new_ co

Re: [Rev 03] RFR: WIP: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-05-27 Thread Robert Lichtenberger
> This PR fixes JDK-8176270 by clamping the end index of the selected text to > the length of the text. Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last revision: 8176270: Adding ChangeListener to TextField.selectedTextProperty

Re: RFR: WIP: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-05-27 Thread Robert Lichtenberger
On Wed, 27 May 2020 10:09:52 GMT, Jeanette Winzenburg wrote: >> Clearing the selection temporarily works fine to prevent the >> StringOutOfBoundsException but will also change >> selectionProperty to reflect the selection being 0/0 for a short time. > > you are hacking around ;) > > doSelect

Re: [Rev 02] RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-05-27 Thread Robert Lichtenberger
> This PR fixes JDK-8176270 by clamping the end index of the selected text to > the length of the text. Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last revision: 8176270: Adding ChangeListener to TextField.selectedTextProperty

Re: RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-05-27 Thread Robert Lichtenberger
On Wed, 27 May 2020 07:37:13 GMT, Robert Lichtenberger wrote: >> We're in the process of finishing our products' release. If I find time >> I will try and give this (rather nasty) Problem another shot. >> >> On 2020-05-08 20:51, Kevin Rushforth wrote: >>> >

Re: [Rev 01] RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-05-27 Thread Robert Lichtenberger
> This PR fixes JDK-8176270 by clamping the end index of the selected text to > the length of the text. Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last revision: 8176270: Adding ChangeListener to TextField.selectedTextProperty

Re: RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-05-27 Thread Robert Lichtenberger
On Mon, 11 May 2020 04:54:31 GMT, Robert Lichtenberger wrote: >> @effad I just closed PR #73 due to inactivity. If you are interested >> interested in pursuing this, go ahead and reopen >> this (although you would need to address the feedback that clamping is >>

Re: RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-05-10 Thread Robert Lichtenberger
On Fri, 8 May 2020 18:50:57 GMT, Kevin Rushforth wrote: >> I wasn't aware of PR #73, I only saw the (very old) issue in the JDK Bug >> System and started to look into the issue. >> The fact that two different people start to look into the same issue shows >> it is important however :-). >>

Re: [Closed] RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-05-08 Thread Robert Lichtenberger
On Thu, 5 Mar 2020 16:01:10 GMT, Robert Lichtenberger wrote: > This PR fixes JDK-8176270 by clamping the end index of the selected text to > the length of the text. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jfx/pull/138

Re: RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-03-05 Thread Robert Lichtenberger
On Thu, 5 Mar 2020 18:00:25 GMT, Kevin Rushforth wrote: >> why a second pr for the same issue (see >> https://github.com/openjdk/jfx/pull/73)? particularly one that doesn't do >> much more/else/better (than clamping, which isn't good enough)? > > I have exactly the same question. > > In

RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

2020-03-05 Thread Robert Lichtenberger
This PR fixes JDK-8176270 by clamping the end index of the selected text to the length of the text. - Commits: - e78e8793: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException - d849c67c: Merge remote-tracking branch 'upstream/master'

Re: [Rev 03] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-28 Thread Robert Lichtenberger
> Test simulates a single mouse-released event. > Fix simply guards against the null case. The pull request has been updated with 1 additional commit. - Added commits: - 39a61821: 8237372: NullPointerException in TabPaneSkin.stopDrag Changes: - all:

Re: [Rev 02] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-28 Thread Robert Lichtenberger
On Tue, 28 Jan 2020 12:38:32 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.controls/src/test/java/test/javafx/scene/control/TabPaneTest.java > line 57: > >> 56: import javafx.scene.input.KeyEvent; >> 57: import

Re: [Rev 01] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-26 Thread Robert Lichtenberger
On Fri, 24 Jan 2020 15:41:20 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java > line 1994: > >> 1993: private ListChangeListener childListener = new >>

Re: [Rev 02] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-26 Thread Robert Lichtenberger
> Test simulates a single mouse-released event. > Fix simply guards against the null case. The pull request has been updated with 1 additional commit. - Added commits: - a54a5306: 8237372: NullPointerException in TabPaneSkin.stopDrag Changes: - all:

Re: [Rev 01] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-23 Thread Robert Lichtenberger
> Test simulates a single mouse-released event. > Fix simply guards against the null case. The pull request has been updated with 1 additional commit. - Added commits: - 30290116: 8237372: NullPointerException in TabPaneSkin.stopDrag Changes: - all:

Re: [Rev 01] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-23 Thread Robert Lichtenberger
On Wed, 22 Jan 2020 08:01:49 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java > line 2216: > >> 2215: // Animate tab header being dragged to its final

RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-20 Thread Robert Lichtenberger
Test simulates a single mouse-released event. Fix simply guards against the null case. - Commits: - 923a63b2: 8237372: NullPointerException in TabPaneSkin.stopDrag Changes: https://git.openjdk.java.net/jfx/pull/89/files Webrev: https://webrevs.openjdk.java.net/jfx/89/webrev.00

Correct branch for PR?

2020-01-16 Thread Robert Lichtenberger
I have a testcase + fix ready for JDK-8237372 (A null pointer exception in TabPaneSkin if only a mouse release event is sent to the skin). To avoid the kind of confusion I created with my last pull request ;-) * For what branch should I create the pull request? (From my point of view jfx14 is

Re: Running Web-Tests from eclipse

2020-01-14 Thread Robert Lichtenberger
This looks good to me. Thanks, Robert Am Mi., 15. Jan. 2020 um 07:15 Uhr schrieb Nir Lisker : > I updated the eclipse instructions. Have a look. > > Thanks, > Nir > > On Tue, Jan 14, 2020 at 1:01 PM Robert Lichtenberger < > r.lichtenber...@gmail.com> wrote: >

Re: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

2020-01-14 Thread Robert Lichtenberger
On Tue, 14 Jan 2020 14:43:03 GMT, Kevin Rushforth wrote: >> Partially reviewed, Need to re-check after the change of branch. > > Oh, I see the problem. In addition to rebasing you need to exclude any > commits that are from the `master` branch and are not your. So what you > really need to do

Re: [Rev 03] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

2020-01-14 Thread Robert Lichtenberger
> As documented in JDK-8236912, WebView did not check whether the idMap really > contained a mapping for the given button, making it prone to errors, when > things are extended (as has happened here). > > The fix consists of two test cases that show the problem in unfixed WebViews > and a fix

Re: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

2020-01-14 Thread Robert Lichtenberger
On Tue, 14 Jan 2020 14:00:08 GMT, Kevin Rushforth wrote: >> I've rebased my branch like this: >> git fetch upstream >> git rebase upstream/jfx14 >> git pull >> git push >> and changed the base branch of this PR to jfx14. Hope that was the correct >> way to do this ;-). > > Your branch still

Re: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

2020-01-14 Thread Robert Lichtenberger
> As documented in JDK-8236912, WebView did not check whether the idMap really > contained a mapping for the given button, making it prone to errors, when > things are extended (as has happened here). > > The fix consists of two test cases that show the problem in unfixed WebViews > and a fix

Re: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

2020-01-14 Thread Robert Lichtenberger
On Tue, 14 Jan 2020 12:40:16 GMT, Kevin Rushforth wrote: >> @effad - The extra commits and merge are no problem, provided that you want >> to get this into openjfx15. >> >> However, if you intend to get this into openjfx14, as currently targeted in >> JBS, then you will need to: >> >> 1.

Re: [Rev 01] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

2020-01-14 Thread Robert Lichtenberger
> As documented in JDK-8236912, WebView did not check whether the idMap really > contained a mapping for the given button, making it prone to errors, when > things are extended (as has happened here). > > The fix consists of two test cases that show the problem in unfixed WebViews > and a fix

Re: RFR: 8236912: Preventing NPE when clicking WebView with forward/back mouse buttons

2020-01-14 Thread Robert Lichtenberger
into a separate branch (of my fork), maybe that was the problem. If there is anything else I did wrong, please tell me ;-). The Changes-Link and the Webrev correctly show that only two files are changed. Am Di., 14. Jan. 2020 um 13:02 Uhr schrieb Robert Lichtenberger < rlich...@openjdk.java.

RFR: 8236912: Preventing NPE when clicking WebView with forward/back mouse buttons

2020-01-14 Thread Robert Lichtenberger
As documented in JDK-8236912, WebView did not check whether the idMap really contained a mapping for the given button, making it prone to errors, when things are extended (as has happened here). The fix consists of two test cases that show the problem in unfixed WebViews and a fix which works

Removing unneeded imports from testcode

2020-01-14 Thread Robert Lichtenberger
I'm in the process of preparing a fix for JDK-8236912 and I (or rather eclipse) have noticed that WebViewTest contains an import of java.util.concurrent.FutureTask that is not needed. What is the correct way of handling such things: * Including them into the Pull-Request for the fix of JDK-8236912

Running Web-Tests from eclipse

2020-01-14 Thread Robert Lichtenberger
As a follow-up to the long thread on using an IDE. I just found out that running test.javafx.scene.web.WebViewTest is not possible with -Djavafx.toolkit=test.com.sun.javafx.pgstub.StubToolkit. The test simply fails to start (waiting forever for

Re: "Using an IDE" Page outdated

2020-01-14 Thread Robert Lichtenberger
here as well I'm fairly sure this is the one you see ;-) > > Tom > > On 14.01.20 09:47, Tom Schindl wrote: > > On 14.01.20 09:36, Robert Lichtenberger wrote: > >> I've just simply removed the two missing source folders and only one > >> error remains: > >>

Re: "Using an IDE" Page outdated

2020-01-14 Thread Robert Lichtenberger
ang.NullPointerException at javafx.controls/test.javafx.scene.control.ButtonTest.after(ButtonTest.java:93) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ... it seems the test does not wait for the toolkit to be initialized ... Am Di., 14. Jan. 2020 um 09:11 Uhr schr

Re: "Using an IDE" Page outdated

2020-01-14 Thread Robert Lichtenberger
guage" which may be specific to Windows? Am Di., 14. Jan. 2020 um 08:53 Uhr schrieb Tom Schindl < tom.schi...@bestsolution.at>: > Hi, > > I think Nir nor I uses them as gradle Projects because you have the > .classpath, .project, ... . > > Tom > > On 14.01.20 08:12

Re: "Using an IDE" Page outdated

2020-01-13 Thread Robert Lichtenberger
the problem you are having). My patch > for them was pending review by other Eclipse users and no one tested it, so > if you are up for it I could resume work on it. > > - Nir > > [1] > > https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-BuildandTest &

"Using an IDE" Page outdated

2020-01-10 Thread Robert Lichtenberger
I've noticed that https://wiki.openjdk.java.net/display/OpenJFX/Using+an+IDE seems a bit outdated (refers to JDK 1.8, a folder named "rt", which no longer exists, etc.). Could someone please update this page so that it is easier for newcomers to dive into the development of OpenJFX. Thanks,

Build Problems due to deprecations (linux)

2020-01-10 Thread Robert Lichtenberger
I've tried to run a build of OpenJFX and it fails due to some deprecations within gtk-2: ... In file included from /usr/include/gtk-2.0/gtk/gtkobject.h:37, from /usr/include/gtk-2.0/gtk/gtkwidget.h:36, from /usr/include/gtk-2.0/gtk/gtkcontainer.h:35,

Re: [Rev 01] RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating

2019-12-04 Thread Robert Lichtenberger
The pull request has been updated with additional changes. Added commits: - 7c5cf198: 8232524: Test cleanup: terminate background thread upon failure. Changes: - all: https://git.openjdk.java.net/jfx/pull/17/files - new:

Re: RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating

2019-12-04 Thread Robert Lichtenberger
On Tue, 3 Dec 2019 05:08:49 GMT, Ambarish Rapte wrote: > On Mon, 21 Oct 2019 10:19:04 GMT, Robert Lichtenberger > wrote: > >> By using the collection itself as synchronization lock we achieve behaviour >> that matches java.util.Collections classes. >> >>

Re: RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating

2019-10-21 Thread Robert Lichtenberger
On Mon, 21 Oct 2019 10:19:06 GMT, Robert Lichtenberger wrote: > On Mon, 21 Oct 2019 10:19:05 GMT, Kevin Rushforth wrote: > >> On Mon, 21 Oct 2019 10:19:04 GMT, Robert Lichtenberger >> wrote: >> >>> By using the collection itself as synchron

Re: RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating

2019-10-21 Thread Robert Lichtenberger
On Mon, 21 Oct 2019 10:19:05 GMT, Kevin Rushforth wrote: > On Mon, 21 Oct 2019 10:19:04 GMT, Robert Lichtenberger > wrote: > >> By using the collection itself as synchronization lock we achieve behaviour >> that matches java.util.Collections classes. >> >>

RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating

2019-10-21 Thread Robert Lichtenberger
By using the collection itself as synchronization lock we achieve behaviour that matches java.util.Collections classes. I've create test cases that fail with the current way of synchronizing on a separate object. I've removed unused constructors. Commits: - 7e80839f:

Using gradle mit JDK-13

2019-10-18 Thread Robert Lichtenberger
In trying to provide a fix for JDK-8232524 I have begun to setup a build for JavaFX. According to [1] using JDK-13 is recommended. However, gradle is not yet ready to run on JDK-13 ([2]): [rli@rlinux jfx]$ ./gradlew clean FAILURE: Build failed with an exception. * Where: Build file

Re: Cannot protect copying of synchronizedObservableMap

2019-10-17 Thread Robert Lichtenberger
ad and file a bug. > > 2. Do we need SynchronizedObservableMap at all? > > If we want a map that is both synchronized and observable, then yes. In > any case, I don't see any value in trying to eliminate it from the API > (e.g., through deprecation --> deprecation for remo

Cannot protect copying of synchronizedObservableMap

2019-10-17 Thread Robert Lichtenberger
I've just stumbled upon a devious detail in javafx.collections.FXCollections.SynchronizedObservableMap. Although it almost looks like a twin of Collections.synchronizedMap it does not allow to protect copying or iterating over it the way Collections.synchronizedMap does. Example program: import

Re: Proposal: Migrate official jfx repo to GitHub + Skara tooling

2019-08-21 Thread Robert Lichtenberger
Am 21.08.19 um 00:14 schrieb Kevin Rushforth: > Comments on this proposal are welcome. Best news I've had this week ;-). I appreciate and support this proposal, it will make contributing much easier, especially for people like me who contribute only occasionally.

Re: Debugging JavaFX

2019-07-18 Thread Robert Lichtenberger
lty and I need to download and compile it first, I'm already not very > happy (it's a hassle). But ahm... cygwin, visual studio, directshow header > files (on windows) is not "just type gradle". > > > On 18-7-2019 06:45, Robert Lichtenberger wrote: > > Thanks for the

Re: Debugging JavaFX

2019-07-17 Thread Robert Lichtenberger
;>>> > >>>>>> Am 17.07.19 um 16:45 schrieb Kevin Rushforth: > >>>>>>> That should have been enough to enable local variable symbols. We > >>>>>>> have the following logic for JavaCompile tasks: > >>>>

Debugging JavaFX

2019-07-17 Thread Robert Lichtenberger
I'm trying to get to the bottom of some weird layout problems in my application. To that end I want/need to debug JavaFX classes. But when I step into JavaFX classes I don't see local variables or parameter names. So I thought debug symbols are probably stripped from the official builds. I

Re: Windows (32bit) build problems

2019-07-09 Thread Robert Lichtenberger
After restarting from scratch (on a different machine) the build problems described below simply went away :-). So there was probably something in my environment or I changed something inadvertently. Best regards, Robert Am 08.07.19 um 08:13 schrieb Robert Lichtenberger: > Am 05.07.19 um 11

Re: Windows (32bit) build problems

2019-07-08 Thread Robert Lichtenberger
ange that to: if (WINDOWS_VS_VER != "100" && IS_64) {     winSdkBinDir += "/$CPU_BITS" } gradlew tasks works. Building it still has problems though. I'll try and look into further details, maybe I can come up with a patch that'll make JavaFX compile again on win32. Ro

Re: Windows (32bit) build problems

2019-07-05 Thread Robert Lichtenberger
[1] https://bugs.openjdk.java.net/browse/JDK-8218172 > > [2] > https://wiki.openjdk.java.net/pages/viewpreviousversions.action?pageId=8257548 > > On Thu, Jul 4, 2019 at 6:02 PM Robert Lichtenberger < > r.lichtenber...@gmail.com> wrote: > >> Hello everyone, &g

Windows (32bit) build problems

2019-07-04 Thread Robert Lichtenberger
Hello everyone, I try to build JavaFX-12 mods for Windows-32. For that I cloned http://hg.openjdk.java.net/openjfx/12-dev/rt/ (correct?) and read the build instructions at https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Windows . First question: * The build

Re: Backport for https://bugs.openjdk.java.net/browse/JDK-8157913 to jdk8?

2018-10-17 Thread Robert Lichtenberger
roblem. -- Kevin On 10/15/2018 6:29 AM, Robert Lichtenberger wrote: Is there a chance that the fix for https://bugs.openjdk.java.net/browse/JDK-8157913 will be backported to jdk8? It seems like a major error to me, if packaged applications don't start and I have just been affected by this problem.

Backport for https://bugs.openjdk.java.net/browse/JDK-8157913 to jdk8?

2018-10-15 Thread Robert Lichtenberger
Is there a chance that the fix for https://bugs.openjdk.java.net/browse/JDK-8157913 will be backported to jdk8? It seems like a major error to me, if packaged applications don't start and I have just been affected by this problem. Best regards, Robert Lichtenberger

Compiling OpenJFX

2018-09-18 Thread Robert Lichtenberger
uce a JDK for Windows-32 bit. But will OpenJFX be buildable for that platform? If yes, how? Robert Lichtenberger

Running tests fails with Unrecognized option: -Xpatch:javafx.base=/home/rli/PWEs/rt/build/testing/modules/javafx.base

2016-07-13 Thread Robert Lichtenberger
According to David Hill, one has to use ea109 as base JDK for OpenJFX development. I was able to setup the repository so that gradle tasks works and was able to build and sdk: [rli@rlimbus rt]$ ls build/sdk/lib/ amd64 javafx-mx.jar javafx-swt.jar javafx.properties jfxrt.jar However, when

Re: Handling Enter key presses on Buttons in JavaFX

2016-06-08 Thread Robert Lichtenberger
2) Do we want to have different behaviors for OS X and non-OS X? I'm a newly inducted member into the cult of Mac, and I don't yet have all my bearings sorted out, so I don't have a strong opinion here. Please don't make different OSes behave differently as this is a real pain. I would much

Request for backport of JDK-8144501

2016-05-09 Thread Robert Lichtenberger
We are currently experience null pointer problems that have their root cause in https://bugs.openjdk.java.net/browse/JDK-8144501. The attached example demonstrates the problem: Click the first row, then Ctrl-Click the second row, then Ctrl-Click (i.e. deselect) the first row. Up to

  1   2   >