Re: [jfx18] RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-01-16 Thread Ajit Ghaisas
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth  wrote:

> Update the API specification for the `Window` and `Stage` classes to clarify 
> that the values for some properties and methods can be changed or ignored by 
> the platform. Several of the properties already have a comment to the effect 
> that the value can change externally, and thus the properties are not 
> bindable, but this should be clarified further and for all such properties 
> and methods.
> 
> See the Description of the JBS issues for this bug and its associated CSR for 
> more details.

Marked as reviewed by aghaisas (Reviewer).

-

PR: https://git.openjdk.java.net/jfx/pull/708


Re: [jfx18] RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-01-13 Thread Johan Vos
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth  wrote:

> Update the API specification for the `Window` and `Stage` classes to clarify 
> that the values for some properties and methods can be changed or ignored by 
> the platform. Several of the properties already have a comment to the effect 
> that the value can change externally, and thus the properties are not 
> bindable, but this should be clarified further and for all such properties 
> and methods.
> 
> See the Description of the JBS issues for this bug and its associated CSR for 
> more details.

Re-approved

-

Marked as reviewed by jvos (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/708


Re: [jfx18] RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-01-13 Thread Kevin Rushforth
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth  wrote:

> Update the API specification for the `Window` and `Stage` classes to clarify 
> that the values for some properties and methods can be changed or ignored by 
> the platform. Several of the properties already have a comment to the effect 
> that the value can change externally, and thus the properties are not 
> bindable, but this should be clarified further and for all such properties 
> and methods.
> 
> See the Description of the JBS issues for this bug and its associated CSR for 
> more details.

This is intended for JavaFX 18, so I am changing the branch to `jfx18`, which 
will require a re-review by the reviewers.

-

PR: https://git.openjdk.java.net/jfx/pull/708