Re: [Approved] RFR: 8226754: FX build fails using gradle 5.6+ or 6

2019-10-11 Thread Johan Vos
On Tue, 8 Oct 2019 13:54:22 GMT, Kevin Rushforth wrote: > JBS issue: [JDK-8226754](https://bugs.openjdk.java.net/browse/JDK-8226754) > > As noted in the JBS bug, the JavaFX build fails with gradle 6 (as well as not > building correctly with 5.6 or later). > > The existing JavaFX build uses

Re: [Rev 01] RFR: 8226754: FX build fails using gradle 5.6+ or 6

2019-10-09 Thread Johan Vos
On Wed, 9 Oct 2019 17:16:10 GMT, Kevin Rushforth wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - a928b41f: Revert ivy layout pattern changes per review comments > > Changes: > - all:

Re: [Rev 01] RFR: 8226754: FX build fails using gradle 5.6+ or 6

2019-10-09 Thread Kevin Rushforth
The pull request has been updated with additional changes. Added commits: - a928b41f: Revert ivy layout pattern changes per review comments Changes: - all: https://git.openjdk.java.net/jfx/pull/9/files - new: https://git.openjdk.java.net/jfx/pull/9/files/bc6bd441..a928b41f

Re: RFR: 8226754: FX build fails using gradle 5.6+ or 6

2019-10-09 Thread Kevin Rushforth
On Wed, 9 Oct 2019 12:38:09 GMT, Johan Vos wrote: > On Wed, 9 Oct 2019 12:24:29 GMT, Kevin Rushforth wrote: > >> On Wed, 9 Oct 2019 07:50:44 GMT, Johan Vos wrote: >> >>> On Tue, 8 Oct 2019 13:54:22 GMT, Kevin Rushforth wrote: >>> JBS issue:

Re: RFR: 8226754: FX build fails using gradle 5.6+ or 6

2019-10-09 Thread Johan Vos
On Wed, 9 Oct 2019 12:24:29 GMT, Kevin Rushforth wrote: > On Wed, 9 Oct 2019 07:50:44 GMT, Johan Vos wrote: > >> On Tue, 8 Oct 2019 13:54:22 GMT, Kevin Rushforth wrote: >> >>> JBS issue: [JDK-8226754](https://bugs.openjdk.java.net/browse/JDK-8226754) >>> >>> As noted in the JBS bug, the

Re: RFR: 8226754: FX build fails using gradle 5.6+ or 6

2019-10-09 Thread Kevin Rushforth
On Wed, 9 Oct 2019 07:50:44 GMT, Johan Vos wrote: > On Tue, 8 Oct 2019 13:54:22 GMT, Kevin Rushforth wrote: > >> JBS issue: [JDK-8226754](https://bugs.openjdk.java.net/browse/JDK-8226754) >> >> As noted in the JBS bug, the JavaFX build fails with gradle 6 (as well as >> not building

Re: RFR: 8226754: FX build fails using gradle 5.6+ or 6

2019-10-09 Thread Johan Vos
On Tue, 8 Oct 2019 13:54:22 GMT, Kevin Rushforth wrote: > JBS issue: [JDK-8226754](https://bugs.openjdk.java.net/browse/JDK-8226754) > > As noted in the JBS bug, the JavaFX build fails with gradle 6 (as well as not > building correctly with 5.6 or later). > > The existing JavaFX build uses

RFR: 8226754: FX build fails using gradle 5.6+ or 6

2019-10-08 Thread Kevin Rushforth
JBS issue: [JDK-8226754](https://bugs.openjdk.java.net/browse/JDK-8226754) As noted in the JBS bug, the JavaFX build fails with gradle 6 (as well as not building correctly with 5.6 or later). The existing JavaFX build uses two deprecated features that are removed in gradle 6, so the build