Re: RFR: 8263204: Add Gradle Wrapper Validation Action [v4]

2021-03-09 Thread Kevin Rushforth
On Mon, 8 Mar 2021 22:47:16 GMT, John Neffenger 
 wrote:

>> See the [Gradle Wrapper Validation 
>> Action](https://github.com/marketplace/actions/gradle-wrapper-validation) 
>> for details on this pull request. I'll test the changes with the following 
>> sequence of commits:
>> 
>> 1. This commit adds a tampered Gradle Wrapper JAR file, which should go 
>> undetected.
>> 2. The next commit will add the Official Gradle Wrapper Validation Action, 
>> which should detect the tampered file.
>> 3. The final commit will remove the tampered file and replace it with the 
>> original Gradle 4.8 Wrapper.
>
> John Neffenger has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Restore the Gradle version 4.8 Wrapper JAR file

Marked as reviewed by kcr (Lead).

-

PR: https://git.openjdk.java.net/jfx/pull/419


Re: RFR: 8263204: Add Gradle Wrapper Validation Action [v4]

2021-03-08 Thread John Neffenger
> See the [Gradle Wrapper Validation 
> Action](https://github.com/marketplace/actions/gradle-wrapper-validation) for 
> details on this pull request. I'll test the changes with the following 
> sequence of commits:
> 
> 1. This commit adds a tampered Gradle Wrapper JAR file, which should go 
> undetected.
> 2. The next commit will add the Official Gradle Wrapper Validation Action, 
> which should detect the tampered file.
> 3. The final commit will remove the tampered file and replace it with the 
> original Gradle 4.8 Wrapper.

John Neffenger has updated the pull request incrementally with one additional 
commit since the last revision:

  Restore the Gradle version 4.8 Wrapper JAR file

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/419/files
  - new: https://git.openjdk.java.net/jfx/pull/419/files/b2a737ad..9a4b0215

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx=419=03
 - incr: https://webrevs.openjdk.java.net/?repo=jfx=419=02-03

  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/419.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/419/head:pull/419

PR: https://git.openjdk.java.net/jfx/pull/419