Re: RFR: 8283402: Update to gcc 11.2 on Linux [v2]
> This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. Kevin Rushforth has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'master' into 8283402-gcc-11.2 - 8283402: Update to gcc 11.2 on Linux - Changes: https://git.openjdk.java.net/jfx/pull/761/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=761=01 Stats: 6 lines in 3 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jfx/pull/761.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/761/head:pull/761 PR: https://git.openjdk.java.net/jfx/pull/761
Re: RFR: 8283402: Update to gcc 11.2 on Linux
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. Given that the gcc 11.2 compiler isn't available for the latest Ubuntu LTS, 20.04, it seems worth putting this on hold for a bit. I have moved it to Draft. - PR: https://git.openjdk.java.net/jfx/pull/761
Re: RFR: 8283402: Update to gcc 11.2 on Linux
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. Build on Ubuntu 20.04 looked fine to me. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/761
Re: RFR: 8283402: Update to gcc 11.2 on Linux
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. > are there particular reasons why you want to update to 11.2 ? Updating to gcc 11.2 matches JDK 19 -- [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). - PR: https://git.openjdk.java.net/jfx/pull/761
Re: RFR: 8283402: Update to gcc 11.2 on Linux
On Tue, 29 Mar 2022 11:50:32 GMT, Kevin Rushforth wrote: >> No, it will use whatever the latest is for GitHub actions. There doesn't >> seem to be an 11.2 package for GHA. It should be sufficient for most >> testing, but highlights one of the limitations of relying on GitHub Actions >> for anything more than a sanity test. > > (based on the printout I see in the log files, the current version of gcc 1.x > available on the GHA Linux nodes is 11.1) 11.1 is what I'm using on 18.04 and 20.04 as well. I wonder if that is good enough, or are there particular reasons why you want to update to 11.2 ? - PR: https://git.openjdk.java.net/jfx/pull/761
Re: RFR: 8283402: Update to gcc 11.2 on Linux
On Tue, 29 Mar 2022 11:49:14 GMT, Kevin Rushforth wrote: >> .github/workflows/submit.yml line 86: >> >>> 84: set -x >>> 85: sudo apt-get update >>> 86: sudo apt-get install libgl1-mesa-dev libx11-dev >>> libxxf86vm-dev libxt-dev pkg-config libgtk2.0-dev libgtk-3-dev libxtst-dev >>> gcc-11 g++-11 >> >> Did this install 11.2? The CI is using Focal, and afaik there is no gcc-11.2 >> for focal? > > No, it will use whatever the latest is for GitHub actions. There doesn't seem > to be an 11.2 package for GHA. It should be sufficient for most testing, but > highlights one of the limitations of relying on GitHub Actions for anything > more than a sanity test. (based on the printout I see in the log files, the current version of gcc 1.x available on the GHA Linux nodes is 11.1) - PR: https://git.openjdk.java.net/jfx/pull/761
Re: RFR: 8283402: Update to gcc 11.2 on Linux
On Tue, 29 Mar 2022 09:42:38 GMT, Johan Vos wrote: >> This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK >> 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). >> >> I ran a full build and test, including media and WebKit. > > .github/workflows/submit.yml line 86: > >> 84: set -x >> 85: sudo apt-get update >> 86: sudo apt-get install libgl1-mesa-dev libx11-dev libxxf86vm-dev >> libxt-dev pkg-config libgtk2.0-dev libgtk-3-dev libxtst-dev gcc-11 g++-11 > > Did this install 11.2? The CI is using Focal, and afaik there is no gcc-11.2 > for focal? No, it will use whatever the latest is for GitHub actions. There doesn't seem to be an 11.2 package for GHA. It should be sufficient for most testing, but highlights one of the limitations of relying on GitHub Actions for anything more than a sanity test. - PR: https://git.openjdk.java.net/jfx/pull/761
Re: RFR: 8283402: Update to gcc 11.2 on Linux
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. .github/workflows/submit.yml line 86: > 84: set -x > 85: sudo apt-get update > 86: sudo apt-get install libgl1-mesa-dev libx11-dev libxxf86vm-dev > libxt-dev pkg-config libgtk2.0-dev libgtk-3-dev libxtst-dev gcc-11 g++-11 Did this install 11.2? The CI is using Focal, and afaik there is no gcc-11.2 for focal? - PR: https://git.openjdk.java.net/jfx/pull/761
Re: RFR: 8283402: Update to gcc 11.2 on Linux
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. I shall do a test build and update. - PR: https://git.openjdk.java.net/jfx/pull/761
Re: RFR: 8283402: Update to gcc 11.2 on Linux
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. > This patch updates the compiler to gcc 10.3 Copy/paste error. That should be 11.2 (I updated the Description). - PR: https://git.openjdk.java.net/jfx/pull/761
RFR: 8283402: Update to gcc 11.2 on Linux
This patch updates the compiler to gcc 10.3 on Linux, in order to match JDK 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). I ran a full build and test, including media and WebKit. - Commit messages: - 8283402: Update to gcc 11.2 on Linux Changes: https://git.openjdk.java.net/jfx/pull/761/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=761=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283402 Stats: 6 lines in 3 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jfx/pull/761.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/761/head:pull/761 PR: https://git.openjdk.java.net/jfx/pull/761
