Approved, assuming the changes to the wild-import are done by Alexander
along with a correctly formatted changeset commit message.
-- Kevin
Kevin Rushforth wrote:
Uploaded the new version.
Alexander Zvegintsev will sponsor this patch, and I will review it.
My one quick comment -- in additio
Uploaded the new version.
Alexander Zvegintsev will sponsor this patch, and I will review it.
My one quick comment -- in addition to the wild-card imports which
Alexander Z caught, and said he would take care of -- is that the format
of the commit message is not quite right. See the following
Hi Alexander,
The fix looks good to me, except the wild card import change in
FXCanvas.java(there is no need for a new patch, if it is the only issue
found)
On 8/16/16 10:24 AM, Alexander Nyssen wrote:
You might even take the one I attached. I just recognized I still had some
unused import
You might even take the one I attached. I just recognized I still had some
unused imports in the manual test case (I am still not familiar with IntelliJ).
Regards,
Alexander
> Am 15.08.2016 um 19:26 schrieb Kevin Rushforth :
>
> OK, I'll upload this revised version of the patch today.
>
> --
OK, I'll upload this revised version of the patch today.
-- Kevin
Alexander Nyssen wrote:
Hi Kevin,
please consider the following updated patch instead, which contains an
additional null-check.
Regards
Alexander
A
Hi Kevin,
please consider the following updated patch instead, which contains an
additional null-check.
Regards
Alexander
> Am 12.08.2016 um 16:04 schrieb Alexander Nyssen :
>
> Hi Kevin,
>
> attached please find an initial patch for
> https://bugs.openjdk.java.net/browse/JDK-8161282
>