Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

Looks good. --Semyon On 11/07/2017 06:59 PM, Alexander Zvegintsev wrote: HI Semyon, Please see my answer to Dmitry Hi Dmitry, From my understanding JavaFX stage can't be easily integrated in JDK to support orderWindow() approach, addChildWindow() is a native(and the simplest) way to

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

The latest webrev, version 06, looks good to me now. Approved (although I am not a "R"eviewer for AWT). -- Kevin Alexander Zvegintsev wrote: HI Semyon, Please see my answer to Dmitry Hi Dmitry, From my understanding JavaFX stage can't be easily integrated in JDK to support

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

HI Semyon, Please see my answer to Dmitry Hi Dmitry, From my understanding JavaFX stage can't be easily integrated in JDK to support orderWindow() approach, addChildWindow() is a native(and the simplest) way to maintain one window above other one, should be called only once. IIUC the

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

_FX patch_ The new tests run fine for me on all three platforms. I noticed a couple issues while reviewing it: 1. All robot-based tests should be in the test.robot.** package hierarchy, such that they are only enabled with "-PUSE_ROBOT=true" -- I recommend to put them in a new

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

Hi Alexander, In CPlatformWindow.java change you used addChildWindow(), but we get rig of addChildWindow() in 8080729 and start to manage windows order on java side. Can you test that this change doesn't cause any ordering issues with modal and non-modal child and sibling windows on mac?

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

Thank yo for clarification, looks fine. On 07/11/2017 10:11, Alexander Zvegintsev wrote: Hi Sergey, I am not able to crash it on several platforms, except one case: if we are terminating JavaFX application while EDT processing some long task. But it is unrelated to the fix and reproducible

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

Hi Sergey, I am not able to crash it on several platforms, except one case: if we are terminating JavaFX application while EDT processing some long task. But it is unrelated to the fix and reproducible on current builds. I've filed a separate bug JDK-8190329

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

Looks fine. I am not sure but it looks like the fix has an assumption that the CPlatformWindow.setVisible() code will be executed on EDT/Appkit but it is not the case. This code can be executed on any thread(intentionally for crash), and it will be good to check that it works as expected by

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

Note that there is now a 04 version. It looks good to me, although someone more familiar with AWT should also check the AWT changes. We will need a test program for this (as a follow-on issue if not now). -- Kevin Alexander Zvegintsev wrote: Please review the updated version

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

Please review the updated version http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/02/ Now we are postponing actual window closing, it happens only after we ensure that native window pointer is valid on Swing side. Thanks, Alexander. On 23/09/2017 08:01, Sergey Bylokhov wrote: Hi,

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

Hi Alexander, On the Windows platform you've only modified the dialog native peer while on other platforms all window types are modified to use FX window as a parent. Shouldn't the frame native peer be modified too on the Windows platform? --Semyon On 09/21/2017 10:56 PM, Alexander

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

Hi Sergey, Thanks for catching this, this is an issue which should be addressed. Thanks, Alexander. On 23/09/2017 08:01, Sergey Bylokhov wrote: Hi, Alexander. How can we be sure that the parent frame will not be disposed while we use a pointer? long ownerWindowPtr =

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

Hi Dmitry, From my understanding JavaFX stage can't be easily integrated in JDK to support orderWindow() approach, addChildWindow() is a native(and the simplest) way to maintain one window above other one, should be called only once. IIUC the main concert of JDK-8080729 that child windows

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

Hi Alexander, In CPlatformWindow class you call CWrapper.NSWindow.addChildWindow() to place a window above JavaFX stage. The usage of addChilWindow() or/and removeChildWindow() may cause ‘jumping window issue’ in multi-monitor environment, see JDK-8080729 for more details. To avoid possible

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

Hi, Alexander. How can we be sure that the parent frame will not be disposed while we use a pointer? long ownerWindowPtr = peer.getOverridenWindowHandle(); < Dispose the peer if (ownerWindowPtr != 0) { //Place window above JavaFX stage CWrapper.NSWindow.addChildWindow(

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

I need to look more closely but at a quick glance I don't see any problems so a tentative +1 .. but a final +1 will go in the bug. Have you tested the various configurations .. running this on top of current JDK (not FX) 10 both with and without the FX changes ? -phil. On 09/21/2017 10:56

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

Hi Phil, Please review the updated fix with reflection incorporated http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/01/ New issue created JDK-8187803 as JDK counterpart of this issue. Thanks, Alexander. On 21/09/2017 22:25, Phil Race