Re: [11] Review request: 8200446: Update minimum boot JDK to 10

2018-06-14 Thread Kevin Rushforth
Thanks for the reminder. This is good advice that we should all strive to follow. -- Kevin On 6/14/2018 6:37 AM, Nir Lisker wrote: Once this is done, we can start using JDK 10 features, such as 'var' for local variables (although please don't take this as a license to use 'var'

Re: [11] Review request: 8200446: Update minimum boot JDK to 10

2018-06-14 Thread Nir Lisker
> > Once this is done, we can start using JDK 10 features, such as 'var' for > local variables (although please don't take this as a license to use 'var' > gratuitously). I'll remind that there's a style guide at http://openjdk.java.net/projects/amber/LVTIstyle.html. - Nir On Thu, Jun 14, 2018

[11] Review request: 8200446: Update minimum boot JDK to 10

2018-06-14 Thread Kevin Rushforth
Please review the following to bump the minimum boot JDK required for JavaFX builds to JDK 10. Note that the review will be done on github, but it is OK to reply to this thread with comments if you don't have a github account. https://bugs.openjdk.java.net/browse/JDK-8200446