Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

2016-11-11 Thread Kevin Rushforth
+1 from me, too. -- Kevin Jim Graham wrote: Not as trivial as the Gradient cases, true. +1 on the fix if we're happy with that limitation... ...jim On 11/10/16 3:34 PM, Chien Yang wrote: Yes, we decide to punt on ImagePattern as there isn't a trivial way to find a reasonable

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

2016-11-10 Thread Jim Graham
Not as trivial as the Gradient cases, true. +1 on the fix if we're happy with that limitation... ...jim On 11/10/16 3:34 PM, Chien Yang wrote: Yes, we decide to punt on ImagePattern as there isn't a trivial way to find a reasonable background color for it. - Chien

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

2016-11-10 Thread Chien Yang
Yes, we decide to punt on ImagePattern as there isn't a trivial way to find a reasonable background color for it. - Chien On 11/10/16, 10:22 AM, Jim Graham wrote: I guess we'll punt on ImagePattern? Other than that the fix looks fine... ...jim On 11/9/16 5:35 PM, Chien Yang

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

2016-11-10 Thread Chien Yang
I have tested with different StageStyle and Fill combinations, and all seems to work well with the proposed fix. No more white flashing if the Scene.fill is set with a color(with/without alpha). - Chien On 11/10/16, 4:58 AM, Kevin Rushforth wrote: Hi Tom, This is a good question, and will

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

2016-11-10 Thread Jim Graham
I guess we'll punt on ImagePattern? Other than that the fix looks fine... ...jim On 11/9/16 5:35 PM, Chien Yang wrote: Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8088179 Webrev:

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

2016-11-10 Thread Kevin Rushforth
Hi Tom, This is a good question, and will needs to be checked. If it is a problem, then one possibility would be to modify the fix to skip the call to setBackground if StageStyle == TRANSPARENT. -- Kevin Tom Schindl wrote: Hi, Might be dumb questions but Did you try that this doesn't

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

2016-11-09 Thread Tom Schindl
Hi, Might be dumb questions but Did you try that this doesn't interfere with stages who have been created with StageStyle.TRANSPARENT? What happens if i set the Scene.fill to an rgba value? Doesn't this lead to a different color than what you get today where the background stage background

[9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

2016-11-09 Thread Chien Yang
Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8088179 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8088179/webrev.00/ Thanks, - Chien