Re: [9] Code Review Request For 8155762: Encapsulate JavaFX impl_* implementation methods in transform package

2016-05-07 Thread Chien Yang
Hi Jim, Just quick reply to some of your questions. 1) TransformUtils.java: My initial take was to delete this class but after chatting with Kevin, we decided to keep it in the interest of limiting the scope of this change. Moving those methods will touch much more files. We have about 2

Re: [9] Code Review Request For 8155762: Encapsulate JavaFX impl_* implementation methods in transform package

2016-05-06 Thread Jim Graham
TransformUtils.java - can't this class be deleted now since all it exists to do is to forward to TransformHelper? Alternatively, why create TransformHelper in the first place when it is 90% just a copy of what TransformUtils used to be (ignoring the inner class that got moved to Transform)

[9] Code Review Request For 8155762: Encapsulate JavaFX impl_* implementation methods in transform package

2016-05-04 Thread Chien Yang
Kevin and Jim, Please review the proposed fix: Webrev: https://bugs.openjdk.java.net/browse/JDK-8155762 JIRA: http://cr.openjdk.java.net/~ckyang/JDK-8155762/webrev.00/ Thanks, - Chien