Re: [9] Review Request: 8149975: [packager] Programmatically Determine JDK or JRE Modules

2016-07-06 Thread David Hill

On 7/5/16, 8:40 PM, Chris Bensen wrote:

Hi David,

Please review this change for the Java Packager to programmatically get a list 
of the modules that are to be redistributable. This was waiting on 
https://bugs.openjdk.java.net/browse/JDK-8155955 and 
https://bugs.openjdk.java.net/browse/JDK-8160005 which have now fixed, but is 
still waiting on https://bugs.openjdk.java.net/browse/JDK-8158410 but I thought 
I’d get the review complete in the meantime. Let me know if the build.gradle 
changes are to your liking.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8149975
Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8149975/webrev.01/ 


Thanks,
Chris

Couple of minor nits added to the jbs.

Kevin did not say what the changes that are needed in 8158410 
, I wonder if they are in 
place already.

Dave

--
David Hill
Java Embedded Development

"A man's feet should be planted in his country, but his eyes should survey the 
world."
-- George Santayana (1863 - 1952)



[9] Review Request: 8149975: [packager] Programmatically Determine JDK or JRE Modules

2016-07-05 Thread Chris Bensen
Hi David,

Please review this change for the Java Packager to programmatically get a list 
of the modules that are to be redistributable. This was waiting on 
https://bugs.openjdk.java.net/browse/JDK-8155955 
 and 
https://bugs.openjdk.java.net/browse/JDK-8160005 
 which have now fixed, but is 
still waiting on https://bugs.openjdk.java.net/browse/JDK-8158410 
 but I thought I’d get the 
review complete in the meantime. Let me know if the build.gradle changes are to 
your liking.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8149975 

Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8149975/webrev.01/ 


Thanks,
Chris