Re: [9] Review request: JDK-8147781: Javapackager installer needs to cleanup temporary folders

2017-02-07 Thread Victor Drozdov 
Thanks for pointing out the problem. Currently, the directory is not 
removed regardless "-verbose" is specified or not. I think we can check 
if "-verbose" is specified, and if it is not, remove the temporary 
directory.


New webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8147781/webrev.01/

--Victor

On 07/02/17 03:33, Chris Bensen wrote:

That’s a good point Stefan. I hadn’t noticed the -verbose.

Chris



On Feb 6, 2017, at 4:31 PM, Stefan Fuchs  wrote:

Hi,

are you sure that there is a bug?

The verbose paramter is explicitly documented to leave temporary files around, 
as a starting point for customization.

Quote from 
https://docs.oracle.com/javase/8/docs/technotes/guides/deploy/self-contained-packaging.html

Verbose mode includes the following actions:

.

A copy of the configuration files and resources used to create the self 
contained package are saved to a temporary folder. You can use these files as a 
starting point for customization

...


- Stefan

Chris,

Please review the changes about removing temporary files.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8147781
Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8147781/webrev.00/

--Victor

Re: [9] Review request: JDK-8147781: Javapackager installer needs to cleanup temporary folders

2017-02-06 Thread Chris Bensen 
That’s a good point Stefan. I hadn’t noticed the -verbose.

Chris


> On Feb 6, 2017, at 4:31 PM, Stefan Fuchs  wrote:
> 
> Hi,
> 
> are you sure that there is a bug?
> 
> The verbose paramter is explicitly documented to leave temporary files 
> around, as a starting point for customization.
> 
> Quote from 
> https://docs.oracle.com/javase/8/docs/technotes/guides/deploy/self-contained-packaging.html
> 
> Verbose mode includes the following actions:
> 
> .
> 
> A copy of the configuration files and resources used to create the self 
> contained package are saved to a temporary folder. You can use these files as 
> a starting point for customization
> 
> ...
> 
> 
> - Stefan
>> Chris,
>> 
>> Please review the changes about removing temporary files.
>> 
>> JIRA: https://bugs.openjdk.java.net/browse/JDK-8147781
>> Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8147781/webrev.00/
>> 
>> --Victor
>> 
>> 
>

Re: [9] Review request: JDK-8147781: Javapackager installer needs to cleanup temporary folders

2017-02-06 Thread Stefan Fuchs 

Hi,

are you sure that there is a bug?

The verbose paramter is explicitly documented to leave temporary files 
around, as a starting point for customization.


Quote from 
https://docs.oracle.com/javase/8/docs/technotes/guides/deploy/self-contained-packaging.html


Verbose mode includes the following actions:

.

A copy of the configuration files and resources used to create the self 
contained package are saved to a temporary folder. You can use these 
files as a starting point for customization


...


- Stefan

Chris,

Please review the changes about removing temporary files.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8147781
Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8147781/webrev.00/

--Victor

[9] Review request: JDK-8147781: Javapackager installer needs to cleanup temporary folders

2017-02-06 Thread Victor Drozdov 

Chris,

Please review the changes about removing temporary files.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8147781
Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8147781/webrev.00/

--Victor