The changes are fine with me.
-phil.
On 12/11/2017 02:02 PM, Kevin Rushforth wrote:
This looks good to me. Phil will also take a look since he reviewed
the Java2D version of the fix.
I ran regression tests on all three platforms with no problems. I also
ran three different perf tests on
This looks good to me. Phil will also take a look since he reviewed the
Java2D version of the fix.
I ran regression tests on all three platforms with no problems. I also
ran three different perf tests on Linux, all of which showed the
expected improvement.
-- Kevin
Laurent Bourgès wrote:
Hi Kevin,
Here is the updated patch providing MarlinFX-0.8.2 to OpenJFX-10 that
provides an efficient path clipper fixing the bug JDK-8184429:
http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-082-8184429.0/
It is up-to-date with jfx-dev / jdk forrest (10) and recent changes
from the Marlin
Phil & Kevin,
The proposed plan looks good.
I will first work on refactoring my ShapeClipTest and then focus on having
a Java2d patch ready.
I absolutely want that this new performance improvement will ship in Java
10.
PS: Another important performance change concerns tuning Java2D tile sizes.
And once we are happy with the 2D webrev, it should be pretty
straight-forward to review it for FX.
-- Kevin
Phil Race wrote:
I think they should be separate webrevs sent to the separate lists and
you should start with 2D
as I can then run the JDK regression tests on it. I know you can
I think they should be separate webrevs sent to the separate lists and
you should start with 2D
as I can then run the JDK regression tests on it. I know you can
theoretically run the open regression
tests too (are you ?) but there are some random scattered closed
regression tests that so far
as
Kevin & Phil,
Some news on that issue:
I successfully managed to finish the Path clipping support in Marlin 0.8.2
(release last week):
https://github.com/bourgesl/marlin-renderer/releases/tag/v0.8.2
I fixed few remaining bugs in either Stroker (1) and in PathClipFilter (2)
to have proper &
Hi Laurent,
Some combination of Phil, Sergey, and I will take a look at this when we
can. Perhaps there might be others on these two lists who could lend a
helping hand?
-- Kevin
Laurent Bourgès wrote:
Hi all,
As Jim is no more available to review & answer my questions on java2d /
Hi Jim,
I made good progress on my PathClipFilter that works now perfectly with
many test maps for the NZ rule (EO has artefacts if I enable the filter in
that case).
Here is the updated code below to illustrate the approach:
- use a new IndexStack in (D)Helpers to store only corner indexes (0/1
Jim,
Here is the current code for my experimental PathClipFilter only to show
you what I have done so far:
- DMarlingRenderingEngine.getAATileGenerator():
...
// fill shape:
final PathIterator pi =
norm.getNormalizingPathIterator(rdrCtx,
CCing the mailing-lists
Hi Jim,
I read carefully your very good inputs on clipping / filtering in both
Renderer or PreFilter.
Here are my comments (in the discussion order):
On 8/31/17 4:15 PM, Jim Graham wrote:
>
> - It can stop processing when it reaches the right edge of the clip as the
>
I want to elaborate on winding count issues for segments to the left of the
clip for both winding modes.
All curves have the property that the winding count of any sample point to the right of them is identical to the winding
count of a line from their starting point to their ending point.
Hi Jim,
I am answering your first message:
Area is overkill for this as it tries to find exact intersection points of
arbitrary geometry. You simply need something that will trace accurately
around the outside of a clip to get from an exit point back to an entry
point. That is a much simpler
Hi Laurent,
Area is overkill for this as it tries to find exact intersection points of arbitrary geometry. You simply need
something that will trace accurately around the outside of a clip to get from an exit point back to an entry point.
That is a much simpler operation.
The performance
14 matches
Mail list logo
