Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

2016-08-16 Thread Alexander Zvegintsev
Looks fine to me too. On 8/16/16 1:45 AM, Kevin Rushforth wrote: The 2016-08-12 revision looks fine to me, except for a missing space as noted in JBS (no need for a new patch if that is the only issue found). While we wait for approval from the JDK 9 release team, we need another reviewer

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

2016-08-15 Thread Kevin Rushforth
The 2016-08-12 revision looks fine to me, except for a missing space as noted in JBS (no need for a new patch if that is the only issue found). While we wait for approval from the JDK 9 release team, we need another reviewer for this. Alexander Z: can you take a look? -- Kevin Alexander

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

2016-08-11 Thread Alexander Nyssen
Hi Kevin, attached please find a revised patch that contains the corrections you requested. The patch is now applicable to the new module structure (modues with 'javafx.' prefix). Regards, Alexander > Am 12.08.2016 um 00:00 schrieb Kevin Rushforth : > > > >

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

2016-08-11 Thread Kevin Rushforth
Alexander Nyssen wrote: Hi Kevin, thanks for your feedback. Please fin my comments inline. Am 09.08.2016 um 03:10 schrieb Kevin Rushforth : I uploaded the patch, reviewed it, and provided comments in the bug report. The short version is: * The new API looks

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

2016-08-09 Thread Alexander Nyssen
Hi Kevin, thanks for your feedback. Please fin my comments inline. > Am 09.08.2016 um 03:10 schrieb Kevin Rushforth : > > I uploaded the patch, reviewed it, and provided comments in the bug report. > The short version is: > > * The new API looks good > > * There

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

2016-08-08 Thread Kevin Rushforth
I uploaded the patch, reviewed it, and provided comments in the bug report. The short version is: * The new API looks good * There is a missing '@since 9' in the javadoc comments along with a few typos / style issues * Rather than using reflection and setAccessible in the implementation,

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

2016-07-28 Thread Kevin Rushforth
Hi Alexander Nyssen wrote: Hi, I have added my comments below: Am 28.07.2016 um 17:22 schrieb Kevin Rushforth >: I got the attachment, since Alexander also CCed me directly. I will attach it shortly. Thanks! Done. I do