Re: [Rev 01] RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

2019-12-08 Thread Ambarish Rapte 
On Mon, 9 Dec 2019 06:39:06 GMT, Jeanette Winzenburg  
wrote:

>> fix for https://bugs.openjdk.java.net/browse/JDK-8220722
>> 
>> - replaces the manually registered listener with registerChangeListener(...)
>> - added test that's failing before and passing after the fix (plus a sanity 
>> test that the skin still is listening to changes)
> 
> The pull request has been updated with a new target base due to a merge or a 
> rebase.



-

Marked as reviewed by arapte (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/59

Re: [Rev 01] RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

2019-12-06 Thread Ajit Ghaisas 
On Fri, 6 Dec 2019 09:42:05 GMT, Jeanette Winzenburg  
wrote:

>> fix for https://bugs.openjdk.java.net/browse/JDK-8220722
>> 
>> - replaces the manually registered listener with registerChangeListener(...)
>> - added test that's failing before and passing after the fix (plus a sanity 
>> test that the skin still is listening to changes)
> 
> The pull request has been updated with a new target base due to a merge or a 
> rebase.



-

Marked as reviewed by aghaisas (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/59

Re: [Rev 01] RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property

2019-12-05 Thread Jeanette Winzenburg 
The pull request has been updated with a complete new set of changes (possibly 
due to a rebase).



Commits:
 - a4fae9d7: 8220722: ProgressBarSkin: adds strong listener to control's width

Changes: https://git.openjdk.java.net/jfx/pull/59/files
 Webrev: https://webrevs.openjdk.java.net/jfx/59/webrev.01
  Issue: https://bugs.openjdk.java.net/browse/JDK-8220722
  Stats: 93 lines in 2 files changed: 88 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jfx/pull/59.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/59/head:pull/59

PR: https://git.openjdk.java.net/jfx/pull/59