On Fri, 17 Jan 2020 17:25:51 GMT, Frederic Thevenet
wrote:
>>>
>>>
>>> I tested this fix against the repro code in
>>> [javafxports/openjdk-jfx#433](https://github.com/javafxports/openjdk-jfx/issues/433)
>>> (which is
>>> [JDK-838](https://bugs.openjdk.java.net/browse/JDK-838)),
On Fri, 17 Jan 2020 19:22:24 GMT, Kevin Rushforth wrote:
>> I'm not 100% convinced this would really add much to the readability of the
>> code; I extracted the code from `doSnapshotTile` in its own method because
>> it is called twice (on both sides of the `if (height > maxTextureSize ||
>>
On Fri, 17 Jan 2020 11:28:03 GMT, Frederic Thevenet
wrote:
>> I tested this fix against the repro code in
>> https://github.com/javafxports/openjdk-jfx/issues/433 (which is
>> [JDK-838](https://bugs.openjdk.java.net/browse/JDK-838)), but there
>> is still an NPE. I'm not certain that
On Thu, 16 Jan 2020 16:08:05 GMT, Nir Lisker wrote:
>> The pull request has been updated with 2 additional commits.
>
> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1316:
>
>> 1315: }
>> 1316: }
>> 1317: } else {
>
> I would extract
On Thu, 16 Jan 2020 17:00:32 GMT, Nir Lisker wrote:
>> The pull request has been updated with 2 additional commits.
>
> I tested this fix against the repro code in
> https://github.com/javafxports/openjdk-jfx/issues/433 (which is
>
On Thu, 16 Jan 2020 17:00:47 GMT, Frederic Thevenet
wrote:
>> This PR aims to address the following issue: JDK-8088198 Exception thrown
>> from snapshot if dimensions are larger than max texture size
>>
>> In order to do that, it simply captures snapshots in multiple tiles of
>>
> This PR aims to address the following issue: JDK-8088198 Exception thrown
> from snapshot if dimensions are larger than max texture size
>
> In order to do that, it simply captures snapshots in multiple tiles of
> maxTextureSize^2 dimensions (or less, as needed), and then recomposes all the
