On Mon, 16 Dec 2019 23:41:37 GMT, Jeanette Winzenburg
wrote:
>> This is a fix for https://bugs.openjdk.java.net/browse/JDK-8207759
>>
>> The issue is that default/cancel button on a scene are triggered even though
>> a onKeyPressed handler for ENTER/CANCEL consumes the keyEvent. See the bug
On Mon, 16 Dec 2019 11:21:45 GMT, Jeanette Winzenburg
wrote:
>>
>
> Zitat von "openjdk[bot]" :
>
>> @kleopatra This change can now be integrated. The commit message will be:
>> ```
>
> Ajit, Kevin,
>
> hmm .. wondering if this message is a bot-error? Kevin stated that it
> needs two
On Mon, 16 Dec 2019 08:52:56 GMT, Ajit Ghaisas wrote:
>> The pull request has been updated with 1 additional commit.
>
>
Zitat von "openjdk[bot]" :
> @kleopatra This change can now be integrated. The commit message will be:
> ```
Ajit, Kevin,
hmm .. wondering if this message is a
On Mon, 16 Dec 2019 08:53:10 GMT, Jeanette Winzenburg
wrote:
>> This is a fix for https://bugs.openjdk.java.net/browse/JDK-8207759
>>
>> The issue is that default/cancel button on a scene are triggered even though
>> a onKeyPressed handler for ENTER/CANCEL consumes the keyEvent. See the bug
On Wed, 11 Dec 2019 12:34:51 GMT, Jeanette Winzenburg
wrote:
>> just to let you know: locally added test to explicitly guard against
>> JDK-8145515 (and an ignored one for the regression JDK-8229914) - they are
>> passing/failing the same before/after this fix. Will push later ...
>
> pushed
On Tue, 10 Dec 2019 14:02:23 GMT, Jeanette Winzenburg
wrote:
>> no don't think so: the fix for JDK-8145515 was to prevent the triggering of
>> parent.fireEvent, so removing the method altogether should have no effect :)
>> Could add a test to explicitly guard against this.
>>
>> Please note
> This is a fix for https://bugs.openjdk.java.net/browse/JDK-8207759
>
> The issue is that default/cancel button on a scene are triggered even though
> a onKeyPressed handler for ENTER/CANCEL consumes the keyEvent. See the bug
> for details on both cause and fix.
>
> There are