Kevin and Ajit,
thank you very much for your reviews!
Will apply the changes (including changing CRLF to LF) ASAP.
---rony
On 23.03.2020 22:45, Kevin Rushforth wrote:
> On Sat, 21 Mar 2020 19:19:18 GMT, Kevin Rushforth wrote:
>
>>> Rony G. Flatscher has updated the pull request incrementally
On Sat, 21 Mar 2020 19:19:18 GMT, Kevin Rushforth wrote:
>> Rony G. Flatscher has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> corrected wrong test string
>
> The fix looks good. I left a few comments on the test. One of them is
>
On Thu, 27 Feb 2020 15:56:25 GMT, Rony G. Flatscher
wrote:
>> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
>
> Rony G. Flatscher has updated the pull request incrementally with one
> additional commit since the last revision:
>
> corrected wrong test string
On Fri, 20 Mar 2020 11:28:46 GMT, Ajit Ghaisas wrote:
>> Rony G. Flatscher has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> corrected wrong test string
>
> tests/system/src/testscriptapp1/java/mymod/myapp1/Util.java line 2:
>
>> 1: /*
On Thu, 27 Feb 2020 15:56:25 GMT, Rony G. Flatscher
wrote:
>> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
>
> Rony G. Flatscher has updated the pull request incrementally with one
> additional commit since the last revision:
>
> corrected wrong test string
> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
The pull request has been updated with 1 additional commit.
-
Added commits:
- a42fed5c: corrected wrong test string
Changes:
- all: https://git.openjdk.java.net/jfx/pull/122/files
- new:
