Re: [Rev 02] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-28 Thread Robert Lichtenberger
On Tue, 28 Jan 2020 12:38:32 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.controls/src/test/java/test/javafx/scene/control/TabPaneTest.java > line 57: > >> 56: import javafx.scene.input.KeyEvent; >> 57: import javafx.scene.input.M

Re: [Rev 02] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-28 Thread Ambarish Rapte
On Tue, 28 Jan 2020 12:39:20 GMT, Robert Lichtenberger wrote: >> Test simulates a single mouse-released event. >> Fix simply guards against the null case. > > The pull request has been updated with 1 additional commit. Fix looks good, suggested minor changes in test. modules/javafx.controls/s

Re: [Rev 02] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-26 Thread Robert Lichtenberger
> Test simulates a single mouse-released event. > Fix simply guards against the null case. The pull request has been updated with 1 additional commit. - Added commits: - a54a5306: 8237372: NullPointerException in TabPaneSkin.stopDrag Changes: - all: https://git.openjdk.java.net/j