Re: [Rev 02] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-29 Thread Michael Paus
On Fri, 29 May 2020 12:48:29 GMT, Johan Vos wrote: >> Abhinay Agarwal has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Skin implementation must maintain the contract of dispose > > Looks good. > A test strategy for Android is a good idea

Re: [Rev 02] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-29 Thread Johan Vos
On Tue, 19 May 2020 10:19:42 GMT, Abhinay Agarwal wrote: >> In Android, TextInputControls (TextField and TextArea) are responsible for >> showing and hiding software keyboard. >> Currently, a focus listener is attached to these controls and is used to >> toggle the visibility of keyboard.

Re: [Rev 02] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-19 Thread Abhinay Agarwal
> In Android, TextInputControls (TextField and TextArea) are responsible for > showing and hiding software keyboard. > Currently, a focus listener is attached to these controls and is used to > toggle the visibility of keyboard. This > condition fails in cases where the control already has focus