Re: [Rev 03] RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute

[Guru Hb]

On Mon, 6 Jan 2020 04:32:34 GMT, Arun Joseph  wrote:

>> Issue: Native part of WebView throws a DOMException and then, continues 
>> executing the rest of the function assuming that value is present. This 
>> causes the JVM to crash when retrieving the value.
>> 
>> Fix: Return from the function if exception was raised (code is similar to 
>> exception handling in 
>> [WebKitLegacy/java/DOM/JavaTreeWalker.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebKitLegacy/java/DOM/JavaTreeWalker.cpp))
>> 
>> This fix also needs to be applied to all function calls in 
>> [WebKitLegacy/java/DOM](https://github.com/openjdk/jfx/tree/master/modules/javafx.web/src/main/native/Source/WebKitLegacy/java/DOM)
>>  functions which raises DOMError similar to createAttributeImpl().
> 
> The pull request has been updated with 1 additional commit.

+1, Looks good to me.

-

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/47

Re: [Rev 03] RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute

[Arun Joseph]

The pull request has been updated with additional changes.



Added commits:
 - 472d77cf: Added spaces

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/47/files
  - new: https://git.openjdk.java.net/jfx/pull/47/files/7f6ed5bf..472d77cf

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/47/webrev.03
 - incr: https://webrevs.openjdk.java.net/jfx/47/webrev.02-03

  Issue: https://bugs.openjdk.java.net/browse/JDK-8233747
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/47.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/47/head:pull/47

PR: https://git.openjdk.java.net/jfx/pull/47