Re: [Rev 03] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

2020-01-24 Thread Kevin Rushforth
On Fri, 24 Jan 2020 14:41:00 GMT, Guru Hb wrote: >> Previous commits in this pull request have been removed, probably due to a >> force push. The incremental views will show differences compared to the >> previous content of the PR. > > Marked as reviewed by ghb (Reviewer). @effad you can

Re: [Rev 03] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

2020-01-24 Thread Guru Hb
On Fri, 24 Jan 2020 14:41:11 GMT, Robert Lichtenberger wrote: >> As documented in JDK-8236912, WebView did not check whether the idMap really >> contained a mapping for the given button, making it prone to errors, when >> things are extended (as has happened here). >> >> The fix consists of

Re: [Rev 03] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

2020-01-24 Thread Guru Hb
On Fri, 17 Jan 2020 23:18:28 GMT, Kevin Rushforth wrote: >> Previous commits in this pull request have been removed, probably due to a >> force push. The incremental views will show differences compared to the >> previous content of the PR. > > Looks good to me. > > @guruhb can you re-review

Re: [Rev 03] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

2020-01-17 Thread Kevin Rushforth
On Fri, 17 Jan 2020 23:18:40 GMT, Robert Lichtenberger wrote: >> As documented in JDK-8236912, WebView did not check whether the idMap really >> contained a mapping for the given button, making it prone to errors, when >> things are extended (as has happened here). >> >> The fix consists of

Re: [Rev 03] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

2020-01-14 Thread Robert Lichtenberger
> As documented in JDK-8236912, WebView did not check whether the idMap really > contained a mapping for the given button, making it prone to errors, when > things are extended (as has happened here). > > The fix consists of two test cases that show the problem in unfixed WebViews > and a fix