On Fri, 31 Jan 2020 13:01:51 GMT, Kevin Rushforth wrote:
>> Since @kevinrushforth and @arapte have completed their review, is this ready
>> to integrate?
>> I'm a little confused by the fact this has both `rfr` and `ready` labels
>> attached; is this an expected behaviour?
>
> Yes, this is
On Fri, 31 Jan 2020 11:16:22 GMT, Frederic Thevenet
wrote:
>> With my basic testing, the change looks good, scaled up and scaled down
>> snapshots seem correct visually.
>>
>> After this change the tiled snapshot will be limited by dimensions of the
>> `WritableImage`.
>> We can not create a
On Thu, 30 Jan 2020 08:15:39 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> With my basic testing, the change looks good, scaled up and scaled down
> snapshots seem correct visually.
>
> After this change the tiled snapshot will be limited by
On Thu, 30 Jan 2020 08:15:48 GMT, Frederic Thevenet
wrote:
>> This PR aims to address the following issue: JDK-8088198 Exception thrown
>> from snapshot if dimensions are larger than max texture size
>>
>> In order to do that, it simply captures snapshots in multiple tiles of
>>
On Wed, 29 Jan 2020 19:10:22 GMT, Frederic Thevenet
wrote:
>> This PR aims to address the following issue: JDK-8088198 Exception thrown
>> from snapshot if dimensions are larger than max texture size
>>
>> In order to do that, it simply captures snapshots in multiple tiles of
>>
On Wed, 29 Jan 2020 16:33:16 GMT, Nir Lisker wrote:
>> The code changes look good to me. As long as you are willing to address the
>> follow-on issues for openjfx15, I'll approve this PR for openjfx14, once I
>> run my last test.
>>
>> I did a fair bit of testing of the functionality, which
On Wed, 29 Jan 2020 15:42:51 GMT, Kevin Rushforth wrote:
>> I need to re-review the updated PR.
>
> The code changes look good to me. As long as you are willing to address the
> follow-on issues for openjfx15, I'll approve this PR for openjfx14, once I
> run my last test.
>
> I did a fair
On Wed, 29 Jan 2020 13:59:12 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> I need to re-review the updated PR.
The code changes look good to me. As long as you are willing to address the
follow-on issues for openjfx15, I'll approve this PR for
On Wed, 29 Jan 2020 13:59:32 GMT, Frederic Thevenet
wrote:
>> This PR aims to address the following issue: JDK-8088198 Exception thrown
>> from snapshot if dimensions are larger than max texture size
>>
>> In order to do that, it simply captures snapshots in multiple tiles of
>>
> This PR aims to address the following issue: JDK-8088198 Exception thrown
> from snapshot if dimensions are larger than max texture size
>
> In order to do that, it simply captures snapshots in multiple tiles of
> maxTextureSize^2 dimensions (or less, as needed), and then recomposes all the
10 matches
Mail list logo
