Re: [Rev 06] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-31 Thread Kevin Rushforth 
On Tue, 31 Dec 2019 18:19:29 GMT, Scott Palmer  wrote:

>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute 
>> to both.  TextFlow's tab size overrides that of contained Text nodes.
> 
> The pull request has been updated with 1 additional commit.

Looks good now.

-

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/32

Re: [Rev 06] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-20 Thread Scott Palmer 
> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to 
> both.  TextFlow's tab size overrides that of contained Text nodes.

The pull request has been updated with 1 additional commit.

-

Added commits:
 - 78ddf12e: 8130738: Fixed test issue with StubTextLayout

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/32/files
  - new: https://git.openjdk.java.net/jfx/pull/32/files/f846ad6d..78ddf12e

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/32/webrev.06
 - incr: https://webrevs.openjdk.java.net/jfx/32/webrev.05-06

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/32.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/32/head:pull/32

PR: https://git.openjdk.java.net/jfx/pull/32