Thank you. Incorporated your review comments in
Please take a look.
On 5/9/2016 11:51 PM, Jim Graham wrote:
That looks good for the case where Imin is zero, but it appears that
we could also have overflow as well,
That looks good for the case where Imin is zero, but it appears that we could also have overflow as well, with a single
very tiny Imin the accumulation of estimatedSize with an "int" type could easily overflow and become essentially a
random number. Changing the estimatedSize variable to a
Thanks for your suggestions. As of now I taking an easy way to fix the
issue, New changes are available at
I couldn't write a reliable test case using public javafx APIs, the
behavior is intermittent. However I could
Please review the below patch.
Issue: Divide by zero while adding multiple gradient stops at same offset.