[sandbox-9-jake] Review Request 8080531 - fix ant-javafx ant tasks

2015-10-19 Thread Danno Ferrin
Kevin, Chris, Dmitry Because of the way resources are being handled in current revs of Jake we need to pull the main ant task classes back into ant-javafx and not deploy them into the main packager module. Properly exported in module-info.java all of the other classes are just fine. It

Re: [sandbox-9-jake] Review Request 8080531 - fix ant-javafx ant tasks

2015-10-19 Thread Kevin Rushforth
Looks fine to me. +1 -- Kevin Danno Ferrin wrote: Kevin, Chris, Dmitry Because of the way resources are being handled in current revs of Jake we need to pull the main ant task classes back into ant-javafx and not deploy them into the main packager module. Properly exported in

Re: [sandbox-9-jake] Review Request 8080531 - fix ant-javafx ant tasks

2015-10-19 Thread Dmitry Cherepanov
Looks fine to me. Dmitry On 10/19/15 11:02 PM, Danno Ferrin wrote: Kevin, Chris, Dmitry Because of the way resources are being handled in current revs of Jake we need to pull the main ant task classes back into ant-javafx and not deploy them into the main packager module. Properly

Re: [sandbox-9-jake] Review Request 8080531 - fix ant-javafx ant tasks

2015-10-19 Thread Chris Bensen
+1 Chris > On Oct 19, 2015, at 1:02 PM, Danno Ferrin wrote: > > Kevin, Chris, Dmitry > Because of the way resources are being handled in current revs of Jake we > need to pull the main ant task classes back into ant-javafx and not deploy > them into the main