Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-03-02 Thread Chien Yang
Hi Maurice, Can you please file a JIRA on this issue? Thanks, - Chien On 3/1/16, 11:45 PM, Maurice wrote: Jim, A solution in line of that of Johan Vos [1] works. JavaFX can be run and doesn't crash on startup when compiling the shaders. I think they should be taken into account for at

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-03-01 Thread Maurice
Jim, A solution in line of that of Johan Vos [1] works. JavaFX can be run and doesn't crash on startup when compiling the shaders. I think they should be taken into account for at least JavaFX 9, as it reduces a very serious bug to a possible optimization. Maurice. [1]

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-03-01 Thread Jim Graham
The thing about this use of pixcoord is that the same information can be supplied much more efficiently as a pair of texture coordinates. The value of pixcoord ends up being a linear equation over the area of the primitive which is exactly what texture coordinate samples give you for free.

Re: GLS language errors

2016-03-01 Thread Maurice
Not only does it reduce the amount of errors, but I'm able to run Ensemble, until now without any errors. Therefore it seems to be the right solution. Maurice. Prism pipeline init order: es2 sw Using native-based Pisces rasterizer Using dirty region optimizations Using system sized mask for

Re: GLS language errors

2016-03-01 Thread Maurice
Moving the declaration into the main() method reduces the amount of errors found by the glslangValidator drastically, though it still finds several issues: ./modules/graphics/src/main/resources/com/sun/prism/es2/glsl/normalMap_texture.frag ERROR: 0:53: 'oTexCoords' : undeclared identifier

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-03-01 Thread Maurice
Erik, I've included the generated source code of FillRoundRect_LinearGradient_PAD. I've made the offending lines bold. I've experimented with adding some modifiers, but to no avail. Maurice. #ifdef GL_ES #extension GL_OES_standard_derivatives : enable #ifdef GL_FRAGMENT_PRECISION_HIGH

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-03-01 Thread Erik De Rijcke
I'm not a shader expert either but I have worked (and written some myself) with them, so I'll give my 0.02$ (given that I have no idea what the complete shader looks like) It looks to me like the initialization of a default scoped global (eg Johan's vec2 pixcoord) is done using non constant

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-03-01 Thread Maurice
I'm not very familiar with shader coding, but can't this be solved by putting a non-constant modifier in fron of it? I notice other variables are declared as 'varying' or 'uniform'. Maurice. Op 29-02-16 om 20:45 schreef Johan Vos: Hi, It seems to me you might be running in the same issue we

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-02-29 Thread Maurice
It looks like the same issue indeed and I second the remark "Don't refer to e.g. gl_FragCoord in the header, but put it in main." When running the egl language validator there were additional errors though: ERROR: 0:53: 'texture2D' : no matching overloaded function found WARNING: 0:53: 'return'

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-02-29 Thread Johan Vos
Hi, It seems to me you might be running in the same issue we had on Android with the recent Adreno drivers: http://mail.openjdk.java.net/pipermail/openjfx-dev/2015-July/017575.html See that thread for discussion, and for a fix-proposal here:

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-02-29 Thread Chien Yang
Thanks for the information. It is worth filing a JIRA with a detail information of your embedded device at this point. https://wiki.openjdk.java.net/display/OpenJFX/Submitting+a+Bug+Report Thanks, - Chien On 2/29/2016 10:35 AM, Maurice wrote: No, I build them myself from the instructions on

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-02-29 Thread Chien Yang
I have a quick question. Did you get your embedded JavaFX library from Glueon? http://gluonhq.com/open-source/javafxports/downloads/ - Chien On 2/29/16, 7:21 AM, Maurice wrote: Should I file a bug? I can't determine whether this is a client platform issue or a major bug in the EGL that

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-02-29 Thread Maurice
Should I file a bug? I can't determine whether this is a client platform issue or a major bug in the EGL that JavaFX is using. In any case, it does not work on my embedded device. Maurice. Op 28-02-16 om 18:33 schreef Maurice: When I run the glslangValidator on

GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-02-28 Thread Maurice
When I run the glslangValidator on FillRoundRect_LinearGradient_PAD.frag it gives the following error: ERROR: 0:19: 'non-constant global initializer' : not supported with this profile: es When I move pixcoord's declaration on line 19 into the main() function it gives no errors. This is