On Tue, 7 Sep 2021 14:53:50 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
> this PR fixes the inconsistent event firing pattern in cell's xxEdit methods > (please see the issue for more details): > > - fires event if column != null > - accesses table state if table != null > > The first requires a change in CellEditEvent which now allows null table in > its constructor. > > Added tests that failed/passed before/after the fix (along with some that > also passed before for complete coverage of state permutations). Changed two > old test methods which passed/failed before/after the fix - but did test the > wrong thingy anyway ;) This pull request has now been integrated. Changeset: 55faac49 Author: Jeanette Winzenburg <faste...@openjdk.org> URL: https://git.openjdk.java.net/jfx/commit/55faac49082ee8c92893dac15d2777011ec7dca0 Stats: 404 lines in 12 files changed: 358 ins; 22 del; 24 mod 8271474: Tree-/TableCell: inconsistent edit event firing pattern Reviewed-by: mhanl, aghaisas ------------- PR: https://git.openjdk.java.net/jfx/pull/620