Re: [8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing behind main stage

2018-01-19 Thread Semyon Sadetsky
Rushforth Sent: Thursday, January 18, 2018 3:21 AM To: Phil Race <philip.r...@oracle.com> Cc: Dipak Kumar <dipak.ku...@oracle.com>; openjfx-dev@openjdk.java.net; awt-...@openjdk.java.net Subject: Re: [8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing

RE: [8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing behind main stage

2018-01-17 Thread Dipak Kumar
jdk.java.net Subject: Re: [8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing behind main stage I think you mean https://bugs.openjdk.java.net/browse/JDK-8187803 for the AWT/Swing side... -- Kevin Phil Race wrote: > The AWT/Swing side of this needs to

Re: [8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing behind main stage

2018-01-17 Thread Kevin Rushforth
I think you mean https://bugs.openjdk.java.net/browse/JDK-8187803 for the AWT/Swing side... -- Kevin Phil Race wrote: The AWT/Swing side of this needs to be bug https://bugs.openjdk.java.net/browse/JDK-8185634 One thing I notice is that in XWindowPeer.java the calculation for the value of

Re: [8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing behind main stage

2018-01-17 Thread Kevin Rushforth
Hi Dipak, To underscore the fact that the AWT part of the change has to be pushed under a separate bug ID I have modified the subject line. The FX half of the implementation changes look fine. I tested it on Linux and it works as expected. There are two problems with the unit tests: 1. The