Re: gradle :web:test fails
Yes, I didn't build Webkit and the JDK is 10, but I thought the Webkit
tests would be skipped if it weren't built.
The filed bug should do it. Thanks.
- Nir
On Thu, Apr 5, 2018, 15:01 Kevin Rushforth <kevin.rushfo...@oracle.com>
wrote:
> Yes, this is very likely the issue. If you take the jfxwebkit.dll from
> the latest EA build of JDK 11 then you should be fine. Alternatively, if
> you have the patience to build webkit from source (at least once) then
> you can use that.
>
> Johan had a good idea that gradle :web:test should produce a warning if
> COMPILE_WEBKIT is false [1].
>
> I just now filed a bug [2] to track this.
>
> -- Kevin
>
> [1]
> https://github.com/javafxports/openjdk-jfx/issues/19#issuecomment-
> 378521501
> [2] https://bugs.openjdk.java.net/browse/JDK-8201176
>
>
> Murali Billa wrote:
> > Hi Lisker,
> >
> > +one more point:
> >
> > I think you are not compiling webkit . The command "gradle :web:test"
> picks the webkit dll from JDK (which can have older versions like 10 / 9) .
> >
> > You can compile webkit with command " gradle -PCOMPILE_WEBKIT=true
> :web:test" and in this case webkit dll will be picked up from your source
> code repo (not from JDK).
> >
> > Thanks,
> > Murali
> >
> > -Original Message-
> > From: Murali Billa
> > Sent: Thursday, April 05, 2018 10:19 AM
> > To: Nir Lisker <nlis...@gmail.com>; openjfx-dev@openjdk.java.net
> Mailing <openjfx-dev@openjdk.java.net>
> > Subject: RE: gradle :web:test fails
> >
> > Hi Lisker,
> >
> > Can you print the value of useragentString ? Looks like you are using
> fxversion as 11 (you can print this value from
> System.getProperty("javafx.runtime.version");)
> but the useragentstring does not contain 11.
> >
> > final WebView webView = new WebView();
> > final WebEngine webEngine = webView.getEngine();
> System.out.println(webEngine.getUserAgent());
> >
> >
> > Thanks,
> > Murali
> > -Original Message-
> > From: Nir Lisker <nlis...@gmail.com>
> > Sent: Thursday, April 05, 2018 7:03 AM
> > To: openjfx-dev@openjdk.java.net Mailing <openjfx-dev@openjdk.java.net>
> > Subject: gradle :web:test fails
> >
> > I'm running :web:test in revision 10889 and getting the following failing
> > test:
> >
> > test.javafx.scene.web.MiscellaneousTest > testUserAgentString FAILED
> > java.lang.AssertionError: UserAgentString does not contain JavaFX/11
> > at org.junit.Assert.fail(Assert.java:91)
> > at org.junit.Assert.assertTrue(Assert.java:43)
> > at
> > test.javafx.scene.web.MiscellaneousTest.lambda$testUserAgentString$12(
> MiscellaneousTest.java:441)
> >
> > 379 tests completed, 1 failed, 12 skipped :web:test FAILED
> >
> > Is this known?
> >
> > - Nir
> >
>
Re: gradle :web:test fails
Yes, this is very likely the issue. If you take the jfxwebkit.dll from
the latest EA build of JDK 11 then you should be fine. Alternatively, if
you have the patience to build webkit from source (at least once) then
you can use that.
Johan had a good idea that gradle :web:test should produce a warning if
COMPILE_WEBKIT is false [1].
I just now filed a bug [2] to track this.
-- Kevin
[1]
https://github.com/javafxports/openjdk-jfx/issues/19#issuecomment-378521501
[2] https://bugs.openjdk.java.net/browse/JDK-8201176
Murali Billa wrote:
Hi Lisker,
+one more point:
I think you are not compiling webkit . The command "gradle :web:test" picks
the webkit dll from JDK (which can have older versions like 10 / 9) .
You can compile webkit with command " gradle -PCOMPILE_WEBKIT=true :web:test"
and in this case webkit dll will be picked up from your source code repo (not from JDK).
Thanks,
Murali
-Original Message-
From: Murali Billa
Sent: Thursday, April 05, 2018 10:19 AM
To: Nir Lisker <nlis...@gmail.com>; openjfx-dev@openjdk.java.net Mailing
<openjfx-dev@openjdk.java.net>
Subject: RE: gradle :web:test fails
Hi Lisker,
Can you print the value of useragentString ? Looks like you are using fxversion as 11
(you can print this value from System.getProperty("javafx.runtime.version");)
but the useragentstring does not contain 11.
final WebView webView = new WebView();
final WebEngine webEngine = webView.getEngine(); System.out.println(webEngine.getUserAgent());
Thanks,
Murali
-Original Message-
From: Nir Lisker <nlis...@gmail.com>
Sent: Thursday, April 05, 2018 7:03 AM
To: openjfx-dev@openjdk.java.net Mailing <openjfx-dev@openjdk.java.net>
Subject: gradle :web:test fails
I'm running :web:test in revision 10889 and getting the following failing
test:
test.javafx.scene.web.MiscellaneousTest > testUserAgentString FAILED
java.lang.AssertionError: UserAgentString does not contain JavaFX/11
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.assertTrue(Assert.java:43)
at
test.javafx.scene.web.MiscellaneousTest.lambda$testUserAgentString$12(MiscellaneousTest.java:441)
379 tests completed, 1 failed, 12 skipped :web:test FAILED
Is this known?
- Nir
RE: gradle :web:test fails
Hi Lisker,
+one more point:
I think you are not compiling webkit . The command "gradle :web:test" picks
the webkit dll from JDK (which can have older versions like 10 / 9) .
You can compile webkit with command " gradle -PCOMPILE_WEBKIT=true :web:test"
and in this case webkit dll will be picked up from your source code repo (not
from JDK).
Thanks,
Murali
-Original Message-
From: Murali Billa
Sent: Thursday, April 05, 2018 10:19 AM
To: Nir Lisker <nlis...@gmail.com>; openjfx-dev@openjdk.java.net Mailing
<openjfx-dev@openjdk.java.net>
Subject: RE: gradle :web:test fails
Hi Lisker,
Can you print the value of useragentString ? Looks like you are using
fxversion as 11 (you can print this value from
System.getProperty("javafx.runtime.version");) but the useragentstring does not
contain 11.
final WebView webView = new WebView();
final WebEngine webEngine = webView.getEngine();
System.out.println(webEngine.getUserAgent());
Thanks,
Murali
-Original Message-
From: Nir Lisker <nlis...@gmail.com>
Sent: Thursday, April 05, 2018 7:03 AM
To: openjfx-dev@openjdk.java.net Mailing <openjfx-dev@openjdk.java.net>
Subject: gradle :web:test fails
I'm running :web:test in revision 10889 and getting the following failing
test:
test.javafx.scene.web.MiscellaneousTest > testUserAgentString FAILED
java.lang.AssertionError: UserAgentString does not contain JavaFX/11
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.assertTrue(Assert.java:43)
at
test.javafx.scene.web.MiscellaneousTest.lambda$testUserAgentString$12(MiscellaneousTest.java:441)
379 tests completed, 1 failed, 12 skipped :web:test FAILED
Is this known?
- Nir
RE: gradle :web:test fails
Hi Lisker,
Can you print the value of useragentString ? Looks like you are using
fxversion as 11 (you can print this value from
System.getProperty("javafx.runtime.version");) but the useragentstring does not
contain 11.
final WebView webView = new WebView();
final WebEngine webEngine = webView.getEngine();
System.out.println(webEngine.getUserAgent());
Thanks,
Murali
-Original Message-
From: Nir Lisker
Sent: Thursday, April 05, 2018 7:03 AM
To: openjfx-dev@openjdk.java.net Mailing
Subject: gradle :web:test fails
I'm running :web:test in revision 10889 and getting the following failing
test:
test.javafx.scene.web.MiscellaneousTest > testUserAgentString FAILED
java.lang.AssertionError: UserAgentString does not contain JavaFX/11
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.assertTrue(Assert.java:43)
at
test.javafx.scene.web.MiscellaneousTest.lambda$testUserAgentString$12(MiscellaneousTest.java:441)
379 tests completed, 1 failed, 12 skipped :web:test FAILED
Is this known?
- Nir
