Re: [Integrated] RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Ajit Ghaisas
Changeset: 83eb0a7c Author:Ajit Ghaisas Date: 2019-11-27 07:05:15 + URL: https://git.openjdk.java.net/jfx/commit/83eb0a7c 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation Reviewed-by: kcr, dgrieve ! modules/javafx.graphics/src/main/ja

Re: [Approved] RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Kevin Rushforth
On Tue, 26 Nov 2019 09:22:01 GMT, Ajit Ghaisas wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 2054da4c: Address review comments on test > - 4dade6e5: Simpler fix + System test corrections > - bd4a306a: Revert commit1 and commit

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Sverre Moe
On Tue, 26 Nov 2019 09:22:04 GMT, Kevin Rushforth wrote: > On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: > >> **Issue :** >> https://bugs.openjdk.java.net/browse/JDK-8193445 >> >> **Background :** >> The CSS performance improvement done in >> [JDK-8151756](https://bugs.openjdk.java.ne

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Geoff
On Tue, 26 Nov 2019 09:22:02 GMT, Ajit Ghaisas wrote: > On Tue, 26 Nov 2019 09:22:01 GMT, David Grieve wrote: > >> On Tue, 26 Nov 2019 09:22:01 GMT, Ajit Ghaisas wrote: >> >>> On Tue, 19 Nov 2019 14:29:16 GMT, David Grieve >>> wrote: >>> On Tue, 19 Nov 2019 10:48:52 GMT, Ajit Ghaisas

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread David Grieve
On Tue, 26 Nov 2019 09:22:01 GMT, Ajit Ghaisas wrote: > On Tue, 19 Nov 2019 14:29:16 GMT, David Grieve > wrote: > >> On Tue, 19 Nov 2019 10:48:52 GMT, Ajit Ghaisas wrote: >> >>> On Fri, 15 Nov 2019 09:14:04 GMT, Ajit Ghaisas wrote: >>> On Thu, 14 Nov 2019 18:33:05 GMT, Kevin Rushforth

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Ajit Ghaisas
On Tue, 26 Nov 2019 09:22:01 GMT, David Grieve wrote: > On Tue, 26 Nov 2019 09:22:01 GMT, Ajit Ghaisas wrote: > >> On Tue, 19 Nov 2019 14:29:16 GMT, David Grieve >> wrote: >> >>> On Tue, 19 Nov 2019 10:48:52 GMT, Ajit Ghaisas wrote: >>> On Fri, 15 Nov 2019 09:14:04 GMT, Ajit Ghaisas

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Ajit Ghaisas
On Tue, 26 Nov 2019 09:22:02 GMT, Geoff wrote: > On Tue, 26 Nov 2019 09:22:02 GMT, Ajit Ghaisas wrote: > >> On Tue, 26 Nov 2019 09:22:01 GMT, David Grieve wrote: >> >>> On Tue, 26 Nov 2019 09:22:01 GMT, Ajit Ghaisas wrote: >>> On Tue, 19 Nov 2019 14:29:16 GMT, David Grieve wrot

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Kevin Rushforth
On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: > **Issue :** > https://bugs.openjdk.java.net/browse/JDK-8193445 > > **Background :** > The CSS performance improvement done in > [JDK-8151756](https://bugs.openjdk.java.net/browse/JDK-8151756) had to be > backed out due to functional regre

Re: [Approved] RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread David Grieve
On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: > **Issue :** > https://bugs.openjdk.java.net/browse/JDK-8193445 > > **Background :** > The CSS performance improvement done in > [JDK-8151756](https://bugs.openjdk.java.net/browse/JDK-8151756) had to be > backed out due to functional regre

Re: [Rev 01] RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Ajit Ghaisas
The pull request has been updated with additional changes. Added commits: - 2054da4c: Address review comments on test - 4dade6e5: Simpler fix + System test corrections - bd4a306a: Revert commit1 and commit 2 Changes: - all: https://git.openjdk.java.net/jfx/pull/34/files -

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread Ajit Ghaisas
On Tue, 19 Nov 2019 14:29:16 GMT, David Grieve wrote: > On Tue, 19 Nov 2019 10:48:52 GMT, Ajit Ghaisas wrote: > >> On Fri, 15 Nov 2019 09:14:04 GMT, Ajit Ghaisas wrote: >> >>> On Thu, 14 Nov 2019 18:33:05 GMT, Kevin Rushforth wrote: >>> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-19 Thread David Grieve
On Tue, 19 Nov 2019 10:48:52 GMT, Ajit Ghaisas wrote: > On Fri, 15 Nov 2019 09:14:04 GMT, Ajit Ghaisas wrote: > >> On Thu, 14 Nov 2019 18:33:05 GMT, Kevin Rushforth wrote: >> >>> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: >>> **Issue :** https://bugs.openjdk.java.net/br

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-19 Thread Ajit Ghaisas
On Fri, 15 Nov 2019 09:14:04 GMT, Ajit Ghaisas wrote: > On Thu, 14 Nov 2019 18:33:05 GMT, Kevin Rushforth wrote: > >> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: >> >>> **Issue :** >>> https://bugs.openjdk.java.net/browse/JDK-8193445 >>> >>> **Background :** >>> The CSS performance

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-15 Thread Ajit Ghaisas
On Thu, 14 Nov 2019 18:33:05 GMT, Kevin Rushforth wrote: > On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: > >> **Issue :** >> https://bugs.openjdk.java.net/browse/JDK-8193445 >> >> **Background :** >> The CSS performance improvement done in >> [JDK-8151756](https://bugs.openjdk.java.ne

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-14 Thread Kevin Rushforth
On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: > **Issue :** > https://bugs.openjdk.java.net/browse/JDK-8193445 > > **Background :** > The CSS performance improvement done in > [JDK-8151756](https://bugs.openjdk.java.net/browse/JDK-8151756) had to be > backed out due to functional regre

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-14 Thread David Grieve
On Thu, 14 Nov 2019 15:02:40 GMT, Dean Wookey wrote: > On Thu, 14 Nov 2019 14:27:24 GMT, Kevin Rushforth wrote: > >> On Thu, 14 Nov 2019 12:34:56 GMT, Kevin Rushforth wrote: >> >>> On Thu, 14 Nov 2019 11:33:24 GMT, Dean Wookey wrote: >>> On Wed, 13 Nov 2019 19:10:45 GMT, David Grieve

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-14 Thread Dean Wookey
On Thu, 14 Nov 2019 14:27:24 GMT, Kevin Rushforth wrote: > On Thu, 14 Nov 2019 12:34:56 GMT, Kevin Rushforth wrote: > >> On Thu, 14 Nov 2019 11:33:24 GMT, Dean Wookey wrote: >> >>> On Wed, 13 Nov 2019 19:10:45 GMT, David Grieve >>> wrote: >>> On Tue, 12 Nov 2019 16:55:45 GMT, Ajit Gha

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2019 12:34:56 GMT, Kevin Rushforth wrote: > On Thu, 14 Nov 2019 11:33:24 GMT, Dean Wookey wrote: > >> On Wed, 13 Nov 2019 19:10:45 GMT, David Grieve >> wrote: >> >>> On Tue, 12 Nov 2019 16:55:45 GMT, Ajit Ghaisas wrote: >>> On Tue, 12 Nov 2019 16:52:54 GMT, Ajit Ghaisas

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2019 11:33:24 GMT, Dean Wookey wrote: > On Wed, 13 Nov 2019 19:10:45 GMT, David Grieve > wrote: > >> On Tue, 12 Nov 2019 16:55:45 GMT, Ajit Ghaisas wrote: >> >>> On Tue, 12 Nov 2019 16:52:54 GMT, Ajit Ghaisas wrote: >>> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas >

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-14 Thread Dean Wookey
On Wed, 13 Nov 2019 19:10:45 GMT, David Grieve wrote: > On Tue, 12 Nov 2019 16:55:45 GMT, Ajit Ghaisas wrote: > >> On Tue, 12 Nov 2019 16:52:54 GMT, Ajit Ghaisas wrote: >> >>> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: >>> **Issue :** https://bugs.openjdk.java.net/brow

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-13 Thread David Grieve
On Tue, 12 Nov 2019 16:55:45 GMT, Ajit Ghaisas wrote: > On Tue, 12 Nov 2019 16:52:54 GMT, Ajit Ghaisas wrote: > >> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: >> >>> **Issue :** >>> https://bugs.openjdk.java.net/browse/JDK-8193445 >>> >>> **Background :** >>> The CSS performance im

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-12 Thread Ajit Ghaisas
On Tue, 12 Nov 2019 16:52:54 GMT, Ajit Ghaisas wrote: > On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: > >> **Issue :** >> https://bugs.openjdk.java.net/browse/JDK-8193445 >> >> **Background :** >> The CSS performance improvement done in >> [JDK-8151756](https://bugs.openjdk.java.net/b

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-12 Thread Ajit Ghaisas
On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: > **Issue :** > https://bugs.openjdk.java.net/browse/JDK-8193445 > > **Background :** > The CSS performance improvement done in > [JDK-8151756](https://bugs.openjdk.java.net/browse/JDK-8151756) had to be > backed out due to functional regre

RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-12 Thread Ajit Ghaisas
**Issue :** https://bugs.openjdk.java.net/browse/JDK-8193445 **Background :** The CSS performance improvement done in [JDK-8151756](https://bugs.openjdk.java.net/browse/JDK-8151756) had to be backed out due to functional regressions reported in [JDK-8185709](https://bugs.openjdk.java.net/browse