Re: RFR: 8206253: No/Wrong scroll events from touch input in window mode [v2]

2021-03-10 Thread Johan Vos
On Tue, 9 Mar 2021 18:51:22 GMT, Jose Pereda wrote: >> This PR changes the parameter names to accommodate class calculations >> related to screen event coordinates (AbsX, AbsY). >> >> As >> [discussed](https://bugs.openjdk.java.net/browse/JDK-8206253?focusedCommentId=14405707&page=com.atlassia

Re: RFR: 8206253: No/Wrong scroll events from touch input in window mode [v2]

2021-03-10 Thread Johan Vos
On Tue, 9 Mar 2021 18:48:49 GMT, Jose Pereda wrote: >> Yes, that makes sense. >> >> We could refactor the three `sendScrollXXXEvent` methods to something like: >> >> sendScrollXXXEvent(double xAbs, double yAbs, int touchCount) >> or to: >> >> sendScrollXXXEvent(double x, double y, double xAbs

Re: RFR: 8206253: No/Wrong scroll events from touch input in window mode [v2]

2021-03-10 Thread Kevin Rushforth
On Tue, 9 Mar 2021 18:51:22 GMT, Jose Pereda wrote: >> This PR changes the parameter names to accommodate class calculations >> related to screen event coordinates (AbsX, AbsY). >> >> As >> [discussed](https://bugs.openjdk.java.net/browse/JDK-8206253?focusedCommentId=14405707&page=com.atlassia

Re: RFR: 8206253: No/Wrong scroll events from touch input in window mode [v2]

2021-03-09 Thread Jose Pereda
> This PR changes the parameter names to accommodate class calculations related > to screen event coordinates (AbsX, AbsY). > > As > [discussed](https://bugs.openjdk.java.net/browse/JDK-8206253?focusedCommentId=14405707&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#commen

Re: RFR: 8206253: No/Wrong scroll events from touch input in window mode [v2]

2021-03-09 Thread Jose Pereda
On Tue, 9 Mar 2021 16:42:09 GMT, Jose Pereda wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/ScrollGestureRecognizer.java >> line 265: >> >>> 263: } >>> 264: >>> 265: private void sendScrollStartedEvent(double centerAbsX, double >>> centerAbsY, int touchCount