Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport [v6]

2021-09-10 Thread RationalityFrontline
On Fri, 10 Sep 2021 11:28:25 GMT, Marius Hanl wrote: >> After updating to jfx 17, I detected memory leak in my application (every >> controller that has menu items won't get garbage collected after closing its >> stage), with visualvm I found it was caused by class >>

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport [v6]

2021-09-10 Thread Daniel Peintner
Hi, I don't wanna clutter the list but I noticed this issue also and can point you to a simple test (adding MenuButton is sufficient, no need for any MenuItem). See test here: https://github.com/Sandec/JMemoryBuddy/issues/5#issuecomment-911617849 The test provided fails on JavaFX (v17) and

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport [v6]

2021-09-10 Thread Kevin Rushforth
On Fri, 10 Sep 2021 11:28:25 GMT, Marius Hanl wrote: > Could you please report the bug at https://bugreport.java.com/ with a minimum > reproducible example (written in Java)? I was just going to mention the same thing. See the project [README](https://github.com/openjdk/jfx#readme).

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport [v6]

2021-09-10 Thread Marius Hanl
On Fri, 10 Sep 2021 10:30:07 GMT, RationalityFrontline wrote: > After updating to jfx 17, I detected memory leak in my application (every > controller that has menu items won't get garbage collected after closing its > stage), with visualvm I found it was caused by class >

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport [v6]

2021-09-10 Thread RationalityFrontline
On Mon, 12 Apr 2021 08:40:56 GMT, Ambarish Rapte wrote: >> The method `ControlAcceleratorSupport.doAcceleratorInstall(final List> extends MenuItem> items, final Scene scene)` adds a `ChangeListener` on >> `MenuItem.acceleratorProperty()`. This listener is not removed when the >> MenuItem is

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport [v6]

2021-04-15 Thread Ajit Ghaisas
On Mon, 12 Apr 2021 08:40:56 GMT, Ambarish Rapte wrote: >> The method `ControlAcceleratorSupport.doAcceleratorInstall(final List> extends MenuItem> items, final Scene scene)` adds a `ChangeListener` on >> `MenuItem.acceleratorProperty()`. This listener is not removed when the >> MenuItem is

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport [v6]

2021-04-12 Thread Kevin Rushforth
On Mon, 12 Apr 2021 08:40:56 GMT, Ambarish Rapte wrote: >> The method `ControlAcceleratorSupport.doAcceleratorInstall(final List> extends MenuItem> items, final Scene scene)` adds a `ChangeListener` on >> `MenuItem.acceleratorProperty()`. This listener is not removed when the >> MenuItem is

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport [v6]

2021-04-12 Thread Ambarish Rapte
> The method `ControlAcceleratorSupport.doAcceleratorInstall(final List extends MenuItem> items, final Scene scene)` adds a `ChangeListener` on > `MenuItem.acceleratorProperty()`. This listener is not removed when the > MenuItem is removed from scenegraph. > Adding and removing a MenuItem