Re: [Integrated] RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2020-03-06 Thread Ambarish Rapte
Changeset: f25e8cf2 Author:Ambarish Rapte Date: 2020-03-06 08:23:04 + URL: https://git.openjdk.java.net/jfx/commit/f25e8cf2 8212034: Potential memory leaks in jpegLoader.c in error case Reviewed-by: jvos, kcr ! modules/javafx.graphics/src/main/native-iio/jpegloader.c

Re: [Rev 02] RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2020-03-05 Thread Johan Vos
On Mon, 10 Feb 2020 13:27:27 GMT, Ambarish Rapte wrote: >> Memory allocated in initDecompressor() and decompressIndirect() is not freed >> in error case. >> In error case, >> 1. Allocated memory should be freed. >> 2. Appropriate de-initialization jpeg library calls should be added. >> >> Verif

Re: [Rev 02] RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2020-03-01 Thread Ambarish Rapte
On Wed, 26 Feb 2020 22:17:31 GMT, Kevin Rushforth wrote: >> The pull request has been updated with a new target base due to a merge or a >> rebase. > > Marked as reviewed by kcr (Lead). @johanvos , @arajkumar Could you please take a re-look at the updated PR. - PR: https://git.ope

Re: [Rev 02] RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2020-02-26 Thread Kevin Rushforth
On Mon, 10 Feb 2020 13:27:27 GMT, Ambarish Rapte wrote: >> Memory allocated in initDecompressor() and decompressIndirect() is not freed >> in error case. >> In error case, >> 1. Allocated memory should be freed. >> 2. Appropriate de-initialization jpeg library calls should be added. >> >> Verif

Re: [Rev 02] RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2020-02-10 Thread Ambarish Rapte
On Fri, 7 Feb 2020 10:06:59 GMT, Ambarish Rapte wrote: >> In general, this makes sense. I need to look into more detail that the >> additional calls for freeing resources (in case of errors) don't cause e.g. >> segmentation violations and lead to a crash -- which would be worse than >> throwin

Re: [Rev 02] RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2020-02-10 Thread Ambarish Rapte
> Memory allocated in initDecompressor() and decompressIndirect() is not freed > in error case. > In error case, > 1. Allocated memory should be freed. > 2. Appropriate de-initialization jpeg library calls should be added. > > Verified that, > 1. All unit and systems tests pass on three platforms

Re: [Rev 02] RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2020-02-10 Thread Ambarish Rapte
On Wed, 27 Nov 2019 21:19:08 GMT, Johan Vos wrote: >> The pull request has been updated with a new target base due to a merge or a >> rebase. > > In general, this makes sense. I need to look into more detail that the > additional calls for freeing resources (in case of errors) don't cause e.g.

Re: RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2019-12-02 Thread Ambarish Rapte
On Mon, 2 Dec 2019 12:14:21 GMT, Ambarish Rapte wrote: > On Thu, 28 Nov 2019 11:12:42 GMT, Arunprasad Rajkumar > wrote: > >> On Wed, 27 Nov 2019 11:58:18 GMT, Ambarish Rapte wrote: >> >>> Memory allocated in initDecompressor() and decompressIndirect() is not >>> freed in error case. >>> In

Re: RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2019-12-02 Thread Ambarish Rapte
On Thu, 28 Nov 2019 11:12:42 GMT, Arunprasad Rajkumar wrote: > On Wed, 27 Nov 2019 11:58:18 GMT, Ambarish Rapte wrote: > >> Memory allocated in initDecompressor() and decompressIndirect() is not freed >> in error case. >> In error case, >> 1. Allocated memory should be freed. >> 2. Appropriat

Re: [Rev 01] RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2019-12-02 Thread Ambarish Rapte
The pull request has been updated with additional changes. Added commits: - 8a48080a: correcting use of scanline_ptr Changes: - all: https://git.openjdk.java.net/jfx/pull/54/files - new: https://git.openjdk.java.net/jfx/pull/54/files/7af932b7..8a48080a Webrevs: - full: ht

Re: RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2019-11-28 Thread Arunprasad Rajkumar
On Wed, 27 Nov 2019 11:58:18 GMT, Ambarish Rapte wrote: > Memory allocated in initDecompressor() and decompressIndirect() is not freed > in error case. > In error case, > 1. Allocated memory should be freed. > 2. Appropriate de-initialization jpeg library calls should be added. > > Verified tha

Re: RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2019-11-28 Thread Ambarish Rapte
On Wed, 27 Nov 2019 21:13:40 GMT, Johan Vos wrote: > On Wed, 27 Nov 2019 11:58:18 GMT, Ambarish Rapte wrote: > >> Memory allocated in initDecompressor() and decompressIndirect() is not freed >> in error case. >> In error case, >> 1. Allocated memory should be freed. >> 2. Appropriate de-initia

Re: RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2019-11-27 Thread Johan Vos
On Wed, 27 Nov 2019 11:58:18 GMT, Ambarish Rapte wrote: > Memory allocated in initDecompressor() and decompressIndirect() is not freed > in error case. > In error case, > 1. Allocated memory should be freed. > 2. Appropriate de-initialization jpeg library calls should be added. > > Verified tha

Re: RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2019-11-27 Thread Johan Vos
On Wed, 27 Nov 2019 11:58:18 GMT, Ambarish Rapte wrote: > Memory allocated in initDecompressor() and decompressIndirect() is not freed > in error case. > In error case, > 1. Allocated memory should be freed. > 2. Appropriate de-initialization jpeg library calls should be added. > > Verified tha

Re: RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2019-11-27 Thread Kevin Rushforth
On Wed, 27 Nov 2019 11:58:18 GMT, Ambarish Rapte wrote: > Memory allocated in initDecompressor() and decompressIndirect() is not freed > in error case. > In error case, > 1. Allocated memory should be freed. > 2. Appropriate de-initialization jpeg library calls should be added. > > Verified tha

RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2019-11-27 Thread Ambarish Rapte
Memory allocated in initDecompressor() and decompressIndirect() is not freed in error case. In error case, 1. Allocated memory should be freed. 2. Appropriate de-initialization jpeg library calls should be added. Verified that, 1. All unit and systems tests pass on three platforms, and 2. Memory