Re: RFR: 8217472: Add attenuation for PointLight [v16]

2020-10-19 Thread Nir Lisker
On Fri, 9 Oct 2020 18:11:14 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed test > > tests/performance/3DLighting/attenuation/LightingSample.java line 62: > >> 60:

Re: RFR: 8217472: Add attenuation for PointLight [v16]

2020-10-19 Thread Ambarish Rapte
On Fri, 9 Oct 2020 16:33:28 GMT, Nir Lisker wrote: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed test Looks good to me. There seems to be an existing issue

Re: RFR: 8217472: Add attenuation for PointLight [v16]

2020-10-09 Thread Kevin Rushforth
On Fri, 9 Oct 2020 16:33:28 GMT, Nir Lisker wrote: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed test I think this is ready to go in once it gets a second

Re: RFR: 8217472: Add attenuation for PointLight [v16]

2020-10-09 Thread Kevin Rushforth
On Fri, 9 Oct 2020 16:33:28 GMT, Nir Lisker wrote: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed test

Re: RFR: 8217472: Add attenuation for PointLight [v16]

2020-10-09 Thread Nir Lisker
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Fixed test - Changes: - all: https://git.openjdk.java.net/jfx/pull/43/files - new: