Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v3]

2021-12-16 Thread Kevin Rushforth
On Fri, 18 Sep 2020 18:57:16 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a li

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v3]

2021-04-30 Thread Kevin Rushforth
On Fri, 18 Sep 2020 18:57:16 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a li

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v3]

2021-04-29 Thread Marius Hanl
On Fri, 18 Sep 2020 18:57:16 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a li

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v3]

2020-10-05 Thread Jeanette Winzenburg
On Sat, 19 Sep 2020 15:54:57 GMT, Kevin Rushforth wrote: >> I think that "Contributing to the OpenJFX codebase" should be renamed to >> something related to a style guide. Then split >> the testing part to its own subsection. >> Also, I still find it confusing that "New features / API additions"

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v3]

2020-10-02 Thread Lorenz Pahl
On Fri, 18 Sep 2020 18:57:16 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing >> list as the first step. 2. Add a li

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v3]

2020-09-19 Thread Kevin Rushforth
On Fri, 18 Sep 2020 23:45:30 GMT, Nir Lisker wrote: >> I wanted the "New features / API additions" section to stand on its own. >> Once thing that might be redundant now is the >> following sentence in the "Contributing code and documentation changes" >> section: >> "Feature requests, in partic

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v3]

2020-09-18 Thread Nir Lisker
On Wed, 16 Sep 2020 12:54:19 GMT, Kevin Rushforth wrote: >> The "New features / API additions" repeats some things already stated. Is it >> to make each section independent? > > I wanted the "New features / API additions" section to stand on its own. Once > thing that might be redundant now is

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v3]

2020-09-18 Thread Kevin Rushforth
> This PR updates the `CONTRIBUTING.md` guide to address the following: > > 1. Clarify the process for adding new features / API changes, specifically > that they must be discussed on the mailing > list as the first step. 2. Add a link to the mailing list in the section > regarding contributing