Re: [Integrated] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

Changeset: 1952606a Author:Thiago Milczarek Sayao Committer: Kevin Rushforth Date: 2020-01-02 17:01:13 + URL: https://git.openjdk.java.net/jfx/commit/1952606a 8232811: Dialog's preferred size no longer accommodates multi-line strings Reviewed-by: kcr, arapte !

Re: [Rev 03] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

On Fri, 20 Dec 2019 13:53:43 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 2 additional commits. > > Looks good. > > I can sponsor this fix. @tsayao this is ready for you to integrate. - PR: https://git.openjdk.java.net/jfx/pull/63

Re: [Rev 03] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

On Fri, 20 Dec 2019 13:54:14 GMT, Thiago Milczarek Sayao wrote: >> https://bugs.openjdk.java.net/browse/JDK-8232811 >> >> This one was hard to tackle. >> >> ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests >> test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest > >

Re: [Rev 03] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

On Fri, 20 Dec 2019 13:13:55 GMT, Thiago Milczarek Sayao wrote: >> https://bugs.openjdk.java.net/browse/JDK-8232811 >> >> This one was hard to tackle. >> >> ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests >> test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest > >

Re: [Rev 02] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

On Tue, 17 Dec 2019 21:37:34 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > tests/system/src/test/java/test/robot/javafx/scene/dialog/DialogWithOwnerSizingTest.java > line 63: > >> 62: @Test(timeout = 15000) >> 63: public void

Re: [Rev 02] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

On Thu, 19 Dec 2019 14:13:47 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > tests/system/src/test/java/test/robot/javafx/scene/dialog/DialogWithOwnerSizingTest.java > line 64: > >> 63: public void dialogWithOwnerSizingTest() throws Exception

Re: [Rev 03] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

> https://bugs.openjdk.java.net/browse/JDK-8232811 > > This one was hard to tackle. > > ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests > test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest The pull request has been updated with 2 additional commits. -

Re: [Rev 02] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

On Tue, 17 Dec 2019 23:01:51 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > tests/system/src/test/java/test/robot/javafx/scene/dialog/DialogWithOwnerSizingTest.java > line 124: > >> 123: >> 124:

Re: [Rev 02] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

On Thu, 19 Dec 2019 14:29:39 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 1062: > >> 1061: geometry.final_height.type = BOUNDSTYPE_CONTENT; >> 1062: } >> 1063:

Re: [Rev 02] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

On Thu, 19 Dec 2019 14:32:32 GMT, Thiago Milczarek Sayao wrote: >> https://bugs.openjdk.java.net/browse/JDK-8232811 >> >> This one was hard to tackle. >> >> ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests >> test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest > >

Re: [Rev 02] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

On Tue, 17 Dec 2019 21:43:19 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > The fix looks good (with a minor formatting comment). The test needs a couple > of changes. @arapte - can you be the second reviewer on this? - PR:

Re: [Rev 02] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

On Tue, 17 Dec 2019 23:02:02 GMT, Thiago Milczarek Sayao wrote: >> https://bugs.openjdk.java.net/browse/JDK-8232811 >> >> This one was hard to tackle. >> >> ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests >> test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest > >

Re: RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

On Mon, 9 Dec 2019 18:27:25 GMT, Thiago Milczarek Sayao wrote: > https://bugs.openjdk.java.net/browse/JDK-8232811 > > This one was hard to tackle. > > ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests > test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest This will

Re: [Rev 02] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

> https://bugs.openjdk.java.net/browse/JDK-8232811 > > This one was hard to tackle. > > ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests > test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest The pull request has been updated with 1 additional commit. -

Re: [Rev 01] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

> https://bugs.openjdk.java.net/browse/JDK-8232811 > > This one was hard to tackle. > > ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests > test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest The pull request has been updated with 1 additional commit. -

RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

https://bugs.openjdk.java.net/browse/JDK-8232811 This one was hard to tackle. ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest - Commits: - 338bedbe: Fix mistake - a02894d6: Fix JDK-8232811 -