Re: [Integrated] RFR: 8236832: [macos 10.15] JavaFX Application hangs on video play on Cata…
Changeset: 4c82af8d Author:Alexander Matveev Date: 2020-02-28 05:07:50 + URL: https://git.openjdk.java.net/jfx/commit/4c82af8d 8236832: [macos 10.15] JavaFX Application hangs on video play on Cata… Reviewed-by: kcr, ghb ! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioProcessor.mm ! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioSpectrumUnit.cpp ! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioSpectrumUnit.h ! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFMediaPlayer.mm
Re: RFR: 8236832: [macos 10.15] JavaFX Application hangs on video play on Cata…
On Wed, 26 Feb 2020 03:39:49 GMT, Alexander Matveev wrote: > https://bugs.openjdk.java.net/browse/JDK-8236832 > > - This issue most likely caused by changes in AVFoundation APIs on macOS > 10.15. > - Getting currentTime from AVPlayer was blocked if it is done from > ProcessAudioTap callback (used for spectrum, equalizer and volume) on first > call. If we reading currentTime after first callback returns, then it will > not block. Fixed by not reading currentTime on first call and default it 0. +1, Looks good to me. - Marked as reviewed by ghb (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/126
Re: RFR: 8236832: [macos 10.15] JavaFX Application hangs on video play on Cata…
On Wed, 26 Feb 2020 19:51:38 GMT, Kevin Rushforth wrote: >> https://bugs.openjdk.java.net/browse/JDK-8236832 >> >> - This issue most likely caused by changes in AVFoundation APIs on macOS >> 10.15. >> - Getting currentTime from AVPlayer was blocked if it is done from >> ProcessAudioTap callback (used for spectrum, equalizer and volume) on first >> call. If we reading currentTime after first callback returns, then it will >> not block. Fixed by not reading currentTime on first call and default it 0. > > Looks good to me. > > I think this is a safe enough change that a single reviewer will be > sufficient, although we should wait for one day to see if anyone else has > comments. I tested this on both macOS 10.15.2 (Catalina) and macOS t0.13.6 (High Sierra) and everything looks good. - PR: https://git.openjdk.java.net/jfx/pull/126
Re: RFR: 8236832: [macos 10.15] JavaFX Application hangs on video play on Cata…
On Wed, 26 Feb 2020 03:39:49 GMT, Alexander Matveev wrote: > https://bugs.openjdk.java.net/browse/JDK-8236832 > > - This issue most likely caused by changes in AVFoundation APIs on macOS > 10.15. > - Getting currentTime from AVPlayer was blocked if it is done from > ProcessAudioTap callback (used for spectrum, equalizer and volume) on first > call. If we reading currentTime after first callback returns, then it will > not block. Fixed by not reading currentTime on first call and default it 0. Looks good to me. I think this is a safe enough change that a single reviewer will be sufficient, although we should wait for one day to see if anyone else has comments. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/126
RFR: 8236832: [macos 10.15] JavaFX Application hangs on video play on Cata…
https://bugs.openjdk.java.net/browse/JDK-8236832 - This issue most likely caused by changes in AVFoundation APIs on macOS 10.15. - Getting currentTime from AVPlayer was blocked if it is done from ProcessAudioTap callback (used for spectrum, equalizer and volume) on first call. If we reading currentTime after first callback returns, then it will not block. Fixed by not reading currentTime on first call and default it 0. - Commits: - c8438fd6: 8236832: [macos 10.15] JavaFX Application hangs on video play on Catalina Changes: https://git.openjdk.java.net/jfx/pull/126/files Webrev: https://webrevs.openjdk.java.net/jfx/126/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8236832 Stats: 23 lines in 4 files changed: 15 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jfx/pull/126.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/126/head:pull/126 PR: https://git.openjdk.java.net/jfx/pull/126
