On Wed, 30 Mar 2022 12:10:19 GMT, Kevin Rushforth wrote:
>> I found assertions in various other parts of the code (e.g.
>> `javafx.scene.control.skin.VirtualFlow`) so I assumed this is ok.
>
> Some old code has assertions, but library code should not use them. Please
> delete them from any new
On Wed, 30 Mar 2022 10:57:38 GMT, Robert Lichtenberger
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java
>> line 715:
>>
>>> 713: tableRow = createMeasureRow(tv, tableSkin, null);
>>> 714: }
>>> 715: assert
On Tue, 29 Mar 2022 20:35:10 GMT, Marius Hanl wrote:
>> Robert Lichtenberger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8251480: TableColumnHeader: calc of cell width must respect row styling
>>
>> Old behaviour restored for
On Thu, 24 Mar 2022 06:14:42 GMT, Robert Lichtenberger
wrote:
>> This fix respects a row factory, if present.
>> It will put the cell that is used to measure the column width as child below
>> the row.
>> In that way the row's style will be used.
>
> Robert Lichtenberger has updated the pull
On Thu, 24 Mar 2022 04:57:27 GMT, Robert Lichtenberger
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java
>> line 650:
>>
>>> 648: }
>>> 649: Callback, TableRow> rowFactory =
>>> tv.getRowFactory();
>>> 650: TableRow
> This fix respects a row factory, if present.
> It will put the cell that is used to measure the column width as child below
> the row.
> In that way the row's style will be used.
Robert Lichtenberger has updated the pull request incrementally with one
additional commit since the last
