Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-06 Thread Johan Vos
On Thu, 5 Nov 2020 20:57:13 GMT, John Neffenger wrote: >> Marked as reviewed by kcr (Lead). > > Thanks, Johan. Can we compare build environments? I cross-compile on Ubuntu > 20.04.1 LTS. I followed the instructions at [Cross Building for ARM Hard > Float][1] to fetch the toolchain. I use

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread John Neffenger
On Thu, 5 Nov 2020 20:33:05 GMT, Kevin Rushforth wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change invocation of getEGLDisplayHandle into getEglDisplayHandle >> Conditionally add dlfcn > > Marked as reviewed

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread Kevin Rushforth
On Thu, 5 Nov 2020 16:41:09 GMT, Johan Vos wrote: >> Allow the EGL functionality in monocle to leverage EGL-based systems. The >> low-level specific details about how the EGL calls should be constructed are >> left out, and a native interface (egl_ext.h) is created that can be mapped >> to

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread Johan Vos
On Thu, 5 Nov 2020 19:27:54 GMT, John Neffenger wrote: >> Marked as reviewed by jpereda (Committer). > > The fix for the compile-time error still fails for target *armv6hf*: > `MonocleGLFactory.c:110:19: error: ‘RTLD_DEFAULT’ undeclared (first use in > this function)`. Here's one solution: >

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread John Neffenger
On Thu, 5 Nov 2020 18:16:58 GMT, Jose Pereda wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change invocation of getEGLDisplayHandle into getEglDisplayHandle >> Conditionally add dlfcn > > Marked as reviewed by

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread Jose Pereda
On Thu, 5 Nov 2020 16:41:09 GMT, Johan Vos wrote: >> Allow the EGL functionality in monocle to leverage EGL-based systems. The >> low-level specific details about how the EGL calls should be constructed are >> left out, and a native interface (egl_ext.h) is created that can be mapped >> to

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread Johan Vos
> Allow the EGL functionality in monocle to leverage EGL-based systems. The > low-level specific details about how the EGL calls should be constructed are > left out, and a native interface (egl_ext.h) is created that can be mapped to > any low-level system. Johan Vos has updated the pull