Re: RFR: 8260165: CSSFilterTest.testCSSFilterRendering system test fails
On Mon, 22 Feb 2021 11:55:00 GMT, Arun Joseph wrote: > Issue: Initial layout delay was removed and layout() is called from > layoutTimer instead of WebPage::prePaint(). > > Fix: Re-introduce the initial layout delay. Tested on Linux and Windows, Looks good to me. - Marked as reviewed by ghb (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/408
Re: RFR: 8260165: CSSFilterTest.testCSSFilterRendering system test fails
On Wed, 24 Feb 2021 16:10:44 GMT, Kevin Rushforth wrote: >> Issue: Initial layout delay was removed and layout() is called from >> layoutTimer instead of WebPage::prePaint(). >> >> Fix: Re-introduce the initial layout delay. > > Looks good. Tested on all three platforms. @johanvos @guruhb can one of you be the second reviewer on this? - PR: https://git.openjdk.java.net/jfx/pull/408
Re: RFR: 8260165: CSSFilterTest.testCSSFilterRendering system test fails
On Mon, 22 Feb 2021 11:55:00 GMT, Arun Joseph wrote: > Issue: Initial layout delay was removed and layout() is called from > layoutTimer instead of WebPage::prePaint(). > > Fix: Re-introduce the initial layout delay. Looks good. Tested on all three platforms. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/408
Re: RFR: 8260165: CSSFilterTest.testCSSFilterRendering system test fails
On Wed, 24 Feb 2021 13:01:50 GMT, Kevin Rushforth wrote: >> Issue: Initial layout delay was removed and layout() is called from >> layoutTimer instead of WebPage::prePaint(). >> >> Fix: Re-introduce the initial layout delay. > > This seems a safe enough fix to restore the layout delay that was removed in > WebKit 610.2 (and which has caused a regression). Are there any drawbacks to > doing this? The only drawback would be layout is calculated in the next updateContent cycle instead of right after loading the first page, which is same as before WebKit 610.2. This would only cause a delay of a few milliseconds (~10 ms for this test). - PR: https://git.openjdk.java.net/jfx/pull/408
Re: RFR: 8260165: CSSFilterTest.testCSSFilterRendering system test fails
On Mon, 22 Feb 2021 11:55:00 GMT, Arun Joseph wrote: > Issue: Initial layout delay was removed and layout() is called from > layoutTimer instead of WebPage::prePaint(). > > Fix: Re-introduce the initial layout delay. This seems a safe enough fix to restore the layout delay that was removed in WebKit 610.2 (and which has caused a regression). Are there any drawbacks to doing this? - PR: https://git.openjdk.java.net/jfx/pull/408
RFR: 8260165: CSSFilterTest.testCSSFilterRendering system test fails
Issue: Initial layout delay was removed and layout() is called from layoutTimer instead of WebPage::prePaint(). Fix: Re-introduce the initial layout delay. - Commit messages: - Add comment - 8260165: CSSFilterTest.testCSSFilterRendering system test fails Changes: https://git.openjdk.java.net/jfx/pull/408/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=408=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8260165 Stats: 8 lines in 2 files changed: 6 ins; 2 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/408.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/408/head:pull/408 PR: https://git.openjdk.java.net/jfx/pull/408
