Re: RFR: 8260257: [Linux] WebView no longer reacts to some mouse events [v3]
On Wed, 24 Feb 2021 15:33:00 GMT, Arun Joseph wrote: >> Timer in RunLoopGeneric has an open bug in WebKit >> (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain >> active even after firing. >> >> Reverting back to WebCore Timer for ScrollAnimation in Linux. > > Arun Joseph has updated the pull request incrementally with one additional > commit since the last revision: > > Add sleep Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/404
Re: RFR: 8260257: [Linux] WebView no longer reacts to some mouse events [v3]
On Wed, 24 Feb 2021 15:33:00 GMT, Arun Joseph wrote: >> Timer in RunLoopGeneric has an open bug in WebKit >> (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain >> active even after firing. >> >> Reverting back to WebCore Timer for ScrollAnimation in Linux. > > Arun Joseph has updated the pull request incrementally with one additional > commit since the last revision: > > Add sleep Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/404
Re: RFR: 8260257: [Linux] WebView no longer reacts to some mouse events [v2]
On Wed, 24 Feb 2021 13:33:39 GMT, Kevin Rushforth wrote:
>> Arun Joseph has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add system test
>
> tests/system/src/test/java/test/javafx/scene/web/WebPageTest.java line 135:
>
>> 133:
>> 134: assertTrue("Timeout when waiting for focus change ",
>> Util.await(webViewStateLatch));
>> 135:
>
> I needed to add a `sleep(500)` here.
I've used `Util.sleep(1000)` instead to make it similar to the other system web
tests.
-
PR: https://git.openjdk.java.net/jfx/pull/404
Re: RFR: 8260257: [Linux] WebView no longer reacts to some mouse events [v3]
> Timer in RunLoopGeneric has an open bug in WebKit > (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain > active even after firing. > > Reverting back to WebCore Timer for ScrollAnimation in Linux. Arun Joseph has updated the pull request incrementally with one additional commit since the last revision: Add sleep - Changes: - all: https://git.openjdk.java.net/jfx/pull/404/files - new: https://git.openjdk.java.net/jfx/pull/404/files/903093ac..aea26961 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=404=02 - incr: https://webrevs.openjdk.java.net/?repo=jfx=404=01-02 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/404.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/404/head:pull/404 PR: https://git.openjdk.java.net/jfx/pull/404
Re: RFR: 8260257: [Linux] WebView no longer reacts to some mouse events [v2]
On Wed, 24 Feb 2021 13:35:33 GMT, Kevin Rushforth wrote: >> Arun Joseph has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add system test > > The new test looks good, although in order to make it pass on my slower > Ubuntu 20.04 VM, I had to increase the sleep time to 500 ms and also add a > sleep after the focus latch and before the scroll. See below. I did a little more experimenting, and the important one on my Linux VM system is the addition of the 500 ms sleep between the await on the latch and initiating the scroll. I could leave the other delay at 100 ms and it still passes for me. It may be best to increase that latter sleep to 500 anyway. - PR: https://git.openjdk.java.net/jfx/pull/404
Re: RFR: 8260257: [Linux] WebView no longer reacts to some mouse events [v2]
On Wed, 24 Feb 2021 07:11:57 GMT, Arun Joseph wrote:
>> Timer in RunLoopGeneric has an open bug in WebKit
>> (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain
>> active even after firing.
>>
>> Reverting back to WebCore Timer for ScrollAnimation in Linux.
>
> Arun Joseph has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add system test
The new test looks good, although in order to make it pass on my slower Ubuntu
20.04 VM, I had to increase the sleep time to 500 ms and also add a sleep after
the focus latch and before the scroll. See below.
tests/system/src/test/java/test/javafx/scene/web/WebPageTest.java line 135:
> 133:
> 134: assertTrue("Timeout when waiting for focus change ",
> Util.await(webViewStateLatch));
> 135:
I needed to add a `sleep(500)` here.
tests/system/src/test/java/test/javafx/scene/web/WebPageTest.java line 142:
> 140: });
> 141:
> 142: Util.sleep(100);
I needed to change this to `sleep(500)`
-
PR: https://git.openjdk.java.net/jfx/pull/404
Re: RFR: 8260257: [Linux] WebView no longer reacts to some mouse events [v2]
On Wed, 24 Feb 2021 07:11:57 GMT, Arun Joseph wrote: >> Timer in RunLoopGeneric has an open bug in WebKit >> (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain >> active even after firing. >> >> Reverting back to WebCore Timer for ScrollAnimation in Linux. > > Arun Joseph has updated the pull request incrementally with one additional > commit since the last revision: > > Add system test Great. The test fails before and succeeds after the patch. - Marked as reviewed by jvos (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/404
Re: RFR: 8260257: [Linux] WebView no longer reacts to some mouse events [v2]
> Timer in RunLoopGeneric has an open bug in WebKit > (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain > active even after firing. > > Reverting back to WebCore Timer for ScrollAnimation in Linux. Arun Joseph has updated the pull request incrementally with one additional commit since the last revision: Add system test - Changes: - all: https://git.openjdk.java.net/jfx/pull/404/files - new: https://git.openjdk.java.net/jfx/pull/404/files/480c0d98..903093ac Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=404=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx=404=00-01 Stats: 161 lines in 3 files changed: 160 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/404.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/404/head:pull/404 PR: https://git.openjdk.java.net/jfx/pull/404
Re: RFR: 8260257: [Linux] WebView no longer reacts to some mouse events
On Mon, 22 Feb 2021 15:13:55 GMT, Guru Hb wrote: >> Timer in RunLoopGeneric has an open bug in WebKit >> (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain >> active even after firing. >> >> Reverting back to WebCore Timer for ScrollAnimation in Linux. > > Looks good to me. Verified on Ubuntu 20.04 As discussed offline, an automated test would be helpful to ensure no future regression. - PR: https://git.openjdk.java.net/jfx/pull/404
Re: RFR: 8260257: [Linux] WebView no longer reacts to some mouse events
On Wed, 17 Feb 2021 14:14:35 GMT, Arun Joseph wrote: > Timer in RunLoopGeneric has an open bug in WebKit > (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain > active even after firing. > > Reverting back to WebCore Timer for ScrollAnimation in Linux. Looks good to me. Verified on Ubuntu 20.04 - Marked as reviewed by ghb (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/404
Re: RFR: 8260257: [Linux] WebView no longer reacts to some mouse events
On Wed, 17 Feb 2021 14:14:35 GMT, Arun Joseph wrote: > Timer in RunLoopGeneric has an open bug in WebKit > (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain > active even after firing. > > Reverting back to WebCore Timer for ScrollAnimation in Linux. Looks good. Tested on all three platforms (although it should only affect Linux). I confirm that on Linux scrolling via the trackpad (or by clicking in the scrollbar track) now works properly. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/404
RFR: 8260257: [Linux] WebView no longer reacts to some mouse events
Timer in RunLoopGeneric has an open bug in WebKit (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain active even after firing. Reverting back to WebCore Timer for ScrollAnimation in Linux. - Commit messages: - 8260257: [Linux] WebView no longer reacts to some mouse events Changes: https://git.openjdk.java.net/jfx/pull/404/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=404=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8260257 Stats: 8 lines in 2 files changed: 8 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/404.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/404/head:pull/404 PR: https://git.openjdk.java.net/jfx/pull/404
