On Sun, 11 Apr 2021 15:44:39 GMT, Florian Kirmaier
wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8263402
>> Minor cleanup based on codereview
>
> It shouldn't be platform-specific,
> but maybe there are s
On Wed, 7 Apr 2021 13:39:47 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8263402
>> Minor cleanup based on codereview
>
> The fix looks OK, although I left a question below about ensur
On Wed, 7 Apr 2021 13:10:29 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8263402
>> Minor cleanup based on codereview
>
> modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHel
On Fri, 26 Mar 2021 12:02:40 GMT, Florian Kirmaier
wrote:
>> Fixing a memory leak.
>> A node hard references its old parent after CSS layout and getting removed.
>> This shouldn't be the case, this is very counterintuitive.
>>
>> The fix uses a WeakReference in CSSStyleHelper for firstStyleab
On Fri, 26 Mar 2021 12:02:40 GMT, Florian Kirmaier
wrote:
>> Fixing a memory leak.
>> A node hard references its old parent after CSS layout and getting removed.
>> This shouldn't be the case, this is very counterintuitive.
>>
>> The fix uses a WeakReference in CSSStyleHelper for firstStyleab
> Fixing a memory leak.
> A node hard references its old parent after CSS layout and getting removed.
> This shouldn't be the case, this is very counterintuitive.
>
> The fix uses a WeakReference in CSSStyleHelper for firstStyleableAncestor.
> This should be fine because the CSS should only depe
