Re: RFR: 8264137: Suppress deprecation and removal warnings of internal methods [v2]
On Wed, 23 Jun 2021 11:16:09 GMT, Ajit Ghaisas wrote: >> This PR suppresses -PLINT="removal" warnings and fixes -PLINT="deprecation" >> warnings. I have created separate commits for each type of warnings for the >> ease of review. >> >> `gradle --info -PLINT="deprecation,removal"` -- results in warnings during >> build without this PR and results in no warnings with this PR. > > Ajit Ghaisas has updated the pull request incrementally with two additional > commits since the last revision: > > - Suppress/Fix LINT-deprecation warnings from tests > - Suppress LINT-removal warnings from tests Looks good. 👍 - Marked as reviewed by mhanl (Author). PR: https://git.openjdk.java.net/jfx/pull/538
Re: RFR: 8264137: Suppress deprecation and removal warnings of internal methods [v2]
On Wed, 23 Jun 2021 11:16:09 GMT, Ajit Ghaisas wrote: >> This PR suppresses -PLINT="removal" warnings and fixes -PLINT="deprecation" >> warnings. I have created separate commits for each type of warnings for the >> ease of review. >> >> `gradle --info -PLINT="deprecation,removal"` -- results in warnings during >> build without this PR and results in no warnings with this PR. > > Ajit Ghaisas has updated the pull request incrementally with two additional > commits since the last revision: > > - Suppress/Fix LINT-deprecation warnings from tests > - Suppress LINT-removal warnings from tests Test changes look good, too. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/538
Re: RFR: 8264137: Suppress deprecation and removal warnings of internal methods [v2]
> This PR suppresses -PLINT="removal" warnings and fixes -PLINT="deprecation" > warnings. I have created separate commits for each type of warnings for the > ease of review. > > `gradle --info -PLINT="deprecation,removal"` -- results in warnings during > build without this PR and results in no warnings with this PR. Ajit Ghaisas has updated the pull request incrementally with two additional commits since the last revision: - Suppress/Fix LINT-deprecation warnings from tests - Suppress LINT-removal warnings from tests - Changes: - all: https://git.openjdk.java.net/jfx/pull/538/files - new: https://git.openjdk.java.net/jfx/pull/538/files/f8dd3ae3..dcbd6169 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=538&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=538&range=00-01 Stats: 23 lines in 11 files changed: 13 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/jfx/pull/538.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/538/head:pull/538 PR: https://git.openjdk.java.net/jfx/pull/538
