On Wed, 21 Apr 2021 13:45:57 GMT, Johan Vos wrote:
> Hide accumCell when the cell is released.
> Fix for JDK-8265669
Marked as reviewed by aghaisas (Reviewer).
Thanks for the detailed answers.
-
PR: https://git.openjdk.java.net/jfx/pull/474
On Fri, 23 Apr 2021 13:48:16 GMT, Ajit Ghaisas wrote:
> The change as such is fine, but, I have two questions at a higher level -
Thanks. The answers are higher level as well, as they are more about the
expectations of updateItem()
>
> > (from JBS description) - "This will lead to a call to Ce
On Wed, 21 Apr 2021 13:45:57 GMT, Johan Vos wrote:
> Hide accumCell when the cell is released.
> Fix for JDK-8265669
The change as such is fine, but, I have two questions at a higher level -
> (from JBS description) - "This will lead to a call to Cell.updateItem(). That
> was already happening
On Wed, 21 Apr 2021 13:45:57 GMT, Johan Vos wrote:
> Hide accumCell when the cell is released.
> Fix for JDK-8265669
It looks simple and safe enough, so 1 reviewer should be fine. I'll let Ajit
review it.
-
PR: https://git.openjdk.java.net/jfx/pull/474
Hide accumCell when the cell is released.
Fix for JDK-8265669
-
Commit messages:
- Hide accumCell when the cell is released.
Changes: https://git.openjdk.java.net/jfx/pull/474/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=474&range=00
Issue: https://bugs.openjdk.jav
