Re: RFR: 8266643: Intermittent failure of HonorDeveloperSettingsTest unit test

2021-05-17 Thread Ambarish Rapte
On Mon, 17 May 2021 14:13:53 GMT, Kevin Rushforth wrote: > Maybe that can be done globally in a follow-up test bug (perhaps in a future > test sprint)? Sounds good to me too, shall raise a bug to track. - PR: https://git.openjdk.java.net/jfx/pull/496

Re: RFR: 8266643: Intermittent failure of HonorDeveloperSettingsTest unit test

2021-05-17 Thread Kevin Rushforth
On Wed, 12 May 2021 11:53:16 GMT, Ambarish Rapte wrote: > The test fails intermittently on github build. But I do not observe this > issue locally on my Ubuntu20.04 VM. > I am suspecting that the reason of failure is that the test are not cleaned > up correctly. The changes in this PR cleans up

Re: RFR: 8266643: Intermittent failure of HonorDeveloperSettingsTest unit test

2021-05-17 Thread Kevin Rushforth
On Mon, 17 May 2021 07:16:06 GMT, Ambarish Rapte wrote: > should we also include `root.getChildren().clear()` and `stage.hide()` calls ? I see no need for `root.getChildren().clear()`. I think all graphics unit tests that call `stage.show()` should call `stage.hide()` in a cleanup method, but I

Re: RFR: 8266643: Intermittent failure of HonorDeveloperSettingsTest unit test

2021-05-17 Thread Ambarish Rapte
On Wed, 12 May 2021 11:53:16 GMT, Ambarish Rapte wrote: > The test fails intermittently on github build. But I do not observe this > issue locally on my Ubuntu20.04 VM. > I am suspecting that the reason of failure is that the test are not cleaned > up correctly. The changes in this PR cleans up

Re: RFR: 8266643: Intermittent failure of HonorDeveloperSettingsTest unit test

2021-05-17 Thread Kevin Rushforth
On Wed, 12 May 2021 11:53:16 GMT, Ambarish Rapte wrote: > The test fails intermittently on github build. But I do not observe this > issue locally on my Ubuntu20.04 VM. > I am suspecting that the reason of failure is that the test are not cleaned > up correctly. The changes in this PR cleans up

RFR: 8266643: Intermittent failure of HonorDeveloperSettingsTest unit test

2021-05-17 Thread Ambarish Rapte
The test fails intermittently on github build. But I do not observe this issue locally on my Ubuntu20.04 VM. I am suspecting that the reason of failure is that the test are not cleaned up correctly. The changes in this PR cleans up the test, by removing all children added to root and hiding the